From: Danny Smith <dannysmith@clear.net.nz>
To: Andrew Cagney <cagney@gnu.org>
Cc: binutils@sources.redhat.com
Subject: Re[3]: Cygwin tester? Was: [rfa] Add bfd-in-memory io vector
Date: Wed, 05 May 2004 11:09:00 -0000 [thread overview]
Message-ID: <000701c431c7$eb3db800$2a6d65da@DANNY> (raw)
In-Reply-To: <000901c43096$b554fcd0$6e6d65da@DANNY>
----- Original Message -----
From: "Danny Smith"
|
| From: "Danny Smith"
|
| |
| | | > On Sat, May 01, 2004 at 02:10:31PM -0400, Andrew Cagney wrote:
| | | >
| | | >>> The testing comment still applies though.
| | | >
| | | >
| | | > Given DJ's comment, I think you should test this on cygwin before
| | | > committing. If you can't do this yourself, convince someone else
| | | > to do so for you. OK to commit once you've done this.
| | | >
Hi,
Although the patchset works fine (if I add the checks for HAVE_GET[GU]ID)
when building .exe files on pe targets, it fails when building dll's
(segfault in bfd/bfdio.c:bfd_bread when forwarding args to iovec->bread)
With binutils built with CFLAGS="-g -O2", gcc-3.4.0, mingw32:
cat > foo.c
int foo = 1;
^Z
gcc -shared -ofoo.dll foo.c
raises the segfault in bfd_bread.
Actually, the above testcase fails since your 21-April patch.
The problem occurs when pe-dll.c code calls bread with a NULL file, asking for zero bytes
(see comment in cache.c:cache_bread).
The problem can be avoided by doing the cache_bread FIXME in bfd_bread, ie:
*** bfdio.c.cagney Mon May 03 10:02:13 2004
--- bfdio.c Tue May 04 11:26:40 2004
*************** bfd_bread (void *ptr, bfd_size_type size
*** 104,109 ****
--- 104,113 ----
{
size_t nread;
+ /* See FIXME in cache.c:cache_bread(). */
+ if (size == 0)
+ return 0;
+
nread = abfd->iovec->bread (abfd, ptr, size);
if (nread != (size_t) -1)
abfd->where += nread;
With above patch, simple dll build is okay.
But this looks a bit strange in peicode.h:pe_ILF_build_a_bfd()
+ vars.bim = _bfd_in_memory (abfd, abfd->flags, vars.bim->buffer,
+ vars.bim->size);
Should that be:
vars.bim = _bfd_in_memory (abfd, abfd->flags, bim.buffer, bim.size);
Danny
next prev parent reply other threads:[~2004-05-05 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-03 22:48 Re[2]: " Danny Smith
2004-05-05 11:09 ` Danny Smith [this message]
2004-05-05 15:57 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701c431c7$eb3db800$2a6d65da@DANNY' \
--to=dannysmith@clear.net.nz \
--cc=binutils@sources.redhat.com \
--cc=cagney@gnu.org \
--cc=dannysmith@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).