From: "James Greenhalgh" <james.greenhalgh@arm.com>
To: "'Nick Clifton'" <nickc@redhat.com>
Cc: <binutils@sourceware.org>
Subject: RE: [Patch ARM Gas] - strexh/strexb warn for bad addressing modes.
Date: Fri, 29 Jul 2011 16:16:00 -0000 [thread overview]
Message-ID: <000c01cc4e04$e44ae110$ace0a330$@greenhalgh@arm.com> (raw)
In-Reply-To: <4E32CCDE.2090505@redhat.com>
Hi Nick,
Apologies for the lack of clarity.
strexh and strexb do not have writeback modes in either arm or thumb
mode. An unpatched assembler will return an error for the following
under ARM, but not for thumb.
strexh r1, r2, [r3, #0]!
This was line 9 of strex-bad-t.s which `FAIL's on an unpatched assembler
for me.
Likewise,
strexb r1, r2, [r3, #0]!
The patch adds the error for thumb mode.
The test cases are perhaps a little... over-enthusiastic in testing bad
addressing modes for strexh/strexb, but form a thorough check that
problem cases for this instruction are reported.
Thanks,
James
> -----Original Message-----
> From: Nick Clifton [mailto:nickc@redhat.com]
> Sent: 29 July 2011 16:08
> To: James Greenhalgh
> Cc: binutils@sourceware.org
> Subject: Re: [Patch ARM Gas] - strexh/strexb warn for bad addressing
> modes.
>
> Hi James,
>
> > This patch fixes an issue with strex[b/h] in thumb mode.
>
> What issue ? As far as I can see the current version of gas does
> correctly detect and report these bad addressing modes. Certainly when
> I ran the test cases you supplied through an unpatched assembler they
> all worked.
>
> Cheers
> Nick
>
next prev parent reply other threads:[~2011-07-29 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 20:16 James Greenhalgh
2011-07-29 15:58 ` Nick Clifton
2011-07-29 16:16 ` James Greenhalgh [this message]
2011-08-03 11:37 ` Nick Clifton
2011-09-20 23:14 ` hazelnusse
2011-09-22 12:59 ` James Greenhalgh
2011-10-13 8:18 ` Nick Clifton
[not found] ` <4e7b3128.41c8e30a.6565.ffff9e55SMTPIN_ADDED@mx.google.com>
2011-09-22 16:07 ` Luke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000c01cc4e04$e44ae110$ace0a330$@greenhalgh@arm.com' \
--to=james.greenhalgh@arm.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).