* [PATCH, ld, Aarch64] Fix name of aarch64 reloc test to match reloc number
@ 2015-07-24 9:02 Thomas Preud'homme
2015-08-03 10:38 ` Thomas Preud'homme
2015-08-11 16:15 ` Nick Clifton
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Preud'homme @ 2015-07-24 9:02 UTC (permalink / raw)
To: binutils
The name of the test added in GNU ld for GNUTOOLS-4952 is inconsistent with
the relocation being tested (bad copy paste). This patch fix that.
ChangeLog entry is as follows:
*** ld/testsuite/ChangeLog ***
2015-07-10 Thomas Preud'homme <thomas.preudhomme@arm.com>
* ld-aarch64/aarch64-elf.exp: Rename relocs-257-symbolic-func to
relocs-1027-symbolic-func.
* ld-aarch64/relocs-257-symbolic-func.d: Rename to ...
* ld-aarch64/relocs-1027-symbolic-func.d: ... this.
* ld-aarch64/relocs-257-symbolic-func.s: Rename to ...
* ld-aarch64/relocs-1027-symbolic-func.s: ... this.
diff --git a/ld/testsuite/ld-aarch64/aarch64-elf.exp b/ld/testsuite/ld-aarch64/aarch64-elf.exp
index 021343b..0ffbaa3 100644
--- a/ld/testsuite/ld-aarch64/aarch64-elf.exp
+++ b/ld/testsuite/ld-aarch64/aarch64-elf.exp
@@ -193,7 +193,7 @@ run_dump_test "ifunc-21"
run_dump_test "ifunc-22"
run_dump_test "relasz"
-run_dump_test "relocs-257-symbolic-func"
+run_dump_test "relocs-1027-symbolic-func"
set aarch64elflinktests {
{"ld-aarch64/so with global symbol" "-shared" "" "" {copy-reloc-so.s}
diff --git a/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.d b/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.d
new file mode 100644
index 0000000..19b81f3
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.d
@@ -0,0 +1,5 @@
+#source: relocs-1027-symbolic-func.s
+#ld: -shared -Bsymbolic-functions
+#readelf: -r --wide
+#...
+.* +R_AARCH64_RELATIVE +.*
diff --git a/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.s b/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.s
new file mode 100644
index 0000000..35d5ba8
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.s
@@ -0,0 +1,11 @@
+ .text
+ .global tempy
+ .type tempy, %function
+tempy:
+ .size tempy, .-tempy
+ .section .data.rel
+ .align 3
+ .type tempy_ptr, %object
+ .size tempy_ptr, 8
+tempy_ptr:
+ .xword tempy
diff --git a/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.d b/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.d
deleted file mode 100644
index 810fd43..0000000
--- a/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.d
+++ /dev/null
@@ -1,5 +0,0 @@
-#source: relocs-257-symbolic-func.s
-#ld: -shared -Bsymbolic-functions
-#readelf: -r --wide
-#...
-.* +R_AARCH64_RELATIVE +.*
diff --git a/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.s b/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.s
deleted file mode 100644
index 35d5ba8..0000000
--- a/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.s
+++ /dev/null
@@ -1,11 +0,0 @@
- .text
- .global tempy
- .type tempy, %function
-tempy:
- .size tempy, .-tempy
- .section .data.rel
- .align 3
- .type tempy_ptr, %object
- .size tempy_ptr, 8
-tempy_ptr:
- .xword tempy
No regression was observed when running the testsuite for aarch64-none-linux-gnu.
Is this ok for master?
Best regards,
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH, ld, Aarch64] Fix name of aarch64 reloc test to match reloc number
2015-07-24 9:02 [PATCH, ld, Aarch64] Fix name of aarch64 reloc test to match reloc number Thomas Preud'homme
@ 2015-08-03 10:38 ` Thomas Preud'homme
2015-08-11 16:15 ` Nick Clifton
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Preud'homme @ 2015-08-03 10:38 UTC (permalink / raw)
To: binutils
Ping?
Best regards,
Thomas
> -----Original Message-----
> From: binutils-owner@sourceware.org [mailto:binutils-
> owner@sourceware.org] On Behalf Of Thomas Preud'homme
> Sent: Friday, July 24, 2015 5:03 PM
> To: binutils@sourceware.org
> Subject: [PATCH, ld, Aarch64] Fix name of aarch64 reloc test to match
> reloc number
>
> The name of the test added in GNU ld for GNUTOOLS-4952 is
> inconsistent with
> the relocation being tested (bad copy paste). This patch fix that.
>
> ChangeLog entry is as follows:
>
> *** ld/testsuite/ChangeLog ***
>
> 2015-07-10 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * ld-aarch64/aarch64-elf.exp: Rename relocs-257-symbolic-func to
> relocs-1027-symbolic-func.
> * ld-aarch64/relocs-257-symbolic-func.d: Rename to ...
> * ld-aarch64/relocs-1027-symbolic-func.d: ... this.
> * ld-aarch64/relocs-257-symbolic-func.s: Rename to ...
> * ld-aarch64/relocs-1027-symbolic-func.s: ... this.
>
>
> diff --git a/ld/testsuite/ld-aarch64/aarch64-elf.exp b/ld/testsuite/ld-
> aarch64/aarch64-elf.exp
> index 021343b..0ffbaa3 100644
> --- a/ld/testsuite/ld-aarch64/aarch64-elf.exp
> +++ b/ld/testsuite/ld-aarch64/aarch64-elf.exp
> @@ -193,7 +193,7 @@ run_dump_test "ifunc-21"
> run_dump_test "ifunc-22"
>
> run_dump_test "relasz"
> -run_dump_test "relocs-257-symbolic-func"
> +run_dump_test "relocs-1027-symbolic-func"
>
> set aarch64elflinktests {
> {"ld-aarch64/so with global symbol" "-shared" "" "" {copy-reloc-so.s}
> diff --git a/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.d
> b/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.d
> new file mode 100644
> index 0000000..19b81f3
> --- /dev/null
> +++ b/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.d
> @@ -0,0 +1,5 @@
> +#source: relocs-1027-symbolic-func.s
> +#ld: -shared -Bsymbolic-functions
> +#readelf: -r --wide
> +#...
> +.* +R_AARCH64_RELATIVE +.*
> diff --git a/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.s
> b/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.s
> new file mode 100644
> index 0000000..35d5ba8
> --- /dev/null
> +++ b/ld/testsuite/ld-aarch64/relocs-1027-symbolic-func.s
> @@ -0,0 +1,11 @@
> + .text
> + .global tempy
> + .type tempy, %function
> +tempy:
> + .size tempy, .-tempy
> + .section .data.rel
> + .align 3
> + .type tempy_ptr, %object
> + .size tempy_ptr, 8
> +tempy_ptr:
> + .xword tempy
> diff --git a/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.d
> b/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.d
> deleted file mode 100644
> index 810fd43..0000000
> --- a/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.d
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -#source: relocs-257-symbolic-func.s
> -#ld: -shared -Bsymbolic-functions
> -#readelf: -r --wide
> -#...
> -.* +R_AARCH64_RELATIVE +.*
> diff --git a/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.s
> b/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.s
> deleted file mode 100644
> index 35d5ba8..0000000
> --- a/ld/testsuite/ld-aarch64/relocs-257-symbolic-func.s
> +++ /dev/null
> @@ -1,11 +0,0 @@
> - .text
> - .global tempy
> - .type tempy, %function
> -tempy:
> - .size tempy, .-tempy
> - .section .data.rel
> - .align 3
> - .type tempy_ptr, %object
> - .size tempy_ptr, 8
> -tempy_ptr:
> - .xword tempy
>
> No regression was observed when running the testsuite for aarch64-
> none-linux-gnu.
>
> Is this ok for master?
>
> Best regards,
>
> Thomas
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, ld, Aarch64] Fix name of aarch64 reloc test to match reloc number
2015-07-24 9:02 [PATCH, ld, Aarch64] Fix name of aarch64 reloc test to match reloc number Thomas Preud'homme
2015-08-03 10:38 ` Thomas Preud'homme
@ 2015-08-11 16:15 ` Nick Clifton
2015-08-12 1:36 ` Thomas Preud'homme
1 sibling, 1 reply; 4+ messages in thread
From: Nick Clifton @ 2015-08-11 16:15 UTC (permalink / raw)
To: Thomas Preud'homme, binutils
Hi Thomas,
> 2015-07-10 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * ld-aarch64/aarch64-elf.exp: Rename relocs-257-symbolic-func to
> relocs-1027-symbolic-func.
> * ld-aarch64/relocs-257-symbolic-func.d: Rename to ...
> * ld-aarch64/relocs-1027-symbolic-func.d: ... this.
> * ld-aarch64/relocs-257-symbolic-func.s: Rename to ...
> * ld-aarch64/relocs-1027-symbolic-func.s: ... this.
Approved - please apply. Sorry for the delay in reviewing.
Cheers
Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH, ld, Aarch64] Fix name of aarch64 reloc test to match reloc number
2015-08-11 16:15 ` Nick Clifton
@ 2015-08-12 1:36 ` Thomas Preud'homme
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Preud'homme @ 2015-08-12 1:36 UTC (permalink / raw)
To: 'Nick Clifton', binutils
> From: Nick Clifton [mailto:nickc@redhat.com]
> Sent: Wednesday, August 12, 2015 12:16 AM
>
> > 2015-07-10 Thomas Preud'homme <thomas.preudhomme@arm.com>
> >
> > * ld-aarch64/aarch64-elf.exp: Rename relocs-257-symbolic-func to
> > relocs-1027-symbolic-func.
> > * ld-aarch64/relocs-257-symbolic-func.d: Rename to ...
> > * ld-aarch64/relocs-1027-symbolic-func.d: ... this.
> > * ld-aarch64/relocs-257-symbolic-func.s: Rename to ...
> > * ld-aarch64/relocs-1027-symbolic-func.s: ... this.
>
> Approved - please apply. Sorry for the delay in reviewing.
Done, thanks.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-12 1:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-24 9:02 [PATCH, ld, Aarch64] Fix name of aarch64 reloc test to match reloc number Thomas Preud'homme
2015-08-03 10:38 ` Thomas Preud'homme
2015-08-11 16:15 ` Nick Clifton
2015-08-12 1:36 ` Thomas Preud'homme
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).