From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 859303858C83 for ; Wed, 19 Oct 2022 11:51:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 859303858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-x62b.google.com with SMTP id y14so39270342ejd.9 for ; Wed, 19 Oct 2022 04:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:to:from :from:to:cc:subject:date:message-id:reply-to; bh=+7KDrG16OymOcghXrAW76iN6LXwsETfIw5vRd3rGhhQ=; b=Oeu9riyxzgWyp+B7kFWxVahY+L8S4n9P4dp0+x/7YAc/ngiF9+Yfa8dz3iQU4kP+Uw EsPWzZSTaSaoaobidAi0uDdV/w4Ga0AkAffTsgfDe/JTmMVeEERgt84UHuaKP1+XB1GX vCeAQQxeNqdbf0cjRkoM7qKB2sQuYpWty55cO/hA10FkTs0a439Bpxmboy6aNwz87oDV Ak117n2FB5OSTQupZoVj3CyuNDn+PsiKCPt3ROPi77bUOSitKt0qlvHs73+R9HMBw7fs V4fJPv+mOdyFuMdkwejYuEvGCMpYDuE+URW8vr96ioq1iZNlH2hjag0U7e7II/XSGDea 9XZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=thread-index:content-language:content-transfer-encoding :mime-version:message-id:date:subject:in-reply-to:references:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+7KDrG16OymOcghXrAW76iN6LXwsETfIw5vRd3rGhhQ=; b=LMgw31QB3rFyLsP2PbfsvdWKUF1HZ4naUDn3g9YJfkkoCgcK+Rdr2mLG4IFZaFGW6y zuqLqE4JmfdNFJrHnso4dI2G8RogKIIvGh9qM/NExeXQ9THgVzTraVYshCvfeAMrG/ZC +2ShumIchw0dQkhUGKN585NoW16zCF8jM/6yTWbI50r3/qd4FytxeUl7l7cXXmNPQC7E +eRHGSS4irMpRs5oe2fiBy7vW4A5bxmZtxmYPWWf1P+Efzz0y4f9y9890kkyvT7KES8u QaTfW4GHuD2kVl+DgdECAmUlkRl1X+UbzXg3ScbVFAkUTfrUOE1Rn1v59YtOEDEunuiX tAbw== X-Gm-Message-State: ACrzQf38YPiiRWSBpXa80sEn6JUAqLn05990rEZ9yH3EYSBBPT1OsmJe un++bqS0F7+lcurC9S8MdBfIDpvfIFUOY8lS X-Google-Smtp-Source: AMsMyM4ZZcWWt3OZn1GR3Xzb8eEYjHgB2Qg4SXxZYbyQJfimRfPS5y7/npcme2ezCfiQCZbwflKdXA== X-Received: by 2002:a17:907:94d6:b0:78d:f947:7cf5 with SMTP id dn22-20020a17090794d600b0078df9477cf5mr6454677ejc.446.1666180266355; Wed, 19 Oct 2022 04:51:06 -0700 (PDT) Received: from zach1 ([94.230.145.250]) by smtp.gmail.com with ESMTPSA id fg4-20020a056402548400b0045bef7cf489sm10188428edb.89.2022.10.19.04.51.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Oct 2022 04:51:05 -0700 (PDT) From: To: "'Andrew Burgess'" , References: <027ae69a-636b-6757-297a-eec42936401e@linaro.org> <000401d8e3a0$0373e8b0$0a5bba10$@linaro.org> <871qr4awvl.fsf@redhat.com> In-Reply-To: <871qr4awvl.fsf@redhat.com> Subject: RE: [PATCH v3] aarch64-pe support for LD, GAS and BFD Date: Wed, 19 Oct 2022 13:51:09 +0200 Message-ID: <001001d8e3b1$149cb340$3dd619c0$@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIXbaF26JKxyTesY9plBnABnLGQyQJy9TfoAluJn5KtchHVYA== X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks Andrew - much appreciated. That taught me a valuable lesson to do more testing with '--enable-targets=all' next time. Zac -----Original Message----- From: Andrew Burgess Sent: 19 October 2022 13:14 To: zac.walker@linaro.org; binutils@sourceware.org Subject: RE: [PATCH v3] aarch64-pe support for LD, GAS and BFD Zac Walker via Binutils writes: > Sorry - this patch caused a build break: > > checking for PT_GETDBREGS... /usr/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.data.rel.ro+0x48): undefined reference to `aarch64_pe_le_vec' > /usr/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.data.rel.ro+0x17c0): undefined reference to `aarch64_pe_le_vec' > collect2: error: ld returned 1 exit status > make[4]: *** [Makefile:1276: as-new] Error 1 > > Investigating now and hope to fix soon (or roll back.) I just pushed the patch below to fix this issue. Just needed to run autoreconf. Thanks, Andrew --- commit 6d6ae7c23dd59fe16f3e366e969b927d97fe5e01 Author: Andrew Burgess Date: Wed Oct 19 12:00:42 2022 +0100 bfd: fix undefined references to aarch64_pe_le_vec After commit: commit c60b3806799abf1d7f6cf5108a1b0e733a950b13 Date: Wed Oct 19 10:57:12 2022 +0200 aarch64-pe support for LD, GAS and BFD It appears that bfd/Makefile.in and bfd/configure were not regenerated correctly. The differences in the configure file are only whitespace, but in Makefile.in a critical reference to pe-aarch64.lo was missing. diff --git a/bfd/Makefile.in b/bfd/Makefile.in index 3f520355829..b906976a1c0 100644 --- a/bfd/Makefile.in +++ b/bfd/Makefile.in @@ -1048,6 +1048,7 @@ BFD64_BACKENDS = \ pe-loongarch64igen.lo \ pe-x86_64.lo \ pei-aarch64.lo \ + pe-aarch64.lo \ pei-ia64.lo \ pei-loongarch64.lo \ pei-x86_64.lo \ @@ -1700,6 +1701,7 @@ distclean-compile: @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pc532-mach.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pdb.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pdp11.Plo@am__quote@ +@AMDEP_TRUE@@am__include@ +@am__quote@./$(DEPDIR)/pe-aarch64.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-aarch64igen.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-arm-wince.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-arm.Plo@am__quote@ diff --git a/bfd/configure b/bfd/configure index bae9d17c515..1c1760670cb 100755 --- a/bfd/configure +++ b/bfd/configure @@ -13604,7 +13604,7 @@ do aarch64_elf64_le_cloudabi_vec) tb="$tb elf64-aarch64.lo elfxx-aarch64.lo elf-ifunc.lo elf64.lo $elf"; target_size=64 ;; aarch64_mach_o_vec) tb="$tb mach-o-aarch64.lo"; target_size=64 ;; aarch64_pei_le_vec) tb="$tb pei-aarch64.lo pe-aarch64igen.lo $coff"; target_size=64 ;; - aarch64_pe_le_vec) tb="$tb pe-aarch64.lo pe-aarch64igen.lo $coff"; target_size=64 ;; + aarch64_pe_le_vec) tb="$tb pe-aarch64.lo pe-aarch64igen.lo $coff"; target_size=64 ;; alpha_ecoff_le_vec) tb="$tb coff-alpha.lo ecoff.lo $ecoff"; target_size=64 ;; alpha_elf64_vec) tb="$tb elf64-alpha.lo elf64.lo $elf"; target_size=64 ;; alpha_elf64_fbsd_vec) tb="$tb elf64-alpha.lo elf64.lo $elf"; target_size=64 ;;