From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25095 invoked by alias); 24 Mar 2005 20:59:28 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 25039 invoked from network); 24 Mar 2005 20:59:23 -0000 Received: from unknown (HELO smtp2.clear.net.nz) (203.97.37.27) by sourceware.org with SMTP; 24 Mar 2005 20:59:23 -0000 Received: from DANNY (218-101-109-32.dialup.clear.net.nz [218.101.109.32]) by smtp2.clear.net.nz (CLEAR Net Mail) with SMTP id <0IDV004DVJMFKH@smtp2.clear.net.nz> for binutils@sources.redhat.com; Fri, 25 Mar 2005 08:59:05 +1200 (NZST) Date: Thu, 24 Mar 2005 23:37:00 -0000 From: Danny Smith Subject: Re: [Patch] Fix -Werror fallout in binutils/winduni.c (and fix a FIXME) To: Nick Clifton , dannysmith@users.sourceforge.net Cc: binutils Reply-to: Danny Smith Message-id: <001d01c530b4$2a391e00$206d65da@DANNY> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 7bit References: <20050324103454.87120.qmail@web50901.mail.yahoo.com> <4242AB80.7040807@redhat.com> X-SW-Source: 2005-03/txt/msg00751.txt.bz2 Nick Clifton wrote: > Hi Danny, > >> 2005-03-24 Danny Smith >> >> * winduni.c (unicode_from_ascii): Don't declared variables >> 's' and 'w' if _WIN32. Use MultiByteToWideChar to set the unicode >> string len. > > Approved - please apply. > > Cheers > Nick > > PS. What configure target did you use to uncover this problem ? i686-pc-mingw Danny