From: "Vsevolod Alekseyev" <sevaa@sprynet.com>
To: "'Nick Clifton'" <nickc@redhat.com>,
"'Tom Tromey'" <tom@tromey.com>, <binutils@sourceware.org>
Subject: RE: bad patch - also not on list?
Date: Mon, 20 Nov 2023 09:55:02 -0500 [thread overview]
Message-ID: <002501da1bc1$8af374e0$a0da5ea0$@sprynet.com> (raw)
In-Reply-To: <6f60fc6b-1bce-4344-a906-d3ed3489aae4@redhat.com>
I don't recall removing that fragment on purpose. Could've been an artifact of working with a less than latest version. Sorry for that.
To the best of my recollection, the shortcut table had nothing to do with the issue I was trying to address.
Please feel free to revert.
-----Original Message-----
From: Nick Clifton <nickc@redhat.com>
Sent: Monday, November 20, 2023 9:33 AM
To: Tom Tromey <tom@tromey.com>; binutils@sourceware.org
Cc: Vsevolod Alekseyev <sevaa@sprynet.com>
Subject: Re: bad patch - also not on list?
Hi Tom,
> I noticed that this commit:
>
> commit b05efa39b47995db08c5537e4504271c8727702a
> ... removes several hunks from display_gdb_index, causing readelf to
> be incapable of reading v9 indices.
Ah, I did notice that and wonder.
> I think this was probably done in error.
I think so. It looks like it might be just one delta that is causing the problem:
@@ -10934,33 +10788,6 @@ display_gdb_index (struct dwarf_section *section,
}
}
- if (version >= 9)
- {
- printf (_("\nShortcut table:\n"));
-
- if (shortcut_table_offset + 8 > constant_pool_offset)
- {
- warn (_("Corrupt shortcut table in the %s section.\n"), section->name);
- return 0;
- }
-
- uint32_t lang = byte_get_little_endian (shortcut_table, 4);
- printf (_("Language of main: "));
- display_lang (lang);
- printf ("\n");
-
- uint32_t name_offset = byte_get_little_endian (shortcut_table + 4, 4);
- printf (_("Name of main: "));
- if (name_offset >= section->size - constant_pool_offset)
- {
- printf (_("<corrupt offset: %x>\n"), name_offset);
- warn (_("Corrupt name offset of 0x%x found for name of main\n"),
- name_offset);
- }
- else
- printf ("%s\n", constant_pool + name_offset);
- }
-
return 1;
}
If that code is restored, does v9 functionality then return ?
> However, I also could not find
> this patch on the mailing list.
It was posted to the PR, and I thought that I had seen it on the mailing list too. But obviously I was wrong. Sorry about that.
Cheers
Nick
next prev parent reply other threads:[~2023-11-20 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 6:22 Tom Tromey
2023-11-20 14:32 ` Nick Clifton
2023-11-20 14:55 ` Vsevolod Alekseyev [this message]
2023-11-20 15:00 ` Tom Tromey
2023-11-20 16:09 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002501da1bc1$8af374e0$a0da5ea0$@sprynet.com' \
--to=sevaa@sprynet.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).