From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3671 invoked by alias); 25 Mar 2011 21:44:13 -0000 Received: (qmail 3662 invoked by uid 22791); 25 Mar 2011 21:44:12 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Mar 2011 21:44:08 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p2PLhvEf056192 ; Fri, 25 Mar 2011 22:43:57 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms6.u-strasbg.fr [130.79.204.15]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2PLhuCY074987 ; Fri, 25 Mar 2011 22:43:57 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2PLhtWj092397 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Fri, 25 Mar 2011 22:43:56 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Nick Clifton'" Cc: "'Binutils'" References: <-8460070221060995487@unknownmsgid> <-6930711422310680743@unknownmsgid> <4D63D49D.90101@redhat.com> <-2339605939192327273@unknownmsgid> <-3886800211494155692@unknownmsgid> <1561346207520594884@unknownmsgid> <5095785081977025060@unknownmsgid> <00d601cbd4f0$c911af10$5b350d30$@muller@ics-cnrs.unistra.fr> <4D8CB1F5.6020108@redhat.com> <000a01cbeb04$0c0e6e60$242b4b20$@muller@ics-cnrs.unistra.fr> <4D8CD936.807080! 6@redhat.com> In-Reply-To: <4D8CD936.8070806@redhat.com> Subject: RE: [RFA] Supplemtal patch for use only dwarf_vma types in dwarf code Date: Fri, 25 Mar 2011 21:44:00 -0000 Message-ID: <002d01cbeb35$bf3e5b40$3dbb11c0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00467.txt.bz2 > -----Message d'origine----- > De=A0: binutils-owner@sourceware.org [mailto:binutils-owner@sourceware.or= g] De > la part de Nick Clifton > Envoy=E9=A0: vendredi 25 mars 2011 19:05 > =C0=A0: Pierre Muller > Cc=A0: 'Kai Tietz'; 'H.J. Lu'; 'Binutils' > Objet=A0: Re: [RFA] Supplemtal patch for use only dwarf_vma types in dwarf > code >=20 > Hi Pierre, >=20 > > I have no real idea if those three cases are > > really variables that can reach up to values that > > do not fit in 4-bytes but it can not really hurt, can it? >=20 > Agreed. >=20 > > ChangeLog entry: > > 2011-03-25 Pierre Muller > > > > * dwarf.c (decode_location_expression): Use dwarf_vmatoa > > function to display DW_OP_addr OP. > > (process_debug_info): Use dwarf_vma type for local variables > > length and type_offset. >=20 > Approved and applied - note: there were a couple of places where the > "length" variable was being displayed in a printf() style output, so I > updated these to use the dwarf_vmatoa() function as well. Thanks for the approval. Just a small nit: I noticed that the indentation of the patch seems strange (modified lines are 1 column less indented) I think it is related to tab/spaces issues... Pierre