From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30422 invoked by alias); 11 Jan 2005 18:01:22 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 30382 invoked from network); 11 Jan 2005 18:01:15 -0000 Received: from unknown (HELO lon-del-01.spheriq.net) (195.46.50.97) by sourceware.org with SMTP; 11 Jan 2005 18:01:15 -0000 Received: from lon-inc-10.spheriq.net ([195.46.50.74]) by lon-del-01.spheriq.net with ESMTP id j0BI1BVR026710 for ; Tue, 11 Jan 2005 18:01:11 GMT Received: from lon-out-01.spheriq.net (lon-out-01.spheriq.net [195.46.50.129]) by lon-inc-10.spheriq.net with ESMTP id j0BI1Bfe000613 for ; Tue, 11 Jan 2005 18:01:11 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-01.spheriq.net with ESMTP id j0BI19r1002062 for ; Tue, 11 Jan 2005 18:01:10 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id j0BI18bU027629 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Tue, 11 Jan 2005 18:01:09 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 578D6DA46; Tue, 11 Jan 2005 18:01:08 +0000 (GMT) Received: by zeta.dmz-eu.st.com (STMicroelectronics, from userid 60012) id 15C974754B; Tue, 11 Jan 2005 18:01:48 +0000 (GMT) Received: from zeta.dmz-eu.st.com (localhost [127.0.0.1]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D0BD775969; Tue, 11 Jan 2005 18:01:47 +0000 (UTC) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2A32247299; Tue, 11 Jan 2005 18:01:47 +0000 (GMT) Received: from terrorhawk (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.4.4-GR) with ESMTP id ASH02523 (AUTH "andrew stubbs"); Tue, 11 Jan 2005 18:01:05 GMT From: Andrew STUBBS To: "'Nick Clifton'" Cc: "'Alexandre Oliva'" , , "'Joern RENNECKE'" Subject: RE: Broken SH2a patches Date: Tue, 11 Jan 2005 18:01:00 -0000 Organization: STMicroelectronics Message-ID: <003001c4f807$ae922790$0d0f81a4@uk.w2k.superh.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit In-Reply-To: <41C70ABC.8050903@redhat.com> X-O-Virus-Status: No X-O-URL-Status: Not Scanned X-O-CSpam-Status: Not Scanned X-O-Spam-Status: Not scanned X-O-Image-Status: Not Scanned X-O-Att-Status: No X-SpheriQ-Ver: 1.8.3 X-SW-Source: 2005-01/txt/msg00108.txt.bz2 Hi Nick, I have found another problem with your patch. Your patch has: #define arch_sh2a_or_sh3e (arch_sh2a_sh4_base) #define arch_sh2a_or_sh4 (arch_sh2a_sh4_base |arch_sh_dp_fpu) Which should be: #define arch_sh2a_or_sh3e (arch_sh2a_sh4_base|arch_sh_no_mmu |arch_sh_sp_fpu) #define arch_sh2a_or_sh4 (arch_sh2a_sh4_base|arch_sh_no_mmu |arch_sh_dp_fpu) Otherwise the -isa=sh2a-or-sh3e and -isa=sh2a-or-sh4 options cause the assembler to reject all instructions, which isn't helpful. I am developing a new script for the testsuite which will hopefully point all these issues out in future, should anybody make any broken changes. It hasn't found any issues with your patch other than the ones I have already pointed out (although I have had to modifiy sh-opc.h a little to make it work, so maybe I am not testing the same thing). Interestingly, one thing my script has exposed is that mul.l is defined twice! Once for sh2 and once for sh1, which is obviously wrong. -- Andrew Stubbs andrew.stubbs@st.com andrew.stubbs@superh.com