From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9988 invoked by alias); 23 Feb 2011 21:55:17 -0000 Received: (qmail 9977 invoked by uid 22791); 23 Feb 2011 21:55:16 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Feb 2011 21:55:11 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p1NLt67V038622 ; Wed, 23 Feb 2011 22:55:06 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms6.u-strasbg.fr [130.79.204.15]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p1NLt6fQ028950 ; Wed, 23 Feb 2011 22:55:06 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p1NLt4ZY084882 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Wed, 23 Feb 2011 22:55:05 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Kai Tietz'" , "'H.J. Lu'" Cc: "'Binutils'" References: <-8460070221060995487@unknownmsgid> <-6930711422310680743@unknownmsgid> <4D63D49D.90101@redhat.com> <-2339605939192327273@unknownmsgid> In-Reply-To: Subject: RE: [RFC patch]: Adjust the use of 'long' type in dwarf2.h header Date: Wed, 23 Feb 2011 21:55:00 -0000 Message-ID: <003001cbd3a4$5459f530$fd0ddf90$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00285.txt.bz2 > Applied patch don't have those types any more. I introduced them in > initial patch under assumption structures in include/dwarf2.h should > be host-independent. As now those structures are moved into binutils > private header binutils/dwarf.h there is no need to have here new > types and patch uses bfd_vma/bfd_signed_vma. Whoops, my fault, indeed! > So what exactly is the point where you see here still the use of > dw2_vma_t/dw2_svma_t? Oh, sorry, you are right, I didn't realize that the new introduced type called 'dwarf_vma' was in fact introduced back to 2010 ... by a commit by H.J. Lu from 2010-11-21. So that my question in fact should have been sent to H.J. Lu, not to you. So let me re-ask the question to the right person: please excuse me for asking this so late, but I don't really understand why you had to introduce a new 'dwarf_vma' type when we already have a 'bfd_vma' type that must be unsigned 64-bit as soon as BFD64 macro is defined... See definitions in bfd/bfd-in.h or bfd/bfd-in2.h This macro should be set if any of the supported target is a 64-bit target so it should be possible to use that type, no? But of course, I might be missing some important point, could you please explain to me in which case a 64-bit dwarf_vma could be necessary without BFD64 being set. (I just realized in between that dwarf_vma is an unsigned type.) I still think that my question is valid, but I was unable to find the discussion about the patch in the mailing list which might contain an explanation. H.J., could you please give me a pointer to the thread where the patch is explained or comment on my question? Thanks in advance, Pierre Muller GDB pascal language maintainer