RE: [PATCH] GAS fix section alignment for aarch64-pe

[<zac.walker@linaro.org>]

Hi Alan, Thanks for the feedback. 

You are correct - looks like I was over-focused on getting the write method working for various failing tests. Your example is
useful to show missing noops. From what I can see the changes to md_section_align seem necessary for COFF but unrelated to the write
issue. (Assuming the fix is HANDLE_ALIGN specific.) 

I will re-work the patch and do more testing. Might take a few days.

Also, I will double check my email settings. Every email client I have tried (except git send-email) seems to break formatting one
way or another. 

Cheers,

Zac


-----Original Message-----
From: Alan Modra <amodra@gmail.com> 
Sent: 07 November 2022 23:58
To: Zac Walker <zac.walker@linaro.org>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] GAS fix section alignment for aarch64-pe

On Mon, Nov 07, 2022 at 06:53:35PM +0100, Zac Walker via Binutils wrote:
> For the aarch64-pe target, section alignment for various values of 
> '.align'  causes writing of coff files to fail.
> This patch performs aligning in md_section_align as opposed to the 
> original approach in aarch64_handle_align. The change is specific to 
> the aarch64-pe target.

This can't be correct since HANDLE_ALIGN and md_section_align perform quite different functions.  I don't think you should be
changing aarch64_handle_align.  For example:

 .text
 .p2align 4
 nop
 .p2align 3
 nop

The second p2align needs to continue emitting nops.

(Also, please fix your email client to *not* format lines.  Wrapping lines and changing white space breaks patches.)

--
Alan Modra
Australia Development Lab, IBM