From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 05FB53839D82 for ; Tue, 29 Nov 2022 01:24:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 05FB53839D82 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 66255300089; Tue, 29 Nov 2022 01:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1669685051; bh=PJMMrEdiwCvmAy1Mw3xBsl7KP2KRMHO6z78+bApWW8E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Mime-Version:Content-Transfer-Encoding; b=GT0vXTpJYHsFiij4QiY9cUkRATNlXirz3YqoyJkJmfLsicUArKQloJTp7rPOVnaPR tuF+5ux74xCT3k1P14GNjfc4Qysy/XFdzkGakrw7vxNv1ZG4sbrjK107K02bX5U7Nw FAdlf3YpCAITXV/4HfUJFl60OfFWc25a2adqGe9A= From: Tsukasa OI To: Tsukasa OI Cc: binutils@sourceware.org Subject: [REVIEW ONLY 1/3] RISC-V: Add "XUN@S" operand type Date: Tue, 29 Nov 2022 01:23:57 +0000 Message-Id: <0187562c00ee6c8ba82439bd61e46a1899b9f916.1669684988.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Tsukasa OI This is a variant of operand type "XuN@S" but when disassembling, it's printed as a hexadecimal number. The author intends to use this operand type on: - Shift amount operands on 'P'-extension proposal's shift instructions (to make them consistent with regular shift instructions) - Landing pad label operand on the 'Zisslpcfi' extension proposal (because they allow three different precision of landing pad label [9, 17 and 25-bits] with up to three likely consecutive instructions with 9, 8 and 8-bit immediates respectively, printing them as binary- based will fit better to these instructions) gas/ChangeLog: * config/tc-riscv.c (validate_riscv_insn, riscv_ip): Add new operand type and its handling. opcodes/ChangeLog: * riscv-dis.c (print_insn_args): Print new operand type value as a hexadecimal number. --- gas/config/tc-riscv.c | 2 ++ opcodes/riscv-dis.c | 9 ++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c index 0682eb355241..b58b7bc0cb05 100644 --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -1399,6 +1399,7 @@ validate_riscv_insn (const struct riscv_opcode *opc, int length) case 's': /* 'XsN@S' ... N-bit signed immediate at bit S. */ goto use_imm; case 'u': /* 'XuN@S' ... N-bit unsigned immediate at bit S. */ + case 'U': /* 'XUN@S' ... same but disassembled as hex. */ goto use_imm; use_imm: n = strtol (oparg + 1, (char **)&oparg, 10); @@ -3437,6 +3438,7 @@ riscv_ip (char *str, struct riscv_cl_insn *ip, expressionS *imm_expr, sign = true; goto parse_imm; case 'u': /* 'XuN@S' ... N-bit unsigned immediate at bit S. */ + case 'U': /* 'XUN@S' ... same but disassembled as hex. */ sign = false; goto parse_imm; parse_imm: diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 0e1f3b4610aa..b3127dccb3e0 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -587,8 +587,9 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info size_t n; size_t s; bool sign; + char opch = *++oparg; - switch (*++oparg) + switch (opch) { case 'l': /* Literal. */ oparg++; @@ -603,6 +604,7 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info sign = true; goto print_imm; case 'u': /* 'XuN@S' ... N-bit unsigned immediate at bit S. */ + case 'U': /* 'XUN@S' ... same but disassembled as hex. */ sign = false; goto print_imm; print_imm: @@ -613,8 +615,9 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info oparg--; if (!sign) - print (info->stream, dis_style_immediate, "%lu", - (unsigned long)EXTRACT_U_IMM (n, s, l)); + print (info->stream, dis_style_immediate, + opch == 'U' ? "0x%lx" : "%lu", + (unsigned long) EXTRACT_U_IMM (n, s, l)); else print (info->stream, dis_style_immediate, "%li", (signed long)EXTRACT_S_IMM (n, s, l)); -- 2.38.1