From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2078.outbound.protection.outlook.com [40.107.104.78]) by sourceware.org (Postfix) with ESMTPS id BD1283858D1E for ; Tue, 4 Apr 2023 07:35:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD1283858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GV+VYOiGpk5hBtp7kzHzdl9LZg7S9lM3o4xGpiIfb8ImzEhBqkVG9C1ftw53ilQkpGj+KdZs2emIgiB6hGZ8PGAcXXqHfL2AaUfE6Lfx0dz83m+1hKPitxlDQPsnEs9c9eZxxFbwR/LoYo9CNKRGq0ANTSWm5GO9nRPw6LvQobGA6gltaKtpR1iH8168p3WvYuqR2uZXLT16EVM9GquM2jbLAm4tgz0taUv5UUH77ors0FQfgmIKeKB69P3onyzGyYqt8etxQWQ9nABPq4jLeKOo5klY3ExU8R6rRGJ3eTnwwdiS6Ck9xL3RyrKy70GjzJiSkCwos36CjjWbHZUjxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GQIepAtQb7MQn6SogWbpyUErI2Liuy8Umiq9ou4lOoQ=; b=HwUUotvhH1+4MsCURSWhDR6wNakkRH0cl5+8XE1wY8cQ7Eoo7JUHLrx6NEpZ70aZN6K84mMQ4UakxqNn/Gb7MZq4hIpdRYNesOnTP8PYRype0DukHrGfXcuiq/sECNyyViuNFsHcbvgU+zIYLC99mqOlivWGm+FwXoD2x+4CA0rX8QtO/jpfJ0mfbIjFWOlvtGXdiEptxrrRzzFyNUWKcDbG/VdMc7gTVPTVTzYwfoPNUZzfwQ4g3KlgZQ+GTWjXTANAqGvatftZmnwKaoBfZ2+y+LDoFLLubVi6fNcJoeqLIxV+rsbo+PYa+7N+w8BV5tLZXTZFsg9Q84Un/BQlYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GQIepAtQb7MQn6SogWbpyUErI2Liuy8Umiq9ou4lOoQ=; b=1NXTjKOABH/JxkLweHq+PK9+x0Ze6J/ZBSF4sC00xJ3dr3DDWu2oFC+mAp63sZ2rucVgkK64OPPq+/6bZu2mMw3brh/J9ULN1S89QHWdJhtFBvC+ciindoEnSalDXeCVWhoZrBUdGkQRlJnn0JltWU7eNtXeWjiexlS3QllztNBJkDN/di49hVhxFLOBAxDaI9KyF9zQsROeczjSP8vvSIMwc6PlrvVe0HnTKJlv7jPUnbIiXsHGg7LNBuu1VkB37cM4hFImRXfnQZ2EgTJ07sliYRIJQTvuxzJyyikTyFdQeITsCAV6GdGj8Eb50K3cfmvp/P7CaYkI12UXuTBjAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8222.eurprd04.prod.outlook.com (2603:10a6:102:1bd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 07:35:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6254.035; Tue, 4 Apr 2023 07:35:29 +0000 Message-ID: <01bd4535-be1c-22e9-1518-74522867b0ad@suse.com> Date: Tue, 4 Apr 2023 09:35:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] Support Intel AMX-COMPLEX Content-Language: en-US To: Haochen Jiang Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20230403071118.2097883-1-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: <20230403071118.2097883-1-haochen.jiang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0181.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8222:EE_ X-MS-Office365-Filtering-Correlation-Id: ffcc44fd-5af8-4d6a-d8a3-08db34df29f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4j+csxn5MU8s/c4+GlqcACObot5f9T+1JA8ofPfE9rRDa4259BQKYteMmEe+PlstZUOGOkkhUcIo9K9EobQSIhiqty3dEMVgIoRbXcdSqU094D4Wu5vT7cVLNhcr34ugp8/NqhVOn8O6YY3Np/pwsrmrekFucu8xpXWpflF47ROy3IOKnBUhEs+9sBFlZaEm1LRYj0qyXP1Q+q45LhdADT0oUM5mn+mLdwSORQoT9B72tGNs0hnjUk8eE/mijniZAOsDSb8RCGrJ14QBrDs8B4pwtLaxeHVZcKHNRPIirEVbrL3JVQGJ4uzl5C0JeV6Yz3cZEcfI5pdRYaqIm47uK3HMXtUNdnTtORzBtwYQMgulcstklLa6ntwciLvDLwVPtJ7uvSdYoDvuRPWM5MCWuKsK9isUdJHaLkFtQwvN9b9VCsRQLEqeOwhpGzX3JZ/vRi7tIOCKtzmSRfaErz3ER3sN3CHl+eCTGHqCIgctS6zVlYJEOhSZaEiju68tGmQkxnEBBr1AcYKvnreyFkCtfzN62i5epDEfJkgQ1Iuqc6DnKACLvXm7v6gqQ3N7Z2RCtDqyTWPRRveUZJa+zS2DrCB2Tw/kRW8gixUHqVVRzLLIOy0ZNVLAVE3VRB25oLSTiPbyYOC1U1Zw4PJBCABosg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(376002)(136003)(346002)(366004)(451199021)(31686004)(186003)(2906002)(6506007)(6512007)(26005)(53546011)(2616005)(6486002)(6916009)(5660300002)(8936002)(38100700002)(478600001)(36756003)(41300700001)(316002)(31696002)(86362001)(66946007)(66556008)(66476007)(8676002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1BuU1BMWERnZWRaeXRMSUNFWUt0UUd3L2ZwWDFCUUp6ckRsdERTbTF3OHJK?= =?utf-8?B?YmlhbXorSXVJc1JMQ0VKQzFVUnVBQmRIcHhJU3creDYvYnkyVlg2Yy9UMFp4?= =?utf-8?B?dWwzakxzRDBGdUxEbktzaFZJY0oxam4xOGNjcU94emU5Z1k0Mno2OVMzeGNn?= =?utf-8?B?MUJKR0hYbmgxWVEwTVdzNEovWUIxeU1zNUFBTTJOWHcvRFZDZ21yUE53QVJQ?= =?utf-8?B?SkxBYkxiMk1XRnlyYWxaVW5UNER0OCsyaTVVN1Fvekt4MDBWQlNnRmJybjlD?= =?utf-8?B?d0NWTloxYjFYM0xWeGNNV1ZvRzh2SEZhY3hId25OZ2lqRGY5c0Fpa1BsWU9D?= =?utf-8?B?U2xmakJidHp5RHhoTW95bld2WXhQVlFwendSMmxGNzRVQzN2dzZzQVBXQWpT?= =?utf-8?B?UlF1bUErWFUvTUk4UGUxNVZlRHRsaXFnSkdMUmd2bDFURE5vbVZOTkNlNG1F?= =?utf-8?B?NGxVM0JwVi9QQlNzUkM3N0FmcVp3eXNkcDlKZXIrQVcwQmVxNUpoYzdBUVNv?= =?utf-8?B?QXJmaEd2VThvTXpjZGVMTkZ0QTFZQXZDZlFsYlhNKzROSHVUQmc2bnBpSUNW?= =?utf-8?B?SFVRS21YQXZaWlFGTUJCTVM0WHEzeXFKZU1ycEQ5RWNMMFlQeDdycjg4R0Vn?= =?utf-8?B?d2RNSk9RTXhLZ2cwNlFpWG1kRVJHVlRrVjhhek9XR1QxbTFQcGFIU0pPczly?= =?utf-8?B?VE9BcjVxMEZpKzc0bS9QTVNEallFc3QzSGlFR0ZjbTdUalA3SVBkTTlROGhk?= =?utf-8?B?bmpkQmdLbEJSV2VicDhONEtXem4wOWVzS2U0N3lQdDF1Tkw0NWZnU1ptKzFh?= =?utf-8?B?N0JHZDBlVFVLaW5qTE5LMitwR3hlQ2VkaGIwV1RTUFdjS01MK2dLRG91Z0pF?= =?utf-8?B?WkZTMFhnd1ZjL0s1OXA0SlVxa0thTHRMd2ErTkN3ZVB5UjFrSk1XSTRBR0o0?= =?utf-8?B?em90RUdjSlFNeGJST1JyTHMrZlR5aTNJeHpjekRaVUpNM1hOdEZmT1E3TlhE?= =?utf-8?B?b2tjYnJMaTZHekR0Y3JrVDlGa3VNamVJSVlnKytadXcvczlJRXZTRkoycHc1?= =?utf-8?B?ZUdSQ25zang2U3FadHk2eE4rVjJDZkd3aml3SHBic0dHT2UybUszSzBERlNu?= =?utf-8?B?UVpsMWV0Si9iM25nL0NCQXl6cXVHVHVlejJsbDJWbTg3WFE2cUVIU2x2NFdG?= =?utf-8?B?S0F5TEFEWHhhUGV6YnVSWm1GWXk5RkpoaEwwcDVGL0g5WmlCMXVTTWFIcU5w?= =?utf-8?B?SFI5azJMbEgvTXlEK0ZMby8zS2laMUNqNWJTWXlPeFdjbG04Q2F0M0J2MDhM?= =?utf-8?B?ZktselpUVFF4K2tjeUVZZXc4cWVoWCs0eHJkQWFrSXFCQXN1M1BKZlByV1VV?= =?utf-8?B?ak55UHNHa3dEcjNsbGNQcU5semdBc2g1dTk5Z0NLZUZCYUpGOVE2VWo3NVhW?= =?utf-8?B?OXlCMzdTOVhPbzJhQ1Q3Q3JwdGRsZDNUUHNaMUFnYVM2elZGZVpXZU1Cei9q?= =?utf-8?B?YWVKSE4wajlhSVl3bktmWElBZ1dRQUp3bGcrbDloZ0t5Qmw4b05CcmhiUUcx?= =?utf-8?B?eWZnZ2VzYThTY1FienZWaXZDdHU1S0ZvcWl5N3B2VDhsUEhobzlRMGxISVpt?= =?utf-8?B?RThJMjBlMXZaY0Q1Q2F0Y0NqMFdPeDZkUThKSjJqcEVpeXQwUVZvV3A1dEFq?= =?utf-8?B?LzFoL0JmdlNIaFErNEYwTGRyZXdlREhDakpnQTZvT3NGUUZjUlhnK1paUWcw?= =?utf-8?B?YW41bDVadWtMd3dtNDlsVlFFajFyY0tIUFlsSWsydGsram0rNHpUQmp2WTJQ?= =?utf-8?B?aVkwYTljUlVZZHhFWVpEZnBieGxNb1UxSmNITXdlU0lGOU5MRVFheHJydVM5?= =?utf-8?B?QmdlcHN4c09WeGVtTEFVSjBzS0xWRHdRU0ZCelJxTXdtMVZ3VEpSNjV2WG9Y?= =?utf-8?B?WnF6aXQ5Mko0TG5PRlo2TFNYbWRrQWRjekRGMUNCOVlCWGdDZll5Y3NUejJI?= =?utf-8?B?WlhWRnoyUXhEMElpODJRNEJ5bFdZdHJnT1BYZExjaDZDc2NLeFJCVHZjWTFa?= =?utf-8?B?S2FFb1BIVjFFSzIzNmRZZzc2U09yL3NGeWtwc3lVc0VzSEgyMDMraG1uMlMz?= =?utf-8?Q?71nYuPyVIMS7Jj6MBnzVii0HK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffcc44fd-5af8-4d6a-d8a3-08db34df29f8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 07:35:29.0827 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dtanglNuT7+WM/jKzeM/njQ4QvX9/IhwYIuszzX/AThFeyqmdTQuzUYQdVZhX61RGSGjDMjOV/XPzEcLjN2jwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8222 X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03.04.2023 09:11, Haochen Jiang wrote: > @@ -1183,6 +1184,8 @@ if [gas_64_check] then { > run_dump_test "x86-64-avx-ne-convert-intel" > run_dump_test "x86-64-raoint" > run_dump_test "x86-64-raoint-intel" > + run_dump_test "x86-64-amx-complex" > + run_dump_test "x86-64-amx-complex-intel" > run_dump_test "x86-64-clzero" > run_dump_test "x86-64-mwaitx-bdver4" > run_list_test "x86-64-mwaitx-reg" There are constraints on operand combinations, like for tdp*, which want testing here as well (both the assembler and disassembler sides) imo. > @@ -4119,6 +4124,13 @@ static const struct dis386 prefix_table[][4] = { > { VEX_W_TABLE (VEX_W_0F385E_X86_64_P_3) }, > }, > > + /* PREFIX_VEX_0F386C_X86_64_W_0_M_1_L_0 */ > + { > + { "tcmmrlfp16ps", { TMM, EXtmm, VexTmm }, 0 }, > + { Bad_Opcode }, > + { "tcmmimfp16ps", { TMM, EXtmm, VexTmm }, 0 }, > + }, You could avoid going through vex_w_table[] by making use of %XS here. (I guess I'll make a similar change for tdp*16ps, but - to avoid causing conflicts - perhaps only once yours went in.) > --- a/opcodes/i386-opc.h > +++ b/opcodes/i386-opc.h > @@ -248,6 +248,8 @@ enum > CpuAMX_BF16, > /* AMX-FP16 instructions required */ > CpuAMX_FP16, > + /* Intel AMX-COMPLEX Instructions support required. */ > + CpuAMX_COMPLEX, > /* AMX-TILE instructions required */ > CpuAMX_TILE, > /* GFNI instructions required */ In line with adjacent comments, please omit "Intel" and "support" from the comment, and don't start "instructions" with a capital latter. Plus while the full stop is in line with general comment style, looking at adjacent comments here it probably also wants omitting. > --- a/opcodes/i386-opc.tbl > +++ b/opcodes/i386-opc.tbl > @@ -3163,6 +3163,13 @@ tilezero, 0xf249, AMX_TILE|x64, Modrm|Vex128|Space0F38|VexW0|NoSuf, { RegTMM } > > // AMX instructions end. > > +// AMX-COMPLEX instructions. > + > +tcmmimfp16ps, 0x666c, AMX_COMPLEX|x64, Modrm|Vex128|Space0F38|VexVVVV|VexW0|SwapSources|NoSuf, { RegTMM, RegTMM, RegTMM } > +tcmmrlfp16ps, 0x6c, AMX_COMPLEX|x64, Modrm|Vex128|Space0F38|VexVVVV|VexW0|SwapSources|NoSuf, { RegTMM, RegTMM, RegTMM } > + > +// AMX-COMPLEX instructions end. I think these would better not have their own comment-bounded group, but go inside the "AMX instructions" sections (which already covers all AMX-*). Jan