From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23776 invoked by alias); 2 May 2006 13:34:18 -0000 Received: (qmail 23765 invoked by uid 22791); 2 May 2006 13:34:17 -0000 X-Spam-Check-By: sourceware.org Received: from mail.artimi.com (HELO mail.artimi.com) (217.40.213.68) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 May 2006 13:34:14 +0000 Received: from mail.artimi.com ([192.168.1.3]) by mail.artimi.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 2 May 2006 14:34:10 +0100 Received: from rainbow ([192.168.1.165]) by mail.artimi.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 2 May 2006 14:34:11 +0100 From: "Dave Korn" To: "'Alan Modra'" Cc: Subject: RE: [PATCH] Make obj_sec_set_private_data into a format_ops member Date: Tue, 02 May 2006 13:34:00 -0000 Message-ID: <020601c66ded$1879ccb0$a501a8c0@CAM.ARTIMI.COM> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <20060502113735.GN11597@bubble.grove.modra.org> Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00043.txt.bz2 On 02 May 2006 12:38, Alan Modra wrote: > On Tue, May 02, 2006 at 11:55:44AM +0100, Dave Korn wrote: >> On 02 May 2006 11:37, Alan Modra wrote: >>> Especially if I run into your NULL deref. >> >> I suspect you may well do so on coff targets; > > Indeed, I did. Fixing by creating new section syms. Thanks for the > detailed explanation. Rightyo, since you're really that close to checking this in I may as well wait for it. Patch withdrawn. >> and that leads on to larger >> issues of regularising the way in which synthetic symbols (i.e. not backed >> by a real target-dependent symbol structure with all the relevant internal >> data) can be created, doesn't it? > > Yes. These special sections have always been a pain, more so in the > past when they were const. > >> BTW, this issue aside, how about making the other macros I mentioned into >> format ops? > > I think those make sense. Would one big patch that adds them all at once be ok, or would you rather separate patches for each one? From the point of view of doing thorough testing (meaning 16 or 20 or even more full builds and testruns taking many hours and many gigs of diskspace) it would be an awful lot less effort if I could test them all in one go together! BTW I'm currently testing cygwin native, and i386-elf-linux-gnu, arm-elf and ppc-eabi as crosstargets. I think maybe I should add an aout target and perhaps an ecoff target too; do you have any suggestions for which would be good choices (in terms of what targets are currently actively maintained and have lots of users)? cheers, DaveK -- Can't think of a witty .sigline today....