From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id BEE383858D1E for ; Mon, 6 Feb 2023 20:28:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEE383858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 316KEDk3024758 for ; Mon, 6 Feb 2023 20:28:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=WnNX9XSagBJPKVN7+oQKKr+rLuX6BO4x1thq8NKGkFs=; b=fEi+BF21PIPvVvpCPzg1fhke/E+d5CALcteNnVGxEI45XfmuRdkX3DKkQkX9ZyXFr1Tv hJyGKYYXFp8qaRrytfd2SXX41nuGXshbK7vdhudPYnY+DsUJIHxhp3ueEFm/1/KL/MlH o237MeRXSkFbOYCXEnQ8bcUNLUrBXQPSpAabUMdiphqEoYb8Z03VNkROCqMT+eQAvWym T3ro1t+majJi9VLvGIEvWB+gtJwl2AlNuRqpFBkpZLYRe3QEQZF2bThCJ1OYREs4qqrp IUIHGm4hvNvH3QVJjX1ax79N6yl1e5nkcO4YgbIJL/+HB9lz+w2RSTmfWGq46/YO4+kK LQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3nhf8a3uha-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 06 Feb 2023 20:28:03 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 316JsZ9V011568 for ; Mon, 6 Feb 2023 20:28:03 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3nhdt53b12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 06 Feb 2023 20:28:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VyM/ymRQBUnFa9sfgijAGFAh1DKEy+xmPCYeigZGYZpLCUNfNn4DdSiBw3arS4US1EQbQTaK4BEagHEZt+FHh0ZteN+Rezlph6rUAhF1x4Ipg8mb4Y6Y7efWRqL0j2WFZuiukEP53W5bSoFzwoiTCSO9W9oJsKifQtKGQLXfstixJ+JSfyMeEwA3I4/02QFO/oEd+Z0VFua5BbIZnH7oeeb0q2GQHn1MELscrtf/59k9YYzqR1Jf5Yktg0fNOG52s9qjfvIosK0kSQZMqaqneqoH1RFTZmEWNAPE3ToBCKQa5I7W8bCF4zXWxsMedXUZSYCBV3ntDAUAURzV5GrPMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WnNX9XSagBJPKVN7+oQKKr+rLuX6BO4x1thq8NKGkFs=; b=ZUL8YN+lm9IUKYaR4YxmWBoeK3Ji/RrGI/azpPWU3yxWQaWmBsIEhraNtTfKiQuvSvKRAPX/DAkMbAxc+jhhzaBnQbWqHVrNNw4AL2br/JVmsmPc9z6qgv5ibZt+LXrwgtdkI7Y1M95T+MrXAQgpHHVvLBxyIaaOJajUQk6yl0feVET7OlqoSCZfYFVY70H2HBqyWhBdLgVfrN+LDGPf++gLZfZCKouEU21JXJFs9ZSDbwByjdjxkmmn8MZLwWK7zS4U/zuGR86dGzgggOqcncFBB8eX17SYpr2Eu7shai6JjoT3yVqdJwysnaGKdcoo7rilg8YP8BhEH7pRDsX8+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WnNX9XSagBJPKVN7+oQKKr+rLuX6BO4x1thq8NKGkFs=; b=P3YU8dvDeYCly1ltBzyPssZ+RuyUIKljSe0zATsH9m7cLEUkJ84WpFI+x5jf2jHzmUAkuM7mId17473UcuLPStcNxd3MTxNJFce9sEZchgUDOpKfZAGBvyor6o9DiHc3XWHwFyT+rda5zfMimDW0sDjT4Kenybr9VBTDGUKir8g= Received: from IA0PR10MB7327.namprd10.prod.outlook.com (2603:10b6:208:40e::22) by SJ0PR10MB5581.namprd10.prod.outlook.com (2603:10b6:a03:3d7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.7; Mon, 6 Feb 2023 20:28:00 +0000 Received: from IA0PR10MB7327.namprd10.prod.outlook.com ([fe80::b72:72fc:4430:f1ab]) by IA0PR10MB7327.namprd10.prod.outlook.com ([fe80::b72:72fc:4430:f1ab%9]) with mapi id 15.20.6086.007; Mon, 6 Feb 2023 20:28:00 +0000 From: Ruud van der Pas To: Gilles DUBOSCQ CC: "binutils@sourceware.org" Subject: Re: gprofng SIGSEGV when processing unusual dwarf Thread-Topic: gprofng SIGSEGV when processing unusual dwarf Thread-Index: AQHZOkSXWr7q2XUkXkuETOGvKxR5Eq7CXniA Date: Mon, 6 Feb 2023 20:28:00 +0000 Message-ID: <02347EFE-BA80-42E8-8AE3-214501F5AF95@oracle.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.2) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA0PR10MB7327:EE_|SJ0PR10MB5581:EE_ x-ms-office365-filtering-correlation-id: 9d9cd3cd-24de-43db-c20c-08db0880a3ec x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jiZHzgWbP4DidkTrzT7tdu9coaNM+4h5Rc1UBImwZ+DWbOvNNym56liS4u50ij/4/wv2DGDMVUC0TfuFT3Lr4fgUZMEPWAWbATAGJp3uOrWoxu3OGOi8GcqizGzMUN+1o5YCBP733+R6kkmQ7lHToneqKtyicrrAw+pCDOZgr6c4sVz55uGyUxVy/4xcbhT8REBf2scjlEp/q7r+CFnmdLSrxw8mhE733yM4c+y5Xf7OwYQw6AVI3lcwNOciNvH33FvQtXx8vcd2htsg2GDGMNZD8yKuiYfVinJzaxVWPRIsDb+ldXCYEpC2yR35o2mAuuak35y7sgnEOv91zxRwn+ZyMQ9VEFcuvkFvhC5Kzcf/tnIylE+maWOsXKm+cJ/Z4vOohVpSpk3NrX8PKvvdLK5Nk9FLk2VssM4NKS3hdh+MSuVSFJgm+1luVAO9erph9ldgW7SmVE4r7zpEWpUF7adDrP6A+8z+snFPEE40FbPMEnyRuXUKAUjb6n6QJqeXjY9jaJvq2s/EoSqi6wRo83xFgkzAxcfEGhsMiugke4xocu5kTXrpwc+zaVGae36vfXWoc2NTKGenfXPueHXEzvQiOrLQbgCD+zm4W24dNe+dXq7dd9U6IhY5rhjBw3IPqZIJdG4Doa5+45ad5ymdyQmJhwcafziGmopDdQy1eso7YBlDcE8KdU5O5zB33k6olrA8CPapFH4fe4eXcCrnkpTnRr646K1kbrQ9wJmasxA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR10MB7327.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(366004)(396003)(39860400002)(136003)(451199018)(2906002)(478600001)(71200400001)(6512007)(36756003)(83380400001)(6486002)(6636002)(122000001)(76116006)(4326008)(6862004)(38070700005)(38100700002)(64756008)(55236004)(8936002)(66946007)(26005)(33656002)(8676002)(66556008)(91956017)(5660300002)(37006003)(6506007)(316002)(66476007)(66446008)(2616005)(41300700001)(86362001)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Cwm5dojK1zB/jtuFLs3cpqt15Xc+QW/ABXvFeoLOU4UNULD0wC11AER4aDfX?= =?us-ascii?Q?q8qdOy8RHwOHDr4GPLzrFkMOeaB2DXU8ocTW7FZwfAGOpDLDdliQ1HQsnp78?= =?us-ascii?Q?iPB8HkN29R1uYn4vkdsaviuN/xwv5YiZPoosGwRkodkP/oy/xJmpbBgJyCIo?= =?us-ascii?Q?nWvC7sYgirNoxWh6q2y5s19wcjMGaZiYaWSUsAAmdhDeYXOJgwndUi0PNEa9?= =?us-ascii?Q?oKF1Uymiz6l2IQKpmGyMxD+JgaZ8ZCVtPQmZJv37JKar2y5RmmM756GdCGvG?= =?us-ascii?Q?Xqseoh7mwuyPJ3JC0cKRDX6QsfVjGbwbmeiznaSWGuE5cR3KSIpfJ/p4Pq17?= =?us-ascii?Q?BmJBkYSH+CgX/P4c7+yfyQEmhvfQdOi+5ERorbKGEwzBHRFjgxVnsprGsmfn?= =?us-ascii?Q?e6E0Aca4wySo8qReab6tJjN2NUCYIN+1M1qUJg07JHKtJLTm+I9Iuc0y2fid?= =?us-ascii?Q?snlgtZ1F3Qqec169Gwhompb+7Ej5EWlEunwqsQPKUD/tBE2GXinvk21CMZ5+?= =?us-ascii?Q?DeRxX0HRkExwHLUVVE4eIYUvZ+jCR6J0XrwFRR690TIPkuEEEjTYL8LZbt5c?= =?us-ascii?Q?xpVZhPr+XFI/rpgvAPfn+4qQzVK1F+e+dsVTPZsw18HgJOUQPFTxA6onFO6J?= =?us-ascii?Q?1jhvvhYOuk7RNedj08XW/JgGOrWvvVv2B3jMa7xiWPn7FM++0hbYF+6bIzCB?= =?us-ascii?Q?khoRa/WJct7HUtuc+zDyowASTBHCjZd59PKeupEMwmV11UB+iPfHFXTLHERl?= =?us-ascii?Q?TaqeGLfAh7D3VN/F+0C/x6mHa/4UaJjr3pBdaNqBpqDq+emUEQHmEwuQymvh?= =?us-ascii?Q?BzIFXVYK/T0olR39A/xqiSObuBhwdcg93Y7HxRbo19BHM5H0JpidP1f5qPqD?= =?us-ascii?Q?ssVmbVjaNQd2a2Kq8JMw0hpNdg7ogsTGk+j24umLHvIIMtqJTCDQUpgbC02g?= =?us-ascii?Q?tlmDEhoBS/11p2uuWknhOuih+RdCKPdYl5J66/QcvgEDZC+OqjXZoU9eFr0g?= =?us-ascii?Q?mJ30mNsmWYAJPHM6f3yXQQhNlHa9D8akFM1d3QHTa3YaCPnXhWFuyWLJh2UB?= =?us-ascii?Q?3Ov/Z9FErWK5IGOR2fxfqvcBpm9YZhUXwL8FWDqGHEmfKlBFzjHx241hL9Fw?= =?us-ascii?Q?RTvopgRY0pzUj6FHqtXRTMBcaddGwqfAI93UXd6Nv6f6YUD/reos1tjbXrJU?= =?us-ascii?Q?w833vjhcyfa3rRwrbea9PJIfvY7CcupGF02Oiq5UPOqiimSzJHTSksibYxr8?= =?us-ascii?Q?wW5b/9Ag/8hTvvbPNiQ06/Vxccn1oqTyqkfr5vWs73UDsfo3jYH2TYdk5o2J?= =?us-ascii?Q?N2eGadYrtrphwMl7pm1UuqxCWGuIigB/+gK+B1x7qtjTCpOkH7Wjqs20pDF3?= =?us-ascii?Q?pvg+Q03eSjH3+p2PahoXvpqInw7gYKORbfulre8GrtpS0uaWYwlqDglxZGW7?= =?us-ascii?Q?Mid52djdoqR+iNZ3Sv6Z6irlDHUikiO7ZsbPHpyn00YIwKIW2dD04uPmDto4?= =?us-ascii?Q?67a6QtxTBHnghyDDPjjxFryU1+6izLguVpdwMQ6yf+6HNiVvhOrIzb3P57gr?= =?us-ascii?Q?VoYILItTIb8BQeMQJND7aPoDF7uMmLMalcxIqxGhayq0b10da4w/SpC4E8dH?= =?us-ascii?Q?2w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <4515DEDBD798824FA0C71E5689AC5889@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: raHsHeRLEU4CEKaqUTQjUj1DHxPc22VomvdKrOXzs6e/U0FBoOsDWY6k1xPh0rIWP/2FWTDMdQQGpb1nMsOhsE0tC+Ml7cakSXvaQNrUtAAhGvBpeUggA/MPrComearFIv+pGic9yLCf4mTa5StGU3OaXLnoBKyNb2tz5DTcg+g1Aj+GyB7nldDap9MYdALks7N1PaiC56EEylYAU09gJ2gjWNCJ29YbD8dpmwPGQiOEE7ARedEknDKxMfWbnS5eWxh/yBBtBUAHQdUyO07DPNNj0ygEIQCPALUZN2aTXSpxowg3+iN1vqSu0zhME4z5T7KB8tN82/BlUq6RS4nQw0yKFqYexpf43FXsUCgsfJjfZoQHAshpTKKNDWA0ROhL39Pjq19YdT5C1Hf0Ke44a8Y/NGHKRwjJH1Dbon3JijvZkpw0PwlWrZwnL+rOodT3MmO9cRzMTxVie1dHn2fY0sJdY8Z/b0Xd+EWRUzHxvarcwH21HHdd6nnXDCq3tyEBfWm9PFoHZcnyohy0xXR2sGlvF1rvAR0gNeLOB+0V4UdRpifBpzPzUDoYcVlrZlO+InBEjEWbfFWFaOiTedoB+SlBTCbnO02twFkEj1LIU18VN44WneqVPSnkCf+z2W6R67ecI84n1R1NfHCvgdVzBhSB37RG763bBiTJ2O1cFdh2u7JkGygdwrL9W4HTPS3mtgn9dLMeYfYTh/DaV/R8MfYQEiRDnmAs2Mw89tXhgS7OL0iKCTOIIO4PWccHYTzv X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA0PR10MB7327.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d9cd3cd-24de-43db-c20c-08db0880a3ec X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2023 20:28:00.1470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1X1Ga0cwJKv7l2kvpKHKjH+gQyI0LUCfsod73gBIH9Wi7a+mlK5G3onOvVKhKyMPmbV3ayJEpLAIKpPeIuMO5wUU8KR+cZnMPjPfh6NJOcg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5581 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-06_07,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302060176 X-Proofpoint-ORIG-GUID: EwNdgjNjWP3YG7fTSSgZdGnyNvO1-xHA X-Proofpoint-GUID: EwNdgjNjWP3YG7fTSSgZdGnyNvO1-xHA X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Gilles, Thank you very much for your posting. > When running gprofng display text on some executables that contain unusua= l dwarf data I am getting a segfault. > In particular, the input dwarf has some compilation units (DW_TAG_compile= _unit) that have neither DW_AT_comp_dir nor DW_AT_stmt_list. I'm sorry to hear this. > The issue is that when that happens, DwrCU::stmt_list_offset remains 0, a= s a result, in Dwarf::archive_Dwarf, the `get_dwrLineReg` call will process= whatever is at offset 0 in .debug_line. > Then while looking for source files, `DwrLineRegs::getPath` will potentia= lly try to use include_directories->fetch (0) which is NULL (no comp_dir at= tribute). > This leads to a segfault in StringBuilder::append. Thanks for the analysis of the root cause of the segfault! > A quick local test show that the issue goes away with the change below. > The change in DwrLineRegs::getPath is not strictly necessary but makes th= e code more robust if some compilation unit has stmt_list but not comp_dir. That sounds really good. Thank you for working on a fix! > Does it make sense? How could we get a fix for this integrated? We can take your changes, do some more testing, and then submit a patch. > If that helps, I can create a bugzilla issue. Thanks. Although even more work for you, tracking these things in bugzilla helps. Others can then more easily check whether they're running into the same pro= blem and we can connect an upcoming patch with the bugzilla id. But if this is too much work for you, we can also do this. Kind regards, Ruud