From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2047.outbound.protection.outlook.com [40.107.21.47]) by sourceware.org (Postfix) with ESMTPS id EA5693858CDA for ; Fri, 19 Aug 2022 06:13:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA5693858CDA ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FL8t6MgI+cHBv0szQIweR6QonV8sGg4hq+i9drq2MxLOMaDipAnQgf/WZD9MoGv+LIa5vYWzjtfzkbj4zVJKmyaq07ezqLNYOjByr1pUD50v1gIj8Z1LMtWJJYbAKZx0nc1xk4e8Q8Asg6rbQ3jhSY/P6hhFXSUwqglUso//KB2YFzTC20AKdkc8qbiuNRRnDdUAo5HuefXs1MMiBL7mSkE+5R8ekJT87BFusedG1BdegwF1l1T8eQktnqitECWrdfeO+iNgGMjp7GLPPCDopAuPovTey6FLE8Gq4nyKxWDxpvLKK0aJUT9qS9uxXhQ9KY7GMSk+y9r92oed29WxSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+OezbHJvyOcH1/KB0nuH8dHsbjvbb1QgwMsMEFnPmCQ=; b=Ot2BAORHqjs+Dt52AxL9NJNsrRRJEAtaG5PtvFPBHfZXPeJpOiNCuqEp8JfCCsluK99RoOqHHSxm6ivrvVDr52jWnzKpmHfwtharFC8KcMFMMromtd0I2IsBGcHlI+r8WkP2eib6SOC9UC1HpwW83he8u8WLh4PvSnMljjkTkCF4iQLXYeRPRJXJxEpXYNQcEomS1za7uEte4DR2e5LCaHr0U+cCS466tfLcoknsBcsyB33dzBzEn9VLDkzvT+dHxs9tSD9L/2tM8aECiuvPyM4z597BHpU7uIdY+WqoqzalSM6gOHwNL/ihinCC/kyNvGCKJ5Sgd7/8pBRnvgzj8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7957.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.18; Fri, 19 Aug 2022 06:13:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2d5d:bae0:430f:70ad%4]) with mapi id 15.20.5525.010; Fri, 19 Aug 2022 06:13:29 +0000 Message-ID: <0340bbbf-7177-5404-b078-f1c6be287a39@suse.com> Date: Fri, 19 Aug 2022 08:13:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 3/7] x86: move / quiesce pre-386 non-16-bit warning Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <32216291-fd1f-4579-87de-d24cb7190894@suse.com> <8e4dc724-3516-6ec7-5a6b-70ed70e3e237@suse.com> <6db15eed-88f1-cfaa-9650-bc15b18f665d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0467.eurprd06.prod.outlook.com (2603:10a6:20b:49a::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a0a04960-a7b6-409d-4565-08da81a9ef9b X-MS-TrafficTypeDiagnostic: AS8PR04MB7957:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vkegLWlMYx7pKKbMryw0+C8wzc/rdBBGiBOcIek8WfhYolS3C2gY9jVzWolUVQZGhzptr9kSoW4bhkmTgWUFxAfby5jnCFaPXaQlAOx7S4ST57inF2l+nv0QqcNm4vlEda6AgEH/CYnT8fTFkbIaVxoC9BiDRGi3vV1yMmcWtuj6S50TbyJzeJzAfJhWxUCQraaOe0OpfmaGo6SgsiNDvtg8CIhOHo/pO/Yd46jZAYRl0qCD6n6IM9ZIOdyjBJkHYuIDk0PRhJt5IzgRmZuLYlG1nsbWVVrEmmyEOZuuDWMJFGXa8EyNuVe3qWBTHXw3qF+lYMuNsbJzS25KpDHsjJu3s6P9DRDI84K8VkWbO5gZWo7HrDBwfcBysrp+n/IbRFZOv4I6jW7xdCjpTJaCn6+f90FyYot6nM6Qu5qjObqjTNY0Hbo/2vrKeE3ZlnS6huRRu3auultyFAdivuJcZjC1lre6wXLUZ/m5fOspmCEmd7NRwAP3twtH0HDFnB4OYLHQ+Q9QG3bhpg7zOWLTUj+yf7Kj73r1rUtYCr35cvbTWq0D97d+fD3PYPbnI77XcZQU67OGmDqWJfZ62G9Gd3jFfvT0o0z2EGHIfZzHZ3Gv145ics1BP7RK+W3lOSAnWyyqr2ZcTfnF6qOF7UMRoRPIE3dGk0Cn1nGL8bsM2PNCwZvzA57kTmA1qz7sw+xIbacrj68HApwLFMmgdscAodw9xW1l3gvb3PLD7Fq1/3tZnaYcJF7z4Mr+AAo+LqnEDkNCyo/geykmWNWvRZGZpreyi9g8NEw5kUNy1uwR5nQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(39860400002)(346002)(366004)(136003)(376002)(478600001)(41300700001)(53546011)(6506007)(86362001)(31696002)(36756003)(26005)(6512007)(83380400001)(31686004)(2616005)(6486002)(186003)(66946007)(66556008)(8676002)(4326008)(6916009)(316002)(66476007)(5660300002)(8936002)(38100700002)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUVyaUR2RmNUQjU5emdxTGhjYnQ4QmlaV3BYSjhZUW5KSXhaRXloZHZTTytJ?= =?utf-8?B?UTJtb0xSaklwWDc5MGgyS3Qzcmcrd3l1TkJ4T0VPWEtoeFk2bEdvejl5Ymh5?= =?utf-8?B?VWZtVnlrcVJZQ0IwazBCaXdjd2lvSlRmckdOVXBVT2RaS3dFbmFxNm5UclNP?= =?utf-8?B?QzR4UVkxZWxoRmJST0hxMXBxQU4wQzAvRGxlVldSejBkUXdTN0NYaWNMT3g2?= =?utf-8?B?NHVGSTVQd3l3eTF4R0RnY3c1Ylp2UjUrcUZ3QzlGb09VTW44ZzlwdFRXTEJD?= =?utf-8?B?RDNJUk5DR0Z3MFYrQU9YMFpCQklxeWpRZ2hwR1kvU1hsc3dDTDJ1UW5oK3JV?= =?utf-8?B?U0gxZzZmckhTejdJNnd1SDVnZkhiWVQyRUpZTnhXUms4L2ZqTWdsTE9pVndY?= =?utf-8?B?a1pWaWRKczJXWGMzaWZIR1oxSkIycnJZZGFrbVNwRmpEMHBXOGtlM01CKzZa?= =?utf-8?B?VjZnWjBMS3BYdFI5U01BREJkS3NkVlBTWDQ4VGJDNUEwM2RTVGFlR3ZlN2Ji?= =?utf-8?B?S2VWb3NMWWJ3dkxQd25zYkNFdkp3SGlXaCtRandlVDZBVURTT2szVVZzVmRY?= =?utf-8?B?cDNwa0dSQ29aVGFtYWZ0MkViRCtYeDBUVFU3dVNGUngvUE9uNEJoY083UEl2?= =?utf-8?B?QlNrZGtkZ1NOUmd0VFpvaDNvV250Ymg5WEVYSEZ0NUNCUnhKNXhDOUozOHE5?= =?utf-8?B?U0lrY0RjLytETDU1ZHhsdmV1Zm04M05XVzBzaXVlZVJNNHI2cEQ1UjF1Qm96?= =?utf-8?B?Zi9pRWg0T1hXYkdDek9vM0U2ZTJZM014UXFVQ01XWGVkeWhRbWhVaHRkV045?= =?utf-8?B?R0luY04yREdNbCtJYkxaeDdQREFlV1Vva3ZOL2xmbU9mMG9iVWd0NmhNdWk5?= =?utf-8?B?SUt3T05rdXFpcGV5UWREK2p1VlRJSXk4amFPbEtoSnkzaGZDT1dEYi9RSFd6?= =?utf-8?B?alNLNzFQdFIvaCtqY01qWGNBNUFQeWlVQmR3QWNvbE1iOGpwQUh0WEd4c3cr?= =?utf-8?B?V29wakpVVi9BNnpSdmRqWlJVSXdjTXNKNUFzT21TMDdwaXZBMVlXRnRjNGpN?= =?utf-8?B?aFhFS01TajFFS05hY2dOOENZQVo1bUxXVEpVOTl2U0JwYnExdXNOQmVvV3VG?= =?utf-8?B?WUdCbmdSeUFYYUo0YVhuWGR4eEZYWHViWjdOdHd6UlR0d0tZZlJzZDdLZmpJ?= =?utf-8?B?dllBV3dEcVBMUXpMZEZQZ3N4SHc3WHBzVGFUVlVjb1J6ZjcxdGdZNGw4UEN5?= =?utf-8?B?YTVKL25mRmF5WGgxL2RSa1NhQU1TN3FFVmdIMG93dmFSM0RyVXNPQVpMc0hi?= =?utf-8?B?N2ptbTdzc01teHVxV3ZLK3FhZWw1Y3dZVzVQUU9ONHB6TENTNG5wWmpubVp2?= =?utf-8?B?Z2JOSmprZE1vK2JIWnJRc2hIVWlXQlZSY09semRvUE5vL1dVcWpvTnF6NTFZ?= =?utf-8?B?TVR1VnYwQ2hFbWk2dmlxYlFSMUFsOHd2TEpyLytEOFVBZTN4K283M1BBeEFz?= =?utf-8?B?cCtzaWsxUTJxTlowcW9WeklUSkpRL01QZXJhWXF2WlZ3ajJOdVBiRmpnRUdF?= =?utf-8?B?MHNSaWtvUU5YNUthS0J3R1pFNGdkcTE5T1ExUWtGYzRZV2JiMnVKWUJRcU92?= =?utf-8?B?d2VvOER6aHQralkyay96alQ4TkgxSU5NL2ZHZmVsaWZVeVN4aExKZTZCeDZr?= =?utf-8?B?c3JMOVY4SlJhU0ZpRUdMVDVBaHJpZ1VyZHVZU2xBRlBIV0hYZVE4b0UyVFdX?= =?utf-8?B?RVdnWVk4azcyUE92TmsyR1hBN2srdTJHSWh0Vlhyd0FDcElMY1hDTnpzMTNh?= =?utf-8?B?b284aWtWWlUvamZYdmlnQ1hJeUdVdi9FNzFWbEVaeThJQ1h1WFplbDJGYnJj?= =?utf-8?B?ZmVxdkhVcmNiZHFYMUxmT1gxZUxnMGUrVHh6SGhUSVFZZDErRGw0d3ZJRkx6?= =?utf-8?B?ZWhlUTd3Z3pSWmd4MnAzd0FtTEhFRnowZzV6RUYxKzlYUXBlQkIvSHF6Ymhp?= =?utf-8?B?eExNdXVLb05MSkxWdnNtY3lQSk5ISVkrVXVtV3Nqd3JrY09kQW8wd2svb2Fp?= =?utf-8?B?ZDhFeE8zL0w0b0Z6TWN5OU1pT2E2WVZzZVlwdEVVdEJhdGFGTzIzOFJDQ0Nn?= =?utf-8?Q?tuAvgmVbAJ/XLuwGbxIjyX6Cl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0a04960-a7b6-409d-4565-08da81a9ef9b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 06:13:29.6983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YRMfBX8YCeGx7PHCOj+CuuIECN/0UGPyy40V2OzneFLIT0FbNydJ7QJ22GB07ckKGM5feJGuaa1X6Zqdpz0eTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7957 X-Spam-Status: No, score=-3030.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 06:13:34 -0000 On 18.08.2022 17:30, H.J. Lu wrote: > On Thu, Aug 18, 2022 at 12:21 AM Jan Beulich wrote: >> >> On 17.08.2022 21:21, H.J. Lu wrote: >>> On Tue, Aug 16, 2022 at 12:31 AM Jan Beulich wrote: >>>> >>>> Emitting this warning for every insn, including ones having actual >>>> errors, is annoying. Introduce a boolean variable to emit the warning >>>> just once on the first insn after .arch may have changed the things, and >>>> move the warning to output_insn(). (I didn't want to go as far as >>>> checking whether the .arch actually turned off the i386 bit, but doing >>>> so would be an option.) >>>> --- >>>> Otoh I wonder whether switching to a pre-386 architecture shouldn't >>>> automatically move to CODE_16BIT: Us emitting operand- or address-size >>>> prefixes violates the architecture specification. Alternatively we >>>> could outright reject such .arch directives when not already in 16-bit >>>> mode. >> >> Mind me asking - no opinion here? > > We shouldn't change the current behavior to avoid any surprises. And continue to emit non-working code. Recall that the warning message talks of only "addressing mode", which even I initially took to mean what it say, and hence being entirely bogus to emit for insns without memory operand (or anything else susceptible to address size setting). I did actually try to find better wording for the warning, but couldn't come up with anything halfway sensible and not overly long. Jan