public inbox for
 help / color / mirror / Atom feed
From: Tsukasa OI <>
To: Tsukasa OI <>,
	Nelson Chu <>,
	Kito Cheng <>,
	Palmer Dabbelt <>
Subject: [PATCH v2 2/2] RISC-V: Remove "b" operand type from disassembler
Date: Thu, 22 Sep 2022 06:30:38 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

There are a few operand types not used by any RISC-V instructions.

-   Cx
-   Vf
-   Ve
-   [
-   ]
-   b

But most of them has a reasoning to keep them:

-   Cx     : Same as "Ct" except it has a constraint to have rd == rs2
	     (similar to "Cw").  Although it hasn't used, its role is clear
	     enough to implement a new instruction with this operand type.
-   Vf, Ve : Used by vector AMO instructions (not ratified and real
	     instructions are not upstreamed yet).
-   [, ]   : Unused tokenization symbols.  Reserving them is not harmful
	     and a vendor may use this symbol for special purposes.

... except "b".  I could not have found any reference to this operand type
except it works like the "s" operand type.  Historically, it seems... it's
just unused from the beginning.  Its role is not clear either.

On such cases, we should vacate this room for the new operand type with
much clearer roles.


	* riscv-dis.c (print_insn_args): Remove 'b' operand type.
 opcodes/riscv-dis.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
index 7ae6e709290..99cebf37d9e 100644
--- a/opcodes/riscv-dis.c
+++ b/opcodes/riscv-dis.c
@@ -403,7 +403,6 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info
 	    print (info->stream, dis_style_immediate, "0");
-	case 'b':
 	case 's':
 	  if ((l & MASK_JALR) == MATCH_JALR)
 	    maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), 0);

  parent reply	other threads:[~2022-09-22  6:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  6:30 [PATCH v2 0/2] RISC-V: Opcode Tidying - Operands (batch 1) Tsukasa OI
2022-09-22  6:30 ` [PATCH v2 1/2] RISC-V: Add macro-only operands to validate_riscv_insn Tsukasa OI
2022-09-22  6:30 ` Tsukasa OI [this message]
2022-09-22  7:04 ` [PATCH v2 0/2] RISC-V: Opcode Tidying - Operands (batch 1) Nelson Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).