From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67099 invoked by alias); 2 May 2019 16:16:19 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 67068 invoked by uid 89); 2 May 2019 16:16:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=replies X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 May 2019 16:16:15 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7452881E06; Thu, 2 May 2019 16:16:14 +0000 (UTC) Received: from [10.36.116.145] (ovpn-116-145.ams2.redhat.com [10.36.116.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DFCDCA221; Thu, 2 May 2019 16:16:13 +0000 (UTC) Subject: Re: [PATCH 06/19] libctf: hashing To: Nick Alcock , binutils@sourceware.org References: <20190430225706.159422-1-nick.alcock@oracle.com> <20190430225706.159422-7-nick.alcock@oracle.com> From: Nick Clifton Openpgp: preference=signencrypt Message-ID: <0460e204-6113-3dfc-b3b7-dfae809b6f4b@redhat.com> Date: Thu, 02 May 2019 16:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190430225706.159422-7-nick.alcock@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00106.txt.bz2 Hi Nick, > In the binutils implementation, these are both fairly thin wrappers > around libiberty hashtab. I could not think of anything useful to say about this patch, so this is just a comment to let you know that I have looked over it. I think that this may well be the case with other patches in this series, so from now on I will only post replies to patches where I actually have something to say. I will send an "end of comments" email as well though, so that you know that I have finished. Cheers Nick