From: "Dave Korn" <dave.korn@artimi.com>
To: "'Christopher Faylor'" <me@cgf.cx>,
"'Pedro Alves'" <pedro_alves@portugalmail.pt>,
<binutils@sourceware.org>
Subject: RE: environ is autofiltered from dll export list?
Date: Thu, 25 May 2006 03:18:00 -0000 [thread overview]
Message-ID: <052601c67f54$bb352300$a501a8c0@CAM.ARTIMI.COM> (raw)
In-Reply-To: <20060524162012.GA25356@trixie.casa.cgf.cx>
On 24 May 2006 17:20, Christopher Faylor wrote:
> On Wed, May 24, 2006 at 01:55:53PM +0100, Pedro Alves wrote:
>> Dave Korn wrote:
>>> On 23 May 2006 22:02, Pedro Alves wrote:
>> Ok, I can provide a patch for that, but I would like to understand the
>> environ part of my question first.
Can't say I understand what it's need for myself, but ...
>>> char** environ is explicitly disabled from dll exporting in
>> pe-dll.c's autofilters. Why is it? I tried to look in the archives,
>>> back when the auto-importing was introduced, but couldn't find the
>>> rationale. Should every dll have its own environ?
>>
>> I think this was needed when there was no auto-importing, and cygwin
>> defined environ as __cygwin_environ:
>> http://www.zsh.org/mla/workers/2000/msg03158.html
>>
>> Is it still needed? In that case I will have to conditionally compile
>> out that part for arm-wince-pe target.
>
> Are you asking if cygwin still exports environ as __cygwin_environ? If
> so, then the answer is "yes".
>
> cgf
... since it's still needed, you will indeed have to disable it for
arm-wince-pe. However, you shouldn't conditionally compile it out, because
that's the kind of non-multi-arch borkenness that we want to avoid; using
"#ifdef" in binutils makes --enable-targets=all fall down in very mysterious
and hard-to-isolate ways!
Take a look at pe_dll_id_target; you could add a flag in the pe_details_type
entries that control which arches use which autofilter names. Or you could do
it the other way round, and add flags to autofilter_entry_type to tell it
which arches should use or ignore that particular entry.
cheers,
DaveK
--
Can't think of a witty .sigline today....
next prev parent reply other threads:[~2006-05-24 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 7:38 Pedro Alves
2006-05-24 13:38 ` Dave Korn
2006-05-24 14:33 ` Pedro Alves
2006-05-25 1:18 ` Christopher Faylor
2006-05-25 3:18 ` Dave Korn [this message]
2006-05-25 22:49 ` Pedro Alves
2006-06-23 12:16 ` Nick Clifton
2006-06-23 14:01 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='052601c67f54$bb352300$a501a8c0@CAM.ARTIMI.COM' \
--to=dave.korn@artimi.com \
--cc=binutils@sourceware.org \
--cc=me@cgf.cx \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).