From: Jan Beulich <jbeulich@suse.com>
To: binutils@emagii.com
Cc: nickc@redhat.com, Ulf Samuelsson <ulf@emagii.com>,
binutils@sourceware.org
Subject: Re: [PATCH v1 7/7] ChangeLog: Add ASCII command
Date: Mon, 1 Jul 2024 08:38:28 +0200 [thread overview]
Message-ID: <05771b75-d964-4df3-81b7-e890a1d91b12@suse.com> (raw)
In-Reply-To: <20240628214627.6726-8-binutils@emagii.com>
On 28.06.2024 23:46, binutils@emagii.com wrote:
> --- a/ld/ChangeLog
> +++ b/ld/ChangeLog
> @@ -1,3 +1,18 @@
> +2024-06-28 Ulf Samuelsson <binutils@emagii.com>
> + Nick Clifton <nickc@redhat.com>
> +
> + * ldlex.l: Add ASCII token.
> + * ldgram.y: Add parsing of the ASCII command.
> + * ldlang.c (lang_add_string): Add maximum size parameter. Move
> + escape character handling code into separate function.
> + * ldlang.h (lang_add_string): Update prototype.
> + * NEWS: Mention the new feature.
> + * ld.texi (Output Section Data): Document the new directives.
> + * testsuite/ld-scripts/ascii.d: New test driver.
> + * testsuite/ld-scripts/ascii.s: New test assembler source.
> + * testsuite/ld-scripts/ascii.t: New test script.
> + * testsuite/ld-scripts/script.exp: Run the new test.
The latest here it is clear: No, this can't be all separate commits.
ChangeLog entries, if any, should be added by the commit with the
changes actually being described. Separation of testcases and doc
additions is questionable, too. Perhaps all of this series really
would best be a single commit?
Jan
next prev parent reply other threads:[~2024-07-01 6:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 21:46 [PATCH v1 0/7] ASCII output section command binutils
2024-06-28 21:46 ` [PATCH v1 1/7] ldlex.l: Add ASCII token binutils
2024-06-28 21:46 ` [PATCH v1 2/7] ldgram.y: Add ASCII parsing binutils
2024-06-28 21:46 ` [PATCH v1 3/7] ldlang.*: process ASCII command binutils
2024-07-01 6:35 ` Jan Beulich
2024-06-28 21:46 ` [PATCH v1 4/7] ld.texi: Add ASCII to info file binutils
2024-07-01 6:50 ` Jan Beulich
[not found] ` <6FDD8EBD-2371-40DB-B25B-052278BCBF49@emagii.com>
2024-07-02 8:12 ` Jan Beulich
2024-07-05 15:38 ` Ulf Samuelsson
2024-07-08 6:18 ` Jan Beulich
2024-07-08 10:57 ` Ulf Samuelsson
2024-07-08 11:07 ` Jan Beulich
2024-07-08 11:19 ` Ulf Samuelsson
2024-07-08 11:18 ` Andreas Schwab
2024-07-08 11:29 ` Ulf Samuelsson
2024-07-08 11:40 ` Jan Beulich
2024-07-08 12:10 ` Ulf Samuelsson
2024-07-08 11:48 ` Andreas Schwab
2024-07-08 12:01 ` Ulf Samuelsson
2024-07-08 12:16 ` Andreas Schwab
2024-07-08 12:22 ` Ulf Samuelsson
2024-06-28 21:46 ` [PATCH v1 5/7] Add testsuite for ASCII command binutils
2024-06-28 21:46 ` [PATCH v1 6/7] NEWS: Add " binutils
2024-06-28 21:46 ` [PATCH v1 7/7] ChangeLog: " binutils
2024-07-01 6:38 ` Jan Beulich [this message]
[not found] ` <094CF629-FDF8-436D-8B5B-62D35C3EA396@emagii.com>
2024-07-02 8:37 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05771b75-d964-4df3-81b7-e890a1d91b12@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@emagii.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=ulf@emagii.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).