From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 6AA3A381A89C for ; Mon, 1 Jul 2024 06:38:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6AA3A381A89C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6AA3A381A89C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719815916; cv=none; b=vHSHyFRB9mAitNIDUklXAEumLN3wXZRhhxjqM5tXgI3IdLoLAQx+5JgWPs8KjKxsk8FiiCwKcGIVGx/lhr4LROuZQtHWR6diSM9v0Yvh9QqbIvDFKHVfOvZRJWqSXymcWQ3aA7AkfzgXAsciJSdCL2Vxef+HQ4Qe92y2mhs4bZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719815916; c=relaxed/simple; bh=lsSXNMY2OpfN+BNVW1cc9/NVg+6dwEtIiJbpXWA34lw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=A9IlsnQ0VNlgS0gZcUV/hESicli2PfnVzuXxDkaYAIyP6VSJeVYNaWOXW6FMDowv99JjdZ9V+1ta6g69k3w4/EPqwOScocXyOyjXCDgSEh40u9NzmGMaVA+H+ljHMAd4O4koC/RzzPqoeTrJnSnD5WvWDKAXLxBfZDwfexdUbIk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2ec50a5e230so26070141fa.0 for ; Sun, 30 Jun 2024 23:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719815913; x=1720420713; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=w3eztXJGUr7fQKBKXlkrJxT7wafUB+CyCe90NElw+FI=; b=ZPjqBq1jnp8zu5uBLdilmGiTpUND9lfAoIVEyENmOJIb2lXFGFBTbTMRlMF/J0zqip lbJSyWKBTslr8cNHiwputXZJlfyICK8u0zBtSKhxh/wIUi6bzohUEYiCMH2fwlv2RiHF RNMsl6xHprYiKk33SZ9kHlMDOZHbjLYNLORQsXKO0XAV/3CGt7vzt1meR2RsSXZk8jeS EoEMeP/99GXt03b1qPCILz3t54EHqVu9Zk+xJPCbORuhA3kzX3NDiRBuMo76O6PJ3e+0 Y6x+v/7HyvZuo/EDAFrCxRdwEIGd/CVbtdbmOQYhQJs0NaOwbAZrqAnT9QRM0Omgduvw tNDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719815913; x=1720420713; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w3eztXJGUr7fQKBKXlkrJxT7wafUB+CyCe90NElw+FI=; b=lylZp0sRkTQZDG/cYPTK1O4/+NAz/hvem4OPiOaTI9U5447LRSBxWoJ+QTOyHnkdEJ PUSxwfGxsn9Y/gZBSZYnmnQzKdjxj9ex+HSqClEMupfcWENIpYBksEEsuwFQlqoeW8j5 zFwwWVuCi2+p+x4M5pvdxpZ3m7n3TeTWq5ifpZD13lIDdl8ckxupaRyZf2ID8bTfy2Ji PR/yxc5WWHnQ4Dw3gB1wGZz0ocx/EJzJcrVW7chAiArqkYg1/OU9MZoUArNUhotawn3I Sn1po3fhK8b6PmsCETXfhuVpMVRM2GfO8d2l6O+KBy92IWlx/Yot6rWczkYaGYUaPCpl 1UCQ== X-Forwarded-Encrypted: i=1; AJvYcCW1EmANM4RabAVu2zL1/GXGYV4yMLErgPHD+c6HukCSo0ozf9CNa8AG2I6GkSpDPV2wFczXPKJPaRla7vH/z1DmptY69pheBg== X-Gm-Message-State: AOJu0YxkXqlH6wQIk5UJ8Tvf0IgxfaKX/cOY2jiMJKTuDLgJ/35PNy9y Wn3gCyFlsOXvaQfBGn+SzEzrNCIk9mxupCvQjOZ690w0TxJpkf0/NiuFKech4eP1IHsH5zJOU1M = X-Google-Smtp-Source: AGHT+IGWMexhsz1Hv7BCdRm22f7JXulVAFj7QqqO6Qm+lh3aUBCY7VIWgwUY29YewlRHSxXupFMCBw== X-Received: by 2002:a05:651c:4d2:b0:2ee:4dc6:fe28 with SMTP id 38308e7fff4ca-2ee5e6bc2abmr32660681fa.40.1719815912859; Sun, 30 Jun 2024 23:38:32 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70801f57d38sm5700069b3a.25.2024.06.30.23.38.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jun 2024 23:38:32 -0700 (PDT) Message-ID: <05771b75-d964-4df3-81b7-e890a1d91b12@suse.com> Date: Mon, 1 Jul 2024 08:38:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/7] ChangeLog: Add ASCII command To: binutils@emagii.com Cc: nickc@redhat.com, Ulf Samuelsson , binutils@sourceware.org References: <20240628214627.6726-1-binutils@emagii.com> <20240628214627.6726-8-binutils@emagii.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240628214627.6726-8-binutils@emagii.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28.06.2024 23:46, binutils@emagii.com wrote: > --- a/ld/ChangeLog > +++ b/ld/ChangeLog > @@ -1,3 +1,18 @@ > +2024-06-28 Ulf Samuelsson > + Nick Clifton > + > + * ldlex.l: Add ASCII token. > + * ldgram.y: Add parsing of the ASCII command. > + * ldlang.c (lang_add_string): Add maximum size parameter. Move > + escape character handling code into separate function. > + * ldlang.h (lang_add_string): Update prototype. > + * NEWS: Mention the new feature. > + * ld.texi (Output Section Data): Document the new directives. > + * testsuite/ld-scripts/ascii.d: New test driver. > + * testsuite/ld-scripts/ascii.s: New test assembler source. > + * testsuite/ld-scripts/ascii.t: New test script. > + * testsuite/ld-scripts/script.exp: Run the new test. The latest here it is clear: No, this can't be all separate commits. ChangeLog entries, if any, should be added by the commit with the changes actually being described. Separation of testcases and doc additions is questionable, too. Perhaps all of this series really would best be a single commit? Jan