From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id D60C83860760 for ; Wed, 27 Mar 2024 11:31:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D60C83860760 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D60C83860760 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711539097; cv=none; b=s5WeYcYdL8BDXGwA1b8iBvJTYKc0lG4KoosuTCWakNCPFWTKOwMj1Bd0BYfJdiJB4Luj/Jdk2DV+6D69NC6xYKo5cSrGUdF/quKT39qToxZfKUhjyfdR/TVE+ZO0TF/aRcQMFYW/l4/fEf0ELxxNjKC3sb2wm9WvTHHmD4mPEdA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711539097; c=relaxed/simple; bh=HRDnZbtwBG5iLY9kX9bSvM3FLyVE9U6BHpsQ2Ex2KU4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=XSL0ZTRy6sbWK4pkm9TmvzgNav5qeS+GI+O09ufGk3W7RzN5JSanLG2jArEUNmyPUN65f3kvKEvb6mP8L0534UXgwvZ6lF46KoprA1NNP2hsp+B7HKC4JttuFJreo2e8zDazPBq0ZQ8i/47e/CVXhyganwjfTZopcF0Wkj+vhZg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a46ba938de0so879804066b.3 for ; Wed, 27 Mar 2024 04:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1711539094; x=1712143894; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XBVDHXrc3kgyGafhQvDnHWmy/8spum7lBjEY6LPCuO4=; b=Wt/oufFG0aK3h7qWNpLXe6RuQj7HpFVDfrTaBljScMP4JOWThuhopSsX8iWy7a29w8 VupzGmmtyu8S1a4U4p60XwyGa+8LU1AmzXrAA3AqAkHmcMgaeGkmbldMlfDPb/CwO55s K4Tbg6LRJ0D4bk8RKA62HLBFeBNC/I9SwrajY67QfHkiki1ISBvaoNOEJB/z0vA3QvSz MXxkY0Usx1zXhdQT+kEoeEpr21qsRzAs4AKx+zh6P9lurQ90hHzrIGAUxA5yzHYgXGBc 9pxdTCP3vM9qYh82EnM+YWpjER6lTvIcblN5MdwZHtm1OGU7eELqA2zckIwtqnHrsrLj dRsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711539094; x=1712143894; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XBVDHXrc3kgyGafhQvDnHWmy/8spum7lBjEY6LPCuO4=; b=ZoCM/RmJYr0QDqHBOiFmf9w+BSVVlnVgO/R9Jo/DBa3oZwx7c/phzVWKKQSwylTDkK JiqWjVFLDKQZlafC4SV7NluNgZtuCNETqj5sWLviEGpYpciKyyGtwvkWD4LLqYNQ4ANs QK9kJ3+1uDXIAcRy24txOhvHCRT83mi1IAwg2s9gPKIM5iMrBaWsrBGXHXjRlZnuqDyh pc3sEvxcFcZB8/CcfRIuFYXcCMok04QmG09gl6JRoSBaJUwffbJ1hL7FDIAq1mPgY7pK MWtgWEZbo8NaYU/Ht4Tdk16o2moP7Ncxkpj2LjnZ6Ht5uH6W2pJ5ng5ewMPHvAnTHzoJ 7SpA== X-Forwarded-Encrypted: i=1; AJvYcCWoFxBBnxojLEo86KG56ltnuK4EEfsyuVhTJquwPjCZPosH0+fJCciHIg13jL+xco7SW5fYSZTIB76B7XDOH9PmwLN9VQF9HQ== X-Gm-Message-State: AOJu0YwRXjyP4OdJ+UMAwdlg8mVQ1dwAQzu55+d/ApRFO0wSjKb1iLIJ P4aa/iYAX8PyKN1MnwyP1lMhyCvp0TcAx3QVP0WNqO4fNaF/wGoaT3b6+YcdyQ== X-Google-Smtp-Source: AGHT+IFUT1jk/u4LiQynnhsvmHBWH5au6/KID7vhFI/BoZTrRbmIFwC9x8Sdgx9ozvPAQal5LbYkQQ== X-Received: by 2002:a17:906:474e:b0:a47:4e09:e685 with SMTP id j14-20020a170906474e00b00a474e09e685mr3642565ejs.32.1711539094496; Wed, 27 Mar 2024 04:31:34 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a26-20020a170906191a00b00a4e03c28fd5sm684367eje.43.2024.03.27.04.31.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 04:31:33 -0700 (PDT) Message-ID: <059a04ea-43f9-4df0-84f0-f5dde251534c@suse.com> Date: Wed, 27 Mar 2024 12:31:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] x86/SSE2AVX: respect prefixes Content-Language: en-US To: "Cui, Lili" Cc: "H.J. Lu" , Binutils References: <663e2e0c-b098-476d-aac7-9bda63187af4@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.03.2024 09:47, Cui, Lili wrote: >> 1) Without -msse2avx we unconditionally honor REX.W. Hence we ought to >> also do so with -msse2avx, converting to VEX.W. >> >> 2) {rex} doesn't prevent conversion to VEX encodings. Thus {rex2} >> shouldn't either. >> --- >> Further {evex} may better also be respected, but that'll be a bigger change. >> >> --- a/gas/config/tc-i386.c >> +++ b/gas/config/tc-i386.c >> @@ -3885,7 +3885,7 @@ build_vex_prefix (const insn_template *t >> /* Check the REX.W bit and VEXW. */ >> if (i.tm.opcode_modifier.vexw == VEXWIG) >> w = (vexwig == vexw1 || (i.rex & REX_W)) ? 1 : 0; >> - else if (i.tm.opcode_modifier.vexw) >> + else if (i.tm.opcode_modifier.vexw && !(i.rex & REX_W)) >> w = i.tm.opcode_modifier.vexw == VEXW1 ? 1 : 0; >> else >> w = (flag_code == CODE_64BIT ? i.rex & REX_W : vexwig == vexw1) ? 1 : 0; > > Yes, we should also correct the operand size for AVX when rex.w appears. That I did suggest before, with H.J. objecting (iirc). Jan