From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2043.outbound.protection.outlook.com [40.107.20.43]) by sourceware.org (Postfix) with ESMTPS id DC478385840C for ; Thu, 1 Dec 2022 07:21:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC478385840C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=juWecM/A2mGvnWbkQiP6G03oehQJdGHc27Nw5WmQH/faZeDQ9gO+wu0oc6Hus3GvZRJjxOggGBAGXvoEye9JDANCfPmX5qOUyLUHasDRf5bb22NJlmmY0az/EjXdn46fXSM7PcTidJefCOJu4SPLI25bh+BipJxISviqtAyOWBtvYdylnl7RheiuR8qQFh3TP8D2hAxwwVItmdmnv9QxnL0nV8fzhhx1hft/gyWAO8ZLooQ9p++MaRTqXYNyXSfQzmFLSGSQbJoHqytFOsZKuwzu/Cnwnf7Z0W0QhjS8a/vF7SyGqUSEZskgykfzD5dc1jUfoOPHadLvdZ8qi4zGng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M7x2mXdpklKKMQnkbYTxgpfvV/UWWEqVIcZAZTfy51Q=; b=LqmkVrta8w6rwD4GVQgWZYehv1+0vOW1cWHXSG7uoAtcORIu3WHJNLYE7hf9BkfGNaJGX6r/WI80hJxOMPKFf2m3Ru8Ghb83Kx9m2TGHQefX2Vsxc0blP5cEXExWvYjcMsRTiV0EZP6PTiSTEays0vQPbJxHLShmInqx//q2bRuqXwEtUuNVGeI71YabIQ/JKRD74/yAZzoSCiRIF984J6/kYM/24s7b7UvyzqhiDTMXtjkHgxotvQ33xWDtV1c18dqK3v4KvymNLpyzeTGDLJgwglpIvQPoGOS8eGaBa7rt6OXjLLnWA15WuzsQFgTVNRN9fk4i3PR9E6MF3YWmCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M7x2mXdpklKKMQnkbYTxgpfvV/UWWEqVIcZAZTfy51Q=; b=h74S8c8O3XDYKCnBMZJahhYAAud6xDrwGCXZc/iNoqgn2EMamDR04e1/SOE4SfY4HW1oylAYCsHatLu4yEOtsDDfw6pYhZFTSzQH76MdWxDUeaSFDUANPeLgBwilMLJokbybagcdsMM3cpK97eck5YCNTcQTh7JKe+dcXQKucRhD1RJbgGkj01Js06C8iCrGG7Nd99EQ22lR4iCOKZCYX7RZ3YzFL+PnIsHE6jICFGyKyFWfCbysIwskgXE4Tb9CURYm6H+/vBxK90QK+xKmjxf1xZCtxyDtdV4K115JdRP7HnEeB05FSA1ZgbRHJC0TKukb7TguGAclGnCdXYfHzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7826.eurprd04.prod.outlook.com (2603:10a6:20b:234::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Thu, 1 Dec 2022 07:21:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Thu, 1 Dec 2022 07:21:29 +0000 Message-ID: <063e5b0a-8a77-2734-330a-6bc7466546eb@suse.com> Date: Thu, 1 Dec 2022 08:21:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] x86: Remove libopcodes dependency Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20221122181927.251937-1-hjl.tools@gmail.com> <6a5d4918-919a-8b6b-822b-17ce38488629@suse.com> <3f038bc9-6188-9bc4-d73c-51cc633fd69d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7826:EE_ X-MS-Office365-Filtering-Correlation-Id: 260a0d06-7f1a-46ea-5dca-08dad36caa51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ONme+lGeTWK6btp0fQCAIQNMHNVJuqcdfjgVTns67XIE8UHBS5Cjm14I+ohdNsI1qDe+xOlrZUg9vNxH95J7vftaD9MB4kBZ++6RBVcI2owhdXgNl51cQOTsuZwxKCtYWmSpYSuduuvHbMD6nNmGqiH1Z6r1yQGuEiultIlPfPfOT3tMjOxmJeSMZmPKE9uPOVH/O34TJkT51ud5lKQgMhJf6C+vlK6EzSzgYUaC0hY3/BTHqDelVmv3wxjT3Ihb0kSjsF/I33sbzSs8RRN+RYOl9QRYHKdrTNOcCHor7q1L6i1M99KbpNSHoCY2t8WvZbv4gl0Azld4ivDDIOI+v9EGkC6dfzPzCYdC1UO5Dlp8LG/AnKcvtEwAa9ml6lOC+dylNFOikJdjK7pURNHJa2nqrJ0V+n3TNsjPLllFM4b2VNuHjxLLW4TihhI3vyRb6sckiiRUY+54HoCsF1WNZRU9uXTlCz2CKN6cadNWWwlXbpEKAvAYH3zLYGY/o+SU8Rr3EWkd5j79YI4kSU/KP1B9jw3yGIInHEsUadkV7gNJY2ajbyKvW7E/9gPsR3dMQuOacr23UcHPy4aGv2v/5tZy5cGxFUumlXN2IsfY3zkt6PuWR3T8aZH6KahMX+Y5Xsgo3mr0umEF+aF4HAjNuRRyEqJpNXkM4B3OzfP9qJwe95w3y/OO0LEwEelyTKjyR8oJnRQnkuKBBHp+en4Onc/Eq5VCILDQC2JM5uNw6FE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199015)(36756003)(2906002)(4326008)(53546011)(186003)(86362001)(31696002)(478600001)(6486002)(66476007)(66946007)(5660300002)(8936002)(6506007)(316002)(66556008)(8676002)(26005)(6916009)(41300700001)(2616005)(38100700002)(6512007)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzFPMjFwOG43QmxjUTgyU0xpdzJjWWdOZEY1VUt1aDM1VDBCbUtXNXkxUHpH?= =?utf-8?B?T0E1eHNnY3E4NHp6SDhkSHc1MlBHdjhRTTZLRTVLUllEeVFLU1FhVVhtVnZU?= =?utf-8?B?Y1hBemZvMzduaWdTam5WWlkwclVVQ29pYXhWRnBoczdmaXFmZk9lMEZjTDd1?= =?utf-8?B?bU1zTTNhdEJFejVtYlFjU2xZek1venhKZUxqVmNVdjlXVzM4UnNBOStsYkFn?= =?utf-8?B?eGxaK2lYYzNvemYwU2hsd2dtMmNLZ1dRY3ZPTCt4QmNnVm1wN2ZWZEptaEJV?= =?utf-8?B?WEZZWHpWWmc4ajdhb1EyeG1STlQyVGU0UDVKZTVnOVdmUSttOXc4YWh5cDRY?= =?utf-8?B?cTk5N3Y1MG5nQkxKVU4yeHJoVW92eWRlNlhPYVJNVzRNbUFIeGV2dndHUnJN?= =?utf-8?B?em5CbC9Rd252ci9PMmY4Vmc4MGsrVVdKbUpuS2ZnOVZQdHpPSGpxZ0VNNi9Z?= =?utf-8?B?TDVNcmhUN2hseVBadVJWNysralZUT2FNcmY2eUNLVVNuYWdjRHhQWXAyZmNp?= =?utf-8?B?eUR6dkgvRmcwZUM3QlE4UnpmSVRjaFNRbUZvZms3dXg3TXBiMUpLZ0dNYURJ?= =?utf-8?B?ak5GeFU4MU5PcUJtbDBMeHFhU0lsTWhuUm9MeXFxZXBPYmVjUVVFN2lYeGJs?= =?utf-8?B?ZGhLbkdmWVFZYU11cGRPeEFQSnRkWjFzOTMwbDA2QldIcFhHbVFKQUpwaFRp?= =?utf-8?B?eHJhQm5yaFZ5UkFvTll3ZHl4a2hLcHNBbmtIS3M3VmZ4Rk95bEJYNnliTWxM?= =?utf-8?B?NE5XNVJyL1VQVVVMU3JLTmxuRDVjazcrb1NEVnR3S01GTjczdDNmbVlTSlI1?= =?utf-8?B?dVlQRGpTYmpsQjlYbUZpZXdvTXhDQyszOGp0M2RMUUwxNjVLUmx4ZkpqWU9x?= =?utf-8?B?a29zazlpa09rYU40ek1UK3FmYkZkV2p1MlRpT04rZVlXL1A4Z3dxZFdmeUNZ?= =?utf-8?B?NmZiNnRtWFZtdjVZMUhLaXBVcVZmdEs5emNqTk1UK2dkSGpBUFZ2Y0F3VDFU?= =?utf-8?B?czNEWnoxdnFTck5iSy9oblQwalpianhvN1RUbzhoSlExL25qT3RpVmt4aWsx?= =?utf-8?B?YjRpcmVHckUvQ0Z2ejF5VjE1cFlieEVSczN6Z2E0SVh6UmxvUXZmWlJIR055?= =?utf-8?B?Sm5VL0pvMDZWWkdIU25Ubk4vbmVEOHcvMjkrR29xcjNlL2wzMTJmeG5hR0xW?= =?utf-8?B?NmRPSG5wa05SZUg3L3R2NGR2a2FITisrYThoWjM3ZVlxakJYT2c2ZlhtT2VI?= =?utf-8?B?TlMwb09wY0s5RjJpd2RHWmFmQzRia0UzUm5OT0ErYmEyeko3QmxWRXNZUUVs?= =?utf-8?B?TEgybTlzUU9oVlh0cnBGSWZVWXM5c0lRNnMwKy9PY1BqSjlvZVZUTGJSNHhW?= =?utf-8?B?U2Jtc3NWcGV6Ym1CeGdSTVRxZWx1YVRvSUZRNGdUN2VNZHJzUVNjZkR3VGV4?= =?utf-8?B?N21tRnlHRVJRMGh6bmZRZndHMXNnVVU1bDU5YVVmejd4MldhRDAzNVFqTi9j?= =?utf-8?B?cHFPaVc4NkZRaXdDdzZUYkpVZktJOHZBbE1mNGU2QUNGaDB2TDd1VCsrZytS?= =?utf-8?B?RkJZUlJBRXk5Wkp3WVRIb3Qwa0Y4RUhKeXFkUXh2aUZmY05zS3JJWUtrRWZ3?= =?utf-8?B?SjRZUm5mL0RUbDhqWFVzcXBHVmtZRGcwc2h2blBnWXd2allrZWJ0c1lzSXg1?= =?utf-8?B?UDZpclBpUG44QzdxSjM5Qlk2ME1XWW5mMGF2R015SUJDa042RjRGWHJzdzg4?= =?utf-8?B?eFkvWHUwNUhmeEhoTFppYU9vMkZRY3NVMW1XU2k1cWRETjBtWkdMTmlRdUl4?= =?utf-8?B?UGJPTkkyY1RBVmRjNHBKK2kyeWRMRmhjK0c1c0s1RXhsVHpTbmkwZVNnZU4x?= =?utf-8?B?cVpDUnl2cWQ2Wm1tMWgxMVNhR2xIdktUOW5kT3E4WVVVWFpGeUtNeldjYjFn?= =?utf-8?B?MnlLOGYrKzJCQlVTTWlNdWtmSi9xZUNpMi9WUTVBb0NHQjVYTXg5cmhqMm1Q?= =?utf-8?B?YVdKSGsrekMrdTFpb3hVSTJObUFaT3RTY2lXTFZ0OGlIOVlYOUhQTDVLM2Fy?= =?utf-8?B?RS9OOGxxMklPbWdCVHM4UlJDOUpXbkpYNEZkU2NIMFF1UjJYa2dJaERZN0V3?= =?utf-8?Q?EEoGJ0Vf3Tb5FTgYLfK1CkOXn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 260a0d06-7f1a-46ea-5dca-08dad36caa51 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 07:21:29.5609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: og805rYKFOOQ+/RWMVfF3MaMKWfXIPLTk3PXx8TlC5pKGr4BoBuk+fHUJEtYm1HSWRKtpWwsf4V/v6mAhOsEFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7826 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30.11.2022 23:15, H.J. Lu wrote: > On Tue, Nov 29, 2022 at 11:31 PM Jan Beulich wrote: >> On 29.11.2022 20:38, H.J. Lu wrote: >>> On Tue, Nov 29, 2022 at 1:22 AM Jan Beulich wrote: >>>> On 29.11.2022 00:49, H.J. Lu wrote: >>>>> On Thu, Nov 24, 2022 at 2:19 AM Jan Beulich wrote: >>>>>> On 22.11.2022 19:19, H.J. Lu wrote: >>>>>>> --- a/gas/Makefile.am >>>>>>> +++ b/gas/Makefile.am >>>>>>> @@ -446,6 +446,12 @@ development.exp: $(BFDDIR)/development.sh >>>>>>> $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ >>>>>>> | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ >>>>>>> >>>>>>> +$(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: \ >>>>>>> + @MAINT@ $(srcdir)/../opcodes/i386-opc.tbl \ >>>>>>> + $(srcdir)/../opcodes/i386-reg.tbl \ >>>>>>> + $(srcdir)/../opcodes/i386-opc.h >>>>>>> + cd ../opcodes; make gen-i386-tbl >>>>>> >>>>>> I've made a patch to gas/Makefile.am as you have requested in reply to >>>>>> my series. I will want to put that through some more testing, so I will >>>>>> submit a v3 of that only a little later (and of course only unless you >>>>>> submit a v2 of your patch earlier that I would also end up being okay >>>>>> with). In the course of doing so I noticed a few more issues with your >>>>>> change: >>>>>> >>>>>> For one I don't think you can put @MAINT@ on a continued line, as the >>>>>> line continuation might then be hidden when @MAINT@ expands to #. The >>>>>> list of dependencies wants expressing via a variable, which would then >>>>>> be used immediately after @MAINT@ without any line continuation >>>>>> following. >>>>> >>>>> Fixed. >>>> >>>> No, the same problem is still there. You either need to use a very long >>>> line, or you need to introduce a variable holding the list of prereqs, >>>> like I've done in my series. >>> >>> I got >>> >>> $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: >> >> Note the missing line continuation here. > > They are on the same line: > > $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: > $(srcdir)/../opcodes/i386-opc.tbl \ Oh, okay - just a UI presentation issue then here. > or > > $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: # > $(srcdir)/../opcodes/i386-opc.tbl \ Here, though, this is an issue, because the line continuation then is past the comment character. Jan