From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 837C43857C48 for ; Tue, 28 Feb 2023 00:18:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 837C43857C48 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=harmstone.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x330.google.com with SMTP id fm20-20020a05600c0c1400b003ead37e6588so8382261wmb.5 for ; Mon, 27 Feb 2023 16:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=NC5CcVEuWLN3YsmYMK0wTJKAuh6MxJoxbQgZMjV8Fmk=; b=fm7vjFaD6UvhR8StZrOm6iSTyBgLdp0fCvKDgxa5hm5pDDi/F118lx+d78SAWsUexT 8/JRsAUdWDDgH4H5xDVy6Ybmpw0sU/4av7sThxR5r/E60umSi+UCETioaEhvNS3Tz9AW Nt1fDlsg8d9urAfAjdRuCQuTN1EJUL7/mnldzrgXg4ldgkOCckK15K/C2INiTo3YqdTa 2GDjd1MVKC7Vx4CVS0BHSaH6ZFFSj7Newp+moB6+KHNrkgtMEvuA41GCqXy7n6+jbbFo 7CwSqw8o8l80IIl4q1L8AVyFWbNtJaXR0VDirnMLZlmzLP5977mULmfCmajPu/7Gxz44 ZtPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NC5CcVEuWLN3YsmYMK0wTJKAuh6MxJoxbQgZMjV8Fmk=; b=ZkPYtIfVEXp/hai5zUeAwxZFGbfkdqwnBWrI3Dug+1RXf+Bl6cCzil0I0FjusDyPQn G0M65b0Uowo0cH8T4HNdzgzLfTFYmABUdHMXi0YWGLNR2SPDV1n28Zs4NSABBu1iS/UO CxX/QLkxvE+fYfvoz/9RqEvbmWm5AXLEhH3ZU9xK5PstlBlNTq8nHuHKDkfivrFxfcuy V5U0WVS09fM3ez/KLE5tOjEVIi+OCiWdFZ4V3zrdYrVSIYW14hA1VhBzxQQ6tO2OvbeD noK8SbU7vBM619nIeeq7tV6PuoZh2Gx9q/34RSJ+SFehOX4LoFc729sUGZtC4tQJHrPX MAQg== X-Gm-Message-State: AO0yUKX+p98Y4seD94wkvZcawI+AhCDbwSoyb1RlPyI0X1O3T2CG8KDZ cHJKpTaRTy4y9XC8UpQO764= X-Google-Smtp-Source: AK7set9cfYKD31Bn95ThAqYTV5uSW8jQ0ODIEKn+GUxx/Tht6Dt/9Mf4gx7DcJqvxoX0syc5YZatbg== X-Received: by 2002:a05:600c:538b:b0:3dc:4356:533c with SMTP id hg11-20020a05600c538b00b003dc4356533cmr662898wmb.5.1677543520401; Mon, 27 Feb 2023 16:18:40 -0800 (PST) Received: from ?IPV6:2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f? ([2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f]) by smtp.googlemail.com with ESMTPSA id bh22-20020a05600c3d1600b003e01493b136sm14168301wmb.43.2023.02.27.16.18.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 16:18:39 -0800 (PST) Sender: Mark Harmstone Message-ID: <067d464d-2a2d-3dc2-9b33-afd716ecc1f4@harmstone.com> Date: Tue, 28 Feb 2023 00:18:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] ld: Sort section contributions in PDB files Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org References: <20230227005935.12270-1-mark@harmstone.com> <3aeaf40a-f59c-32be-9fad-1efc18ce6bcb@suse.com> From: Mark Harmstone In-Reply-To: <3aeaf40a-f59c-32be-9fad-1efc18ce6bcb@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/02/2023 09:13, Jan Beulich wrote: > On 27.02.2023 01:59, Mark Harmstone wrote: >> + qsort (sc_in, num_sc, sizeof (struct in_sc), section_contribs_compare); > You want to apply Nick's requested change here as well, changing > sizeof (struct in_sc) to sizeof (* sc_in). Okay with that adjustment, > assuming ... Thanks Jan. I'll push it with that change, then. >> + ptr = *data; >> + sc = (struct section_contribution *) (ptr + 1); /* Skip the version word. */ > ... you did at least consider Nick's remark regarding this, but > didn't find any good replacement (and Nick's suggestion also didn't > fit). Well, that was one of Nick's suggestions, and as Alan says it's a matter of taste. Mark