From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53]) by sourceware.org (Postfix) with ESMTPS id 0ACD33858D39 for ; Fri, 29 Jul 2022 07:23:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0ACD33858D39 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZFeWr02jZRpllVfftMRLIYr92AnjkZaaQw5juAl1+Fk8pHscBH0JF4OYg3ms0OLuRzlvOvGi5CvtNzNbbxN8/q9W1+248KteASo0lDnLUmZIrGUB6xKrwX5OHenRwdWv8AhwjOFhE7I4Kw+y6q9DcQEppN0+QlVSWk3kI0+zl7T8hCtRn6bWf7CkdaBFyYHvkZnxn3vNCrrxfFDNf8wS5FkmNsO7Myy/LwxtE0ZRUJtwjQCyK2ti3uk01C1qqmAuVJWZSlmcYEg4Gm+uyoXPMZtgTORtF5Ng6RZx+gn+HGEqZHc3P7QgAjv4X1r0pKNKiBC9bl21cKRFXRKddkWvMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t+GUJn0Tsw9QoH8ZJHI2t/x3O2q9kqUld2o2N8IO1I8=; b=jUFAMKq7O46uDVkAPYhfTp9O0uOjUzEel5azbkrLF8UNtOR0EzMDZ0TIHHTwXYhrSEKOmmRz6EjDzqILMUEcEub4ZpVdixkGxicgynB6qGO8p21nIRD/zdnuRoCudLAAv07pDp+wq/2DFqyFzVy9b5pqxZokPSHzmkj8s/huR+nMDgZvHveATr/hLXwE9tn94dKsDUM7l3krmahgL6XA98oGBSmrB56YXZVIp5ATfTvIGZJqbTMMXhke1NpqWzZhf8aLn+0uR2RZW7Y4MklkUu2IXEX67pASp9IIMJ1lXHpOviEX+foSWPjxHcO7xPW74GxaGren4KaPrLIHwD45Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2373.eurprd04.prod.outlook.com (2603:10a6:4:4b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Fri, 29 Jul 2022 07:23:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Fri, 29 Jul 2022 07:23:31 +0000 Message-ID: <069ebf9d-53e6-97fe-6785-355da52e3b80@suse.com> Date: Fri, 29 Jul 2022 09:23:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Jan Beulich Subject: [PATCH v2] x86: SKINIT with operand needs IgnoreSize To: Binutils Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6329a2a-cd58-4795-7d50-08da71333d51 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2373:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Blg/I9PhmThVVa5D3YioLbVDIurWajkAjvDHfrtw1qmkOScT7axcQ0/c1utSbsL3qyKTB4xnaW6IxkMqKi3g5JsFTg7lbg2PQb8MLOftKdn30lnDZmzV1DKOhBX28+J7PKu6Wm2aIE7K7GFPgOb1MEqfPU0sg59Kn04xXZFuwkCXJwdhzc3VEmmxEAdZL+WPpVjaMrb+t9+LmOzUjAfCKbsam/SQM+HRSA+ECYGkqBMDhcvj6rOX+5MTE3GijQV892s2+Ho9Q0iMvASek0MTym+NLFrtEYivLMoy2tMcAHhQ95wN/q+S2Zj9+8xBfPmC7qjzv7HVh7mwCI3D+RfVfi26/z4897fwi46GM+HSOYyw7v/S8ZAZsASxix/bSR+n3/Fm7rBzYwvR8+bw7xo+4efRD0hSX3RxYpnxM3KkpmZ5GbWf9naWRshADxk95in4+XsFLtj6xJ5l/dzIj9U6hnES+2cdlHhNCJ1F86YzkB9F3jn3ZJ7r7k9vPnI6ryODIWtnhBZT5E6lszhjORr4RvoZZAgpYF7lMZBNvqlcUMigktvq8huiBFzhEeyIjd1ME77pgkCOqZQ+rMfvrsTRo6K+QuqB6hX+pzr8+xWp9YNuQjYhUucU7XyXOp1mIKSkFQtf8pKc7UHMpKVKxEoixbKePU56t0npsjyOPgQhQQt4ubLhAV2Qlvz8AmtsjxnJBB3t5YX96QN9CxyEva72K+lmUDYk5ibYvl498IwTcaKEq+RrziodJY7Iamg074Fy2f78bSdP+mrkG9oc4tymBhf9Uqxd3LehUNenTCPatJET+tKDqPPE/BxHKBQP20ex9vmm77dnrFU/CRIFgDYdwQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(366004)(396003)(136003)(346002)(376002)(38100700002)(8936002)(2906002)(31686004)(5660300002)(31696002)(6916009)(66946007)(4326008)(86362001)(66476007)(36756003)(8676002)(66556008)(316002)(6506007)(41300700001)(2616005)(478600001)(6486002)(26005)(6512007)(186003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFZLcTRrTlpFZThKcFhjOG1qQ2NObXI1VGJaSml2aEMvUnA0cEdLSzlPeUR5?= =?utf-8?B?Y21oWmtEVUgrcE52U3p6VHFaV2ZwZWRocURnYklQNXhjOGNzd2loa2JEKzZ4?= =?utf-8?B?VjQvYlJsZ2JqVkZsU0tiWXREbDdGR2xWVWRYRjdQd1JoUU1WdE13UHc2c28r?= =?utf-8?B?U0h2dE4wZ0VRSVlzdHR6aFZqa3V1dC84a3FrTnU3cTNUK01KbytJbVQ3bTYw?= =?utf-8?B?Tm44NmRtbVplK20wUFVnYTNFcGM4LzRxOTFtbUY5RXNXcDVIWGZtdlU5bWJX?= =?utf-8?B?cGdQNHZyZWMyTENiZnZyd25mekJoeTJ1NEluakpnN3JCVHAwMWFqankrTlNz?= =?utf-8?B?OGtRTDN5VklydnFUYk1FM2VoYTlzWHptbEZvajBOWlh3QUU4ZnJOM2JkQzRN?= =?utf-8?B?ZURUTW9rL3ZkeDYyaHFZUVNubnpWaHZBSmptcTdobm9oVDJzRU12NjVVUWNk?= =?utf-8?B?ZzdQb3dyOHRmUURVa2dOS3RrSFFLQm1Qa0NkbGVaRWlCNzJWZldlU05RbWsw?= =?utf-8?B?aHNxQVJDbHg5Rzg5SHZxRy8wdVZVMFBOQnJ6T01yRFY2S3VIclNqTDVCQ0Ix?= =?utf-8?B?ckdjWW9ncC9FV291ZUgzZ0pqNUN2TUdrUHE5anh1NVN5TWx6QlJOUXJNUXBm?= =?utf-8?B?NE1UN1VTR2xaWFFSL2k3blRTNVd6TUxaVDZDdHRFOTkzZE9nd2h2OTNRNmRr?= =?utf-8?B?N1l0L3Y2ZFd2RjY1Z09ZUmx6NW9BQ1QyMGZDTEF1bjNhQ3dHcnRlY2Z0UkJu?= =?utf-8?B?ZlhwZmZQVWtKQU54c0VXUkcwcTlZYkRDQXNRc0JNazBJSkhMUGtWRUlDdmJV?= =?utf-8?B?UXVFN09Ga1gyMy8wNlZrSElLQTd6US82MWU2S0dqUWFTZ1EvcDkvQnp4aWhE?= =?utf-8?B?RGsrUFd4QmFZbmVnN25pUDU2ajU1N3VQbk0wNjErSGI2UnVzc3pZNnpRY0Vv?= =?utf-8?B?bzVBZ2F4R2VWc1BiREszbXBsUlltSmExM1dMRFA4OGIwaENacGpiYWpZZmFO?= =?utf-8?B?VTJwamplMXVUL1lCTVVBU0Nyb3lKYU1UL20zRllVTHBydjVOODdabFJzenNh?= =?utf-8?B?RXRYNmhxQlRGSTJoUHBwSy9PSFc1NTZiMW01S1l3bDRCWUhiVDh3QVZFTXVW?= =?utf-8?B?MjNwcCtmcHBPUlhaRkFRZkQ3dmlESWVwdHBKa0FVaDJvakZETWVXaHBlNnFR?= =?utf-8?B?Z0VIU3BUQ1RpVE5yb1JJM1QyeW1ZVkppd0IwRk9vRnhVTEJMN0hlK0E2TCs4?= =?utf-8?B?bnNrS3lWWVhLZnlKRWF4ZXlrMjY2MmFvL2c1eGg3OXVMejhpZFpWbXNOU3Zs?= =?utf-8?B?ZnkvNTBLZi9aYUhXUW5UVjZ1RFl0bEV1bFBDYXQ3U254bUVtNHpmSHljYXdp?= =?utf-8?B?dFREaG9rbGZRQWc4UWw1YytyeWt2bVovUzZ3MGdqVzRkYUVrdVEvSml3dmd5?= =?utf-8?B?VjQrMTh4Y2xRTXhKQXVhNG9XWDdYQ0tuYnFFZmdHdmp3ZUJqZVF2STJqYlVv?= =?utf-8?B?R1Z2M05DN1pEU3lCMmxQL1UxVkl5a0tBNXdVdVJhZ2hIY1RKZlJFM3RocGZr?= =?utf-8?B?Q0RPamJKQXJkZ1ZnbVJnVnBPUEt1cWU1Slp5VmwvWU4xRUdBdyt5TjQwY0lF?= =?utf-8?B?aFQrWDhUVExyYW9jMmpzTXBSS3JGdDhIakNkSnVuU3lady9jb1NCWUJVZUp6?= =?utf-8?B?V2FYQllsT0lURVV2YmkzUVNETmhNWlZockZ4eEJmYXFtQzBpRFlidjBsb0s5?= =?utf-8?B?NkRzd3VIdXJNdTd1MVdUYU9oUkxXcnBpdFJOVkJ4QTJmRTVaVThzd2tUc1Na?= =?utf-8?B?WmlyNHdQK2hQLzdjSU9xWUdlWWtRc1RYWUV0Tk5TRXhZUDdLVUtHZHJwQ2Nx?= =?utf-8?B?a1psbnpQTHN0L3oyT00wZUtGOElZbnlWMFVGbnpIQUlkY2I0MXhsT0M1aUQz?= =?utf-8?B?Q0tuUDFsR200ZCtMWWUxQ1ZiZ1RPUElKNnBLbVhZa2FodHcvSlZzYTFrbnE1?= =?utf-8?B?ZTJmM053VVRheW5iTUw4a2lQS1hSejRBQmIzZmZuc0VDT2FGaHQ0RjE1UnBP?= =?utf-8?B?aFJwQUVkN3RYbTZSQ2YrdlVUNzM3cUJKQ1hidUovQVgweFVYUjNocWRNOGRv?= =?utf-8?Q?CpcN2qhzNM5ht9heBGDiypLeb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6329a2a-cd58-4795-7d50-08da71333d51 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 07:23:31.3461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RbIDc1cDQTm9x1Vb1MAf51nLiO6q0t5xkq2Gu0yLn+xA08AsXN/RERj85YvLIla/jNxP1XHLbgaJtKp4CHMTjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2373 X-Spam-Status: No, score=-3030.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2022 07:23:35 -0000 Without it in 16-bit mode a pointless operand size prefix would be emitted. --- v2: Clone new testcase. --- a/gas/testsuite/gas/i386/i386.exp +++ b/gas/testsuite/gas/i386/i386.exp @@ -109,6 +109,7 @@ if [gas_32_check] then { run_list_test "cr-err" "" run_dump_test "cdr" run_dump_test "svme" + run_dump_test "svme16" run_dump_test "amdfam10" run_dump_test "ssse3" run_dump_test "rep" --- a/gas/testsuite/gas/i386/svme.s +++ b/gas/testsuite/gas/i386/svme.s @@ -1,4 +1,7 @@ .text +.ifdef __ia16__ + .code16 +.endif common: clgi invlpga --- /dev/null +++ b/gas/testsuite/gas/i386/svme16.d @@ -0,0 +1,41 @@ +#as: --defsym __ia16__=1 +#objdump: -dw -Mi8086 +#name: 16-bit SVME +#source: svme.s + +.*: +file format .* + +Disassembly of section .text: + +0+000 : +[ ]*[0-9a-f]+:[ ]+0f 01 dd[ ]+clgi +[ ]*[0-9a-f]+:[ ]+0f 01 df[ ]+invlpga +[ ]*[0-9a-f]+:[ ]+0f 01 de[ ]+skinit +[ ]*[0-9a-f]+:[ ]+0f 01 dc[ ]+stgi +[ ]*[0-9a-f]+:[ ]+0f 01 da[ ]+vmload +[ ]*[0-9a-f]+:[ ]+0f 01 d9[ ]+vmmcall +[ ]*[0-9a-f]+:[ ]+0f 01 d8[ ]+vmrun +[ ]*[0-9a-f]+:[ ]+0f 01 db[ ]+vmsave +[0-9a-f]+ : +[ ]*[0-9a-f]+:[ ]+0f 01 de[ ]+skinit +[ ]*[0-9a-f]+:[ ]+67 0f 01 df[ ]+addr32 invlpga +[ ]*[0-9a-f]+:[ ]+67 0f 01 da[ ]+addr32 vmload +[ ]*[0-9a-f]+:[ ]+67 0f 01 d8[ ]+addr32 vmrun +[ ]*[0-9a-f]+:[ ]+67 0f 01 db[ ]+addr32 vmsave +[0-9a-f]+ : +[ ]*[0-9a-f]+:[ ]+0f 01 df[ ]+invlpga +[ ]*[0-9a-f]+:[ ]+0f 01 da[ ]+vmload +[ ]*[0-9a-f]+:[ ]+0f 01 d8[ ]+vmrun +[ ]*[0-9a-f]+:[ ]+0f 01 db[ ]+vmsave +[0-9a-f]+ : +[ ]*[0-9a-f]+:[ ]+0f 01 de[ ]+skinit +[ ]*[0-9a-f]+:[ ]+67 0f 01 df[ ]+addr32 invlpga +[ ]*[0-9a-f]+:[ ]+67 0f 01 da[ ]+addr32 vmload +[ ]*[0-9a-f]+:[ ]+67 0f 01 d8[ ]+addr32 vmrun +[ ]*[0-9a-f]+:[ ]+67 0f 01 db[ ]+addr32 vmsave +[0-9a-f]+ : +[ ]*[0-9a-f]+:[ ]+0f 01 df[ ]+invlpga +[ ]*[0-9a-f]+:[ ]+0f 01 da[ ]+vmload +[ ]*[0-9a-f]+:[ ]+0f 01 d8[ ]+vmrun +[ ]*[0-9a-f]+:[ ]+0f 01 db[ ]+vmsave +#pass --- a/opcodes/i386-opc.tbl +++ b/opcodes/i386-opc.tbl @@ -2068,7 +2068,7 @@ clgi, 0xf01dd, None, CpuSVME, No_bSuf|No invlpga, 0xf01df, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} invlpga, 0xf01df, None, CpuSVME, AddrPrefixOpReg, { Acc|Word|Dword|Qword, RegC|Dword } skinit, 0xf01de, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} -skinit, 0xf01de, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Acc|Dword } +skinit, 0xf01de, None, CpuSVME, No_bSuf|IgnoreSize|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { Acc|Dword } stgi, 0xf01dc, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} vmgexit, 0xf30f01d9, None, CpuSEV_ES, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {} vmload, 0xf01da, None, CpuSVME, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, {}