From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80055.outbound.protection.outlook.com [40.107.8.55]) by sourceware.org (Postfix) with ESMTPS id 043CF3858C52 for ; Fri, 23 Sep 2022 06:33:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 043CF3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G9si5JKKFiFhJa6HAnpYRJ+k3TPpB/DBTX2ReH9Mm7wzqyJ3gGT623uTsUfwTgl7VftVgWI5oTero+rQRBbunjMhvZ7L3TaCwEPWVR3qAzxgetwTCLCIqFG4F8anAt50rb2Z+iUyDmkUbEAWBdfbtrUs+OL+/ArWTMOMAI6Jf0slipn6DT+RHJiyqdW3f0nmX3p/OwbGVvkpOjDvd+LeaEunw58Ym68nzvSXdRBTSPX85V1xG5Z6z7pKtlij52HMPPXiqV04iJo47n+UcGVZgi2iXsp9lZCsoPC+l/4kM/anZosUk0AE/+8E1SabsOj50SaL79lY9Uf5XRx4/ULAhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=85w0UbVFBlCP38F38jGVcHfFhB5ae/Z49MqX5hYcvDA=; b=nEsgPLB58Y/dJHEa22o0Hl2/BwUAgf5xjLchkVK54nncugpC8saUV5WX71aaZNdHhew7zNDQU6/DqvWu/lHJaz8IwiGncQZgid0tD5VG5/Tvorqa9REv39f92lGCFEHp2WD5Q3o0Y3N2HRij0uENGudNV3PaE/RVzpDMbioJ5+16oIHy1gOd2gRg2F8zAPwGVOCbxNwltCxnT2diQ/VYyKb/UbiVAyglz0UydmKxPoykw5attbPzJSWW8/df+vAEYvbr50DwtngQviY+2Pgs58KYNqkTao/H/CPBMwrwvwdHqnGJ68RF3HvQyEe4Owfm5Q5KBOM8zhb1EbWAGx+Teg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=85w0UbVFBlCP38F38jGVcHfFhB5ae/Z49MqX5hYcvDA=; b=G6YKo1tOWB8q/UZkchz4W7WfLYxigdOEgjZvWjBoPVG+jS2BnUK8RdYn7aJChrarPiWqeH9mQkRTe12S6xnH0cd3qmxcPgAwRncJAfiWBUTzdjjAL/3LUbjXQja2/p8Awdtho/N50J/0pTU1JSE7xTtcrI1WRfBfR5bRWFY/lCqEoNjQGJIUlcpvI2LxXJcPXLfgSNK2LlVwrCT5JP8U+/wjcyYgJueAhRi5aJQ0q8/jJs9oyNlZ/kJwBxvBAFs+VUpV7h+0t/wSXzAJ1dMC3D7w+ZJXnK+icaeWibolxEIlqR0YXjuvfil5l1BXgT4HEcjmqw++cm8Xnr4aSaN2MQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6966.eurprd04.prod.outlook.com (2603:10a6:20b:109::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Fri, 23 Sep 2022 06:33:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::358f:58dc:c0c2:1155%7]) with mapi id 15.20.5654.016; Fri, 23 Sep 2022 06:33:07 +0000 Message-ID: <07c50cd3-99d1-5262-b8d9-d70f9b0ae689@suse.com> Date: Fri, 23 Sep 2022 08:33:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Don't attempt to compress bss sections To: Alan Modra References: Content-Language: en-US Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0239.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6966:EE_ X-MS-Office365-Filtering-Correlation-Id: ed2f51a9-7830-4296-7f28-08da9d2d79ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v932+QT/NcafHcISL0GwZ1W5dZe8iEsojSOVfJjgPjsf5GzcwOGDN+aoHEkfqRBfQq4xjHv2Hdjv2naEEczgrM8jyecoRECQpm/CsOGYnIIK0l2zINKlNr5L60yoAsbyo9zt905F4J6ZCwOEP+IETMbJ+IldB423G5CqX/gc5P14NNPUcS7ABXPzdYlNFMMdIGoLOpKkiuQsj+7ACNz7EwybRFgosqjL+ds8+xqyg2c+J6CmLn7Hy6M7FHX4cB/4Hhwdkw3F0YRmHgGfJ1rcc154ENmm/BGjKBzij+GxP+8bys69+jvJroC+U1gTe9dbxUQhmdNY7gCrJi3o/JL5K8hjti4UX4Bewy5I3txhQ1xn+WCK7DKHfaHlAcHOfeVd4mD99fDKz5ajMo/HxIVobtGzJUs5qfzsZ1dVuf9OK6d5oD5iKfdJLrI8duVJVD4N/bPBGQUzQotbPbFJamTJ3l27yBFk9UE2MbEj26Tj9n2IW2o5jhkdVsS/XSOS29I/ycoJP7hcu3JMklx82oO8kcIVTEHr/h/c7hppnFFVObiClLnltkKMJWrvvlEyYu4cXVVvu+2x/27cMWtpZXrtiJ2cfFnN9ug+edL8j/ycO1drr19hGTEzcDIGgnlZFJ/9RBFp4aY7O4CMWo6r8FNQiVRKXMKei8pxia6d1adgktq7iVb1Cm4OQOTAGDnLW8nhPEeDkvr94Tcnq6beq0sw4n6SwcCDuE42xKqZu1Kppfu942LVe53blMAecaHH3b4vhS+JhzcZQ1w5Gwmn6EKI5FdnjLUBeU/3Y23hNiO0PMY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199015)(31686004)(38100700002)(8676002)(5660300002)(31696002)(66476007)(26005)(6512007)(186003)(316002)(66556008)(4326008)(66946007)(6916009)(6486002)(478600001)(86362001)(36756003)(8936002)(6506007)(53546011)(2616005)(2906002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmxIWjRVcHlKU1RUUGVQYmNLN1hOZWc2VVJKQ3JTYUx5SUxMMmVsRTlkUWZE?= =?utf-8?B?WElNaHBDZGJZanNScXEzVitVRk45QnpENlc3UVZjQStLbDcxbThFNjVsVDE4?= =?utf-8?B?NXNxUnJsU0phd2hCZHhHdm5sZHJNbU5CTmhpNjNleW5oMEVMekwySlg1UWlq?= =?utf-8?B?NmJiM3liMS9mT1Q4bEJzRkdnTGw3VFRXQVlMLzEvSEZ4M3NBQ2o4VWpydFpO?= =?utf-8?B?bStMeHlDVVdvKzZsV1lGV3pBZjJ4MjhsOGdkRGgvSGFxU0VBMXREZ2g3enZn?= =?utf-8?B?cnZvRUxqeGtpdjZPN2t4TVk3Z3ROSlgvSUlWQ3dpT0hCTXhnOUkybEp4U1pT?= =?utf-8?B?MnFtdE5FODVZKzNhT1J3elJWTG5WV2xQZ1NLck1SMlFLM05jVnUrajVoMGVB?= =?utf-8?B?MlFFaUcvSzAwYkFESFYxSzNEQmFHeXMxc0ZuUzBJeFYvTzhNWXozZWpXTHFG?= =?utf-8?B?S2E0ZUs4YU5MWDY0Tks3QkE4ZXJiWnZVMTZCSjdOQzBzeHZFM3QvKzdCM1g3?= =?utf-8?B?a2N5eWttWHNseExJZHREQ1ZBcE9RbXByR0lkWHhtZEE2RkNpcFdHazh1L0J2?= =?utf-8?B?TU4rZmpVeGdjYXdYNUVYc1ViVkZMT2NWVm1ielIyWXFNTTZqQWxiOHNnNVln?= =?utf-8?B?OVozQ2NmSmJIdS8vZWFvMWJtL2kwTGNOVEVvTUJ0dVFHQ1dGeUVaaTFiZzJ5?= =?utf-8?B?OFY1a25FOEZvNTF3N2ZFdFhVRGMrWkwxUDQ2RXlhS3FubjMxcXFMQXRCbFNC?= =?utf-8?B?aEc1RTJsdWZtUk9YVW50TUdDelI2U1REc0FPMEtRWG94cVdoZ1o5UFRheGpK?= =?utf-8?B?UHFVczJMaS9TbUkwOFJicDd6QUxZYmhZRkFRaWNVdEwrS3gxZW9WOS8yL1Er?= =?utf-8?B?b1JJbFBubWVLMGlQakl1RkZVVTFMRU5ZQk83Q0pwWHc4c1RpOC8yT1d2Zmdx?= =?utf-8?B?U0hUVGdnNTJOTDJZdEpJTWcrQUxVYXZhbTRjT1NhYzc4RFo0SnN0VlpiT29P?= =?utf-8?B?cHBGaU5wa3pWQitqVko5cTFsclFVckdUbDUrQWRYQi9tclNDTU5Lc3NnYkxi?= =?utf-8?B?VGMrZmErOUpxczFRUFB5eGZuUWFibG5QUFhoUHFVUU44Qk00THNxeGRJN1ZW?= =?utf-8?B?NUgzMzlJYnB1OTBUeXAxSHhoZm5jSS9CbHFHMHFjc3JIT1laNWwwejdMRUtW?= =?utf-8?B?L2wrNENpMlcrbDBFVUlCc0E0QU5WTS9ESCtqWHJhdTBQaUdWZHQyNnpmc2pL?= =?utf-8?B?a3JQQlNDRXlvVEJacGxqc3psVHdlSGVudThteW5HcjFvUjEyYjJWOEx3cmRa?= =?utf-8?B?UWpjSEUvM0REeWNXUm01RHRrNmtpTjNuWWdNRUJUK0VYTFBRd0daZUlwZERs?= =?utf-8?B?Z0FraGNvd0NpMUEzUHpZMjJSQVBMZjNXQ2x2WWtXY095eW1DaXJrbnFNYlFm?= =?utf-8?B?U05UT2xmM1ZQeFA1dkxEV3ByaGFEb3dFcVoweFdQRVBKWm96M1A1M3F0TitD?= =?utf-8?B?YXA2emRuVWUzbFNPSFI4WWRHMXhVZjY3TEZwbitRdndSdUZCNTl5YnJyRm1Y?= =?utf-8?B?TnVlbGpiVWtxNEJZTjlIWDB4NXYyUzRHY0hidW5tVFB1VEdyRWdOcEJheGhE?= =?utf-8?B?SE9TUzA0N0pCb3NGaEE1VUdJRlpqMm5iaDZ4QlZRQUpXRGFzVXI5VEk2cmpS?= =?utf-8?B?bFJHclBleGZxUFVidmIyQ2sxdjNKWndoT2lod2cxeE9hSlZlbldEMEcyUjRH?= =?utf-8?B?Smg2ZVhpRXQ4Q2hnQUlaZWZlZDVHV0tocnVHbFhWeGMrM2hrWEViZUZJd0lj?= =?utf-8?B?YmVJMkVmMG1ZSy9KNWQyWnBTWW5jV2JTbGw1MWdzMEZLbGRaMHdMWWxTYUhQ?= =?utf-8?B?NENCamRFYi9QS21CR3oxWFhHRHl6d0ExOG9XM2p4clhjWDE5TmNibSsxUjl6?= =?utf-8?B?UFhnM0xMd05jendNL3ZFKzQ3YlZBSkxnZmlWeEFEMkVXL2dUUTVaT01BWDJP?= =?utf-8?B?cjhYNFQrU3U2SmxYZHQyWTdtd1JvQ3pMVEtRUzBkVlpjSlREOU0wWWQ5c1dz?= =?utf-8?B?U0ZqbEZpZ01qcUZkZ0J3TlNsT0VpSVNMRGpKbmV0djR6ampOeTNxa1NkYUVP?= =?utf-8?Q?TA8HbO44JILSlIuCEbnoVBFGJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed2f51a9-7830-4296-7f28-08da9d2d79ad X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 06:33:07.0442 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Di37IZt2EH2Eo+CCP7jGzLdcKy70vCBp1tnjx9q99UkjVTsVRW30HoeJaX9V8Nxbe/g1KalFXqHQCL7Hf+kcSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966 X-Spam-Status: No, score=-3036.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23.09.2022 04:26, Alan Modra via Binutils wrote: > It doesn't make sense to try to compress a section without contents > since those sections take no space on disk. Compression can only > increase the disk image size. > > * coffgen.c (make_a_section_from_file): Exclude !SEC_HAS_CONTENTS > sections from compression and decompression. > * elf.c (_bfd_elf_make_section_from_shdr): Likewise. So I'm curious - are there debugging sections without contents? Or is the change more for the sake of documentation? Jan > --- a/bfd/coffgen.c > +++ b/bfd/coffgen.c > @@ -146,7 +146,8 @@ make_a_section_from_file (bfd *abfd, > > /* Compress/decompress DWARF debug sections with names: .debug_* and > .zdebug_*, after the section flags is set. */ > - if ((flags & SEC_DEBUGGING) > + if ((flags & SEC_DEBUGGING) != 0 > + && (flags & SEC_HAS_CONTENTS) != 0 > && strlen (name) > 7 > && ((name[1] == 'd' && name[6] == '_') > || (strlen (name) > 8 && name[1] == 'z' && name[7] == '_'))) > diff --git a/bfd/elf.c b/bfd/elf.c > index bc433cf516c..16cea4f8aeb 100644 > --- a/bfd/elf.c > +++ b/bfd/elf.c > @@ -1201,7 +1201,8 @@ _bfd_elf_make_section_from_shdr (bfd *abfd, > > /* Compress/decompress DWARF debug sections with names: .debug_* and > .zdebug_*, after the section flags is set. */ > - if ((newsect->flags & SEC_DEBUGGING) > + if ((newsect->flags & SEC_DEBUGGING) != 0 > + && (newsect->flags & SEC_HAS_CONTENTS) != 0 > && ((name[1] == 'd' && name[6] == '_') > || (name[1] == 'z' && name[7] == '_'))) > { >