From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id C564A3858C60 for ; Tue, 2 Nov 2021 08:11:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C564A3858C60 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2052.outbound.protection.outlook.com [104.47.4.52]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-13-JEhtRNqXNwmQle4enIABQA-1; Tue, 02 Nov 2021 09:11:41 +0100 X-MC-Unique: JEhtRNqXNwmQle4enIABQA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nrskw/IVGOsv/wCoIIbijS3VRZSOFAL0zPIq4m5B+cGhofFDRaHC4Ji5IS7kzxdBClKR8jMnEWAnhDUhjFoeC7EGL6wXthE4RPG4mzzwzMU35pejNSXlwOInZtqbJSqpLIQ+qhJqdffT5+vqSlLO/dZZ3viBFZVi4P7fzPmj/Vcmabo+3YKDuJUw9/aytuWEVz9Xf7AvFrcTWrEepUgh5nP/8pQd5bIV36XyjsHHNW4vIStVtbDRfnc+nqSaU/xOX6a6xNjvt0PJ0KCQFKthDvx4ZIi8okdsByjEbFqaF3P5Xjp12AGtvHposJKp86L6WF6fTTeg/ZHsDHvdcPwepQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MReCfvNwMjxi2aWSX9pRTewHX+KEvfGL7+XVQOJdUnE=; b=H4U3jIuxYdxtbPkKLYPyLpmn/KWsHppvB8iySVUZiMhIMNoqHc8f0golk07yrE2VESCFPJ/+KKcz2KVDEasTgJN/6MyHTOXgbZMJr2F6DsHUEatcwm5rfYE7ExQx70XVYdjBGj0hdv0KNh/E3gcyDJo6LT92PSde+Iv+Fkua6/N/Nsl3Pqx31iF5iC/euWSA8Join6bt3oRtVqTw1AlgCfUPeczlt+chiTcgpb0fvnPk7PSkXqjLXw3FqlopBz/daz0dTBdu1SdaVp7/GCwtSiINfpVX1Bbnlqxqfu2TKQdPy+pBJjmP8ZZ+ARMTcHdiquqJKoKpT0Tzm3L87Nq3Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3534.eurprd04.prod.outlook.com (2603:10a6:803:8::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17; Tue, 2 Nov 2021 08:11:39 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::8062:d7cb:ca45:1898]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::8062:d7cb:ca45:1898%3]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 08:11:39 +0000 Message-ID: <081c7dfc-050b-fde1-233b-a993988c6040@suse.com> Date: Tue, 2 Nov 2021 09:11:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] RISCV:Create zmmul extension Content-Language: en-US To: shihua@iscas.ac.cn Cc: cmuellner@ventanamicro.com, jiawei@iscas.ac.cn, anku.anand@gmail.com, kito.cheng@sifive.com, binutils@sourceware.org References: <20211028015426.1501-1-shihua@iscas.ac.cn> From: Jan Beulich In-Reply-To: <20211028015426.1501-1-shihua@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5P194CA0002.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::12) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 Received: from [10.156.60.236] (37.24.206.209) by AM5P194CA0002.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend Transport; Tue, 2 Nov 2021 08:11:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9328e02b-b0cd-40e5-aab8-08d99dd865c5 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3534: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:126; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W44Boj523t3s7ypqMXAKKRy/fUdsx0CKB+Y0lfYEWw31TqePq6I03CHtPtbrX87q9DSOwo23yBgxTig4Nyv7MJ1vaaAMHT7pQ4dKpsWQB78SXXJRZMnozvQzTv0UmqE9aFNGMw89NivxWgRjGHtJjrSrOkzt/jY9RWzAiI4MqD+yfm+Yb9tFpRU00H/LupcAYSwWwKGqbNvUkWw6i6idCuX50svNWKnH+KK53NlXXzSlZOSEuqjxkB15pd3lKPpb4ZoSeaqbtvl87SQ4+wN/pwtGMBHzFvqQAkM37vSvOL3CO9+TkFHdsdfWR2HhvsV6yv44IHuvw0Hz2NGhEzC7IT6ORfslAtJbIkINf+84H3uyn/x/CleJ+16ZlKLgNOFVmVUz7/k8y9pMCywbhU6ef2ipaG3YbKsVg/KCSKjjBlWtNsLmFlMUOZKd/P/Hqj7TfCuvIxVeeTYW3aGsH0mDQvnkIihrh+HvcVA2WeuTvZHGrJJ4N1AEoauyTQEm6jh/pm2NmbI05SYAgHUKqpoSxiH5tIZ50kjGHU30x7ry+W6XGWIyTbWYvrC6+BNXlCsY0e1NVmQJsNCOC0Giyw+SQWpaVWUKrUxA3UxYgMI4Y75U7zSEDAzDZnW4wB3ij9uVC7B9MwkYBw3bFysqKpp9K08O3/xyhqz37o3UcOmymwakT2QGVJmNdzaSlVBUQinCj+nXIANOsLfqbVsuUXhEZnOMZTR5PR85Jub4Uuc8mnk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(316002)(8936002)(53546011)(26005)(66946007)(66476007)(66556008)(186003)(4326008)(31696002)(6916009)(956004)(6666004)(2616005)(38100700002)(2906002)(8676002)(508600001)(31686004)(36756003)(5660300002)(16576012)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUF6L0ZlNHJQYjZhakRuVS9weW1aeGdHSkt1UlRBaUhBMmNrdk4xSmhGSDlv?= =?utf-8?B?aVdpT2ZQU2RtZDNaRU5ZN1NrS2tjQ3doMTlibyszendTVldxSVdxWlNoMkJn?= =?utf-8?B?VUIrTG1DazJ1VDJ6L21aQ2wrNkVxNEd6WW56eWNqT3VHQld6OS91TWhhZ3VM?= =?utf-8?B?RERMUHlWcllRWjlIMFYvanlCUDVrMVdiVU9OenZjQVFTN2VGam9lZGNlKy90?= =?utf-8?B?Q1gyMXFGcGN6TzNldzZuOGdMdk1NVW5hdGtMaTdkb1R3REJ0S1BVcFI5SUts?= =?utf-8?B?ckV2UkhtUDBwamd0a2pBcFV3bVMzei9ZdkcxTG1BWkI5WS9NTEtHdjdsbXpu?= =?utf-8?B?OXRSbDk3blJpeWFXY3VyUFV2TG5LN0ZrR0pyMVpkNi9saDF5a01oR1RscmFE?= =?utf-8?B?TEJ4bFpCQkg5WXVZZHR1TE9Ec3BlbjRxQUgxclJhWWgxbEo3TTA5d0p3SDFq?= =?utf-8?B?ejdlL1Y4NDdTMmRpLzZzSU03bVBuQ2g1YklqTUp1UWRMMWlRMGFTM2JNWmRr?= =?utf-8?B?ek5sRUZ1NGJnNW1rbG9nY0hHTlRUaGJ0eUR6Y2Z1dnRkRWhoM3VuVVkxR2lW?= =?utf-8?B?bzFaWmp2VmJQZHRwU050YkdhTG9FS250TzlFRFRxZW1kRnlEUWNQL0hNVGxs?= =?utf-8?B?eE83TlVKbkdGUE9MYnVXbnpIZ2h3TkhLNjJ0Ympac3RQQnJpVE9qZTNXUkd6?= =?utf-8?B?VFZ0K21FMHVkcS83TWlnRVczZlIvZ3NRVjJFUDJCbXJScGNiUmZXYjUxU0k5?= =?utf-8?B?eDFUOEp3ZkNFRmg1TTNMUmdEZGRJY0RnaURnSkJtN1dPVTVBZDZYWDgzS0FH?= =?utf-8?B?UVl2NGZMWXZZbUw5OWtLVmQzV2Jkb1dtSEY3OGlHeU05eWhvRzBaaXlUY1pk?= =?utf-8?B?Q0x6ZnFyZmVlSkhMZElSUStiVDlJM1hGY01HN1lXLzBGdGp0TTF2Qi9qVjRr?= =?utf-8?B?ZENxSG8wTTQrTWJHdDlzL3lIZy9Ec3ZUMFQzYXMxQkdWMXZDalRrYkgwYXJW?= =?utf-8?B?cUJib1M4dUtESXZ4T2llUU9ENllqNjRkbGFVamlUb0x2ZlBqcm1neCs2ZE8w?= =?utf-8?B?UkNpZlh3R1ZKY0xuRkV1QnJNTzFPVXpGbzlVN2tqK2pHbE9VN1lKd21UN2Zv?= =?utf-8?B?cDgvejhtWHNyeEFmMkY0VGwrOHJtSSsxZmlUQ3pJaDZEVkcvcnNIQlZmSjlz?= =?utf-8?B?MEE5c1NZZlpwdnJFeWRMOWw5bXFUZ1pqejY5MElsN00wNlNsZm00SWIvUTd1?= =?utf-8?B?K0huaXlVbEtvdE4vV1ZEcW94cVJQWVl5anZnK2lMem04ZGRXUEpTai9zeUFS?= =?utf-8?B?RHNycjM1UTNHRVFuS3RpcDBGUlQ5b2Q1WC95UnMyN0FPR1hOcURLMll1TGtH?= =?utf-8?B?TGhmNkpHVjZ0NG1yb21zRFdnS0o1a2ZaZkdlYTZIbnBGSVNZTWdnanRXUVYy?= =?utf-8?B?NU5FUWp0ekg0bWljcWZuSU9zQWJZeFRWVjIyOE9YQW5yZHJOMkNRSlJYcldl?= =?utf-8?B?UXAvOFhxb1hOSEtTRHV5ZEl6Umd0UG5tc0N0bEFOWDlycnBJa3NaZnNFU3hQ?= =?utf-8?B?dmdJdUhXL2ErK1FNMGx1b0tOZitaeVptOHJyS2RGb1dqK0lTbEZKbTVZdUsx?= =?utf-8?B?MVUrcVNkZHhPampMRVBobFI4WHNZRnpOR2ZXa2ltamJYYjRJVUNjV1ozWURW?= =?utf-8?B?T003UTZ3YmRtNnFoK3JFYzBjM1NpelNHSlNvNUN3aVN2MU9UN1g5d2pxbkZB?= =?utf-8?B?RkVhbCtZZWtnbGh1dGRQQXZJc1gvSnZVN24vOUZwQ3Ewa09iUDJOQ3B4VUlx?= =?utf-8?B?WndTQzVDOGR2SU4zUWpqOUtUQkVoSml6RURJekdoVmhkUkRGZ2puWlpSenJz?= =?utf-8?B?NDlobzArZjRuWVBhRjVzY0FLVXJXS21SYkVISnZ5bU1DaVJ1YWU2cWttMHgx?= =?utf-8?B?dGtIbmUyRzhySkt2enhhU1ZmTHdmSnhqS2VoeEdMZHN6eUp4Mk44bm03R2NX?= =?utf-8?B?a2hZdG1uWklFWFhxaHdGcm1NMjB5OGpuM1lzbXc4NUlIRU9EcTdLbklxV3ps?= =?utf-8?B?SVVhZkU5MjFWVHFLR2plUm9oeFU3Mk1ORjJ5N1pjcVdsUSs5T3ZSVWJENXlP?= =?utf-8?B?MFZtYjk0TW85TFpXR2ZqTVVUTm42L1hnU0dRMGpJUWMyRzE4OWNRc2N1dFAw?= =?utf-8?Q?gaZQNxqUZvBZkNSG6bRtCJo=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9328e02b-b0cd-40e5-aab8-08d99dd865c5 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 08:11:39.7214 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7s8IaufgSNVcWzXPDgUG+Wrq49A5xOQtk4BQ6tpCKwJvNiRWZJH/xUZEW2+zujrHXpuRNvZSl0c45m9MBjmwJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3534 X-Spam-Status: No, score=-3033.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2021 08:11:45 -0000 On 28.10.2021 03:54, shihua@iscas.ac.cn wrote: > --- a/include/opcode/riscv.h > +++ b/include/opcode/riscv.h > @@ -319,6 +319,7 @@ enum riscv_insn_class > INSN_CLASS_ZBA, > INSN_CLASS_ZBB, > INSN_CLASS_ZBC, > + INSN_CLASS_ZMMUL, This being enumerators I don't think you can ... > --- a/opcodes/riscv-opc.c > +++ b/opcodes/riscv-opc.c > @@ -489,15 +489,15 @@ const struct riscv_opcode riscv_opcodes[] = > {"amominu.d.aqrl", 64, INSN_CLASS_A, "d,t,0(s)", MATCH_AMOMINU_D|MASK_AQRL, MASK_AMOMINU_D|MASK_AQRL, match_opcode, INSN_DREF|INSN_8_BYTE }, > > /* Multiply/Divide instruction subset. */ > -{"mul", 0, INSN_CLASS_M, "d,s,t", MATCH_MUL, MASK_MUL, match_opcode, 0 }, > -{"mulh", 0, INSN_CLASS_M, "d,s,t", MATCH_MULH, MASK_MULH, match_opcode, 0 }, > -{"mulhu", 0, INSN_CLASS_M, "d,s,t", MATCH_MULHU, MASK_MULHU, match_opcode, 0 }, > -{"mulhsu", 0, INSN_CLASS_M, "d,s,t", MATCH_MULHSU, MASK_MULHSU, match_opcode, 0 }, > +{"mul", 0, INSN_CLASS_M || INSN_CLASS_ZMMUL, "d,s,t", MATCH_MUL, MASK_MUL, match_opcode, 0 }, > +{"mulh", 0, INSN_CLASS_M || INSN_CLASS_ZMMUL, "d,s,t", MATCH_MULH, MASK_MULH, match_opcode, 0 }, > +{"mulhu", 0, INSN_CLASS_M || INSN_CLASS_ZMMUL, "d,s,t", MATCH_MULHU, MASK_MULHU, match_opcode, 0 }, > +{"mulhsu", 0, INSN_CLASS_M || INSN_CLASS_ZMMUL, "d,s,t", MATCH_MULHSU, MASK_MULHSU, match_opcode, 0 }, > {"div", 0, INSN_CLASS_M, "d,s,t", MATCH_DIV, MASK_DIV, match_opcode, 0 }, > {"divu", 0, INSN_CLASS_M, "d,s,t", MATCH_DIVU, MASK_DIVU, match_opcode, 0 }, > {"rem", 0, INSN_CLASS_M, "d,s,t", MATCH_REM, MASK_REM, match_opcode, 0 }, > {"remu", 0, INSN_CLASS_M, "d,s,t", MATCH_REMU, MASK_REMU, match_opcode, 0 }, > -{"mulw", 64, INSN_CLASS_M, "d,s,t", MATCH_MULW, MASK_MULW, match_opcode, 0 }, > +{"mulw", 64, INSN_CLASS_M || INSN_CLASS_ZMMUL, "d,s,t", MATCH_MULW, MASK_MULW, match_opcode, 0 }, ... combine them with || (or | for that matter) - you effectively produce INSN_CLASS_I here afaict. Jan