From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2056.outbound.protection.outlook.com [40.107.104.56]) by sourceware.org (Postfix) with ESMTPS id 795DE3858433 for ; Tue, 1 Nov 2022 06:50:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 795DE3858433 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XrhF72Vm2DfWkBB6lz5JV7+WxPeS8ftt29UY4uMz/lIBAER43TdKRWMizrAH8+WCDQnbnYW4+Qs85cB1CtE1996ebMT8IwTCLF67jsMVicKiiwMX5eqBV3u5gh+rIf+6Uej+15xHuelZuISwEYryaq7GIQDM3wkae7zyBSxzYvedVa9dA4pyQ2jLvGYy+eIbq6RAUevafBofLOL0IEkRqJJLYyygMadxDIs6F073SmWA5vSHj+gecvwTF2njxE/2BNFZ6Y3RGlkQUxD0f1v0HiNLJJgcFJkSXUo/0zmQNyg6gHZOVrelYxbiXbNgl1FCUDq9DKRHhzwywciiNyNdeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BCAUQAd/KdRn8cjsdTX6JXQYSTX5hAUOgryF+kr5iBg=; b=h4QRYyKQR/rEwdCcpFFRsiTJb4wy4NSBHgamkedH0TAA2KYZAkxs7uien250a5LjA6UTAT8ZgrZwQDgz6nJh5JQJW2L92uTAaQ0g+vurRD6MmE3Nm89MJmxHOFjSpnXQ5EqjPz4m1Evxqh7fs/Rk+ZJrkKBi1oiW1S+9h8wrI7vLy6B9jpeW+d+Kwik12XYnMT+rT0X01miCvnGZZnFLo8CCQq/sgjj/ty+uIol9V/d8aRChKmEl8JMQWIpdZVBbVD5uCNsLDMlaRZ6WnYaO5VRrgtt8/N+mm5jl6Dv7AQcHbfY2WUxqezUc6B8phATycM2jfHBoPYJGjHEPELsAlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BCAUQAd/KdRn8cjsdTX6JXQYSTX5hAUOgryF+kr5iBg=; b=4IOGSIBXan0fVoYpMGOSVZeO4pYQAhQ4z8/LcWk5TtzNHbHW/J2a4byD6JvWnfqFBDvmRKmFyJpKTZXTY1hqZKKdUUlM1qsWypNy8lSbrgSpV3AcNmYaoEsYO8BNKNnmgU4i7UBboe5//zoESzkE/9kRN1sCYAGD9zhAxQSBFhfrSj/GdhKGS21X3ALe08e0OZ4FNWn4qn5S3oQ02mnQWFW+NWWB9rS33wjDVduB2sx8TOcbgWC4fe9mfbs3/uE8HKbprLiO4qrXuWOrgT9TLy27/BYG9SgZvfDD7NATBKQidHUwtILlWJwfW4DKaWyDndjsQbe+3U0PCQx6Exr3jQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8202.eurprd04.prod.outlook.com (2603:10a6:10:24f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Tue, 1 Nov 2022 06:50:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 06:50:35 +0000 Message-ID: <086f787f-e886-ab4b-d8ed-4100f5bd3f8e@suse.com> Date: Tue, 1 Nov 2022 07:50:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] Support Intel AVX-NE-CONVERT To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "Kong, Lingling" , "binutils@sourceware.org" References: <20221031060601.38460-1-haochen.jiang@intel.com> <20221031060601.38460-3-haochen.jiang@intel.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0028.eurprd03.prod.outlook.com (2603:10a6:20b:468::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8202:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ee5d163-4f9c-403b-e565-08dabbd560c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +6T8lsfTOBUYbegwbBr/XfY6Ta3m6q7cMW3oMyKiScpa61W0XBn3dC4lctSm4YPFxlOW1Oo8Wj9sEJB8EQ5ITaNnRXtjNnxARUhrZxAHMP24mE3TE0RL1ovtHy5PBpYqhfHGYM/V9jRMCix72FU1XyY2B/QB5iGvOgpt0aybb3HVPdbo53At9hTYi/B2oyJ7xpDFS+dSPDB3oiXXyLS5Xa4NMU4B5jbjyd45gFMUgz+qICPaNt9mi9eJE84cCBDvd0z7zF2oMI/FsiiGKqTLmnarCYlACUIYGAaywKzvGmv75kFmUfg8P6IRTwNtQV6r1tgg7rHkK2Vhy/zy6vvUY86Nf/3N/K43wqnbO0Owp1RtJrEawMVHCqomDkMTIp85FxCOjTITV8zeLL+jUeKGCRYT6RMCeuOnbG5SetwgeJa87GZULTGi0RxR5k3M4Q2rw1IxRNZr6XiLK09SqzxWy/xay0DNokDuj8rk7O8JAgvXntgWQ6w70DKldQJKYvaU6yM3S0uCC4Bcc3P5QBYmzIMbpKrr/si94ihGok+/9OoSRXeWLlkJ7jp05ncr9ws4v3DIlHHhM28e5uvjdR3oRxM0nP+u9WRS7S9kmD6mDzEAPLFnP9oE9zBn9mk81b+HEK29GTvhvyaOvED0SkKSThmo77B16Tb/rTdvp839HH+SegzJy4Fu20zKdHBrGRTbPANoUCrO1CLRtiRC6H2JoWvZCK4vAQ1/o22ZiWhWYfoTH+jPlkVhTACgCtW/UiaoQF564FFGp8uvVdeXSS99Zw9n/Nk9C166rbfiqyaQIaU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(39860400002)(136003)(346002)(376002)(451199015)(86362001)(31696002)(478600001)(6486002)(54906003)(316002)(6916009)(41300700001)(8676002)(83380400001)(53546011)(6506007)(66556008)(66946007)(66476007)(4326008)(36756003)(8936002)(6512007)(31686004)(2616005)(38100700002)(5660300002)(2906002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0VKUWRVU1VWV243QVZlNnpSdHZrTW4wTlJFV2RqRlhXTDk1Smp3WDByTXdu?= =?utf-8?B?WFpYWThvUFp6VDAreTJsMG9vOHYvN0JtVGt6ODc1VTVxU1NlUTltSThXMVc5?= =?utf-8?B?QmVleURvVVVneVgxR1lkYXFPaEZYZjdlcXhCMGx6dFFVSWZHeFpQSTFvWkZB?= =?utf-8?B?TEFLZHZQa2VJaU1hTnJWV2VaNDVwa2Vhd0lHQkxPYjNGUFhyWmJBK2NyVU5o?= =?utf-8?B?MkltRnpMN1BVZE1OVEkzOU1HNnFWTTRuY3NES0lMNjBpVWNWeXFOck9uYitG?= =?utf-8?B?bHYwRzdVN3dNOGw2aDZtZDVTL0VteDE5RnJFMDBtNFJBWE5ZdU5LTXVacG5V?= =?utf-8?B?ZjdVTzUrQ1lVWGNyYXJjWFdHUHp2UlROZW9EWHNoTC9YRXhkdUVraHFGUGhD?= =?utf-8?B?OEVqL2ZCY0hvNkozSTRKZmhJOVdSd0NUUGxaVjZYbnB0V2FySjJmaGFNS3JI?= =?utf-8?B?L2lseDRzK0Z4eWE2dzRTT1N2S00zUVByci9uV1pHb2sxNVo2SFFhT0s1ZU12?= =?utf-8?B?TzM2RWw2TTRTdjQzMVgxQ1drTmFNdlNzdWRIYzFyRnUreExacGU0YzN2clBX?= =?utf-8?B?Y05tYS9xd1ZGVHJhT0ZiK3I1bXB1cGN5bUtzdUpqeWYyVlc1dkNkMGVYZ1JM?= =?utf-8?B?NVAxZ1ZDRWpQRGc2eGJwM1k0d1dLUDQ3a1BtbHUyTjYyd0Z2aHdySUg3K3h0?= =?utf-8?B?TEZ4cmtaeGlOanYyMzI4cXhUMzZqOGgvNi9uYVZJMnIzNTVtVDYxa2xnWmhI?= =?utf-8?B?THJBcEFrcFcwR1NyOHZHNGw2UDlDdnIvN0Z2bHlBQUNNYUVMZUpXQllRcll0?= =?utf-8?B?TkFWSTJuSnRRSnFhREdma2dwS2J0VjBWME1tYnk0SFhXUFZxZTVESE5pRHU1?= =?utf-8?B?U3JjZ1dpVjFSY3N0bW13dWxYZi9FdS9SZ3dqL3VVcmVpQk43Q0xXdVpCL0Z2?= =?utf-8?B?eHNjaksxK1R3ck1hKy9IZ0tuZlY0RS84bkx1UTFFMUhhYUVLZ2JsSE1UTVZN?= =?utf-8?B?QkFKbTFSWmFQV0V5MW15ZVpGQnVwb0pzc1JiWG5YSURFVUF6UEVvdFphOExl?= =?utf-8?B?T2JreEIzUkw2SjVYTDdYMjdzcWdNUEw0dFBiTE5vVXZTeUpid3R1TjAzendH?= =?utf-8?B?dFdlazBoMEdMWERKVXUyWnA4eHByY2V6V1FOS09uTVdJbHZjWFBwRnRVQ0Vn?= =?utf-8?B?UFlJRXJTOVdJaWNabzRrNUgzc0xpUGJEcFg3UDR1emJZS1RHT3VibVAyeXlp?= =?utf-8?B?M3MyMFZ2czduR3BLak1KYUlSSWhqTFFnL2M1eUV6N2JKMUxGYlpzU3RVREx5?= =?utf-8?B?U3RoZEJyUjlHUFJZckozdzQ0eWZDbG8wSUFBS2I1VXFZc3BiTWZSMXVsWFVG?= =?utf-8?B?cXZPZkc3b096NTJqMnBQNndnbXVPQU9PR1hvQVY4eDRHTXhDaXd5dUlEdVUv?= =?utf-8?B?VDM1b05YSnlXT0oxZWd4elhRbnFPMHlKK2x3Unk3MFh1aDRCNGxiTVlSKzEr?= =?utf-8?B?YWI5YUVzR01URURpd0E4c1pnaXZNMmFMYnQ0WTc5ZGhmMHVmdkVneHViUWVm?= =?utf-8?B?cmNTb0dsQWwvSUErR2JaejdrWmZReDJNMVlnZ0xQZGZWSjN5M0NyQTBvRVU5?= =?utf-8?B?bWlOOWRiY3dld0x3UGhoL2grR2FZYzM4WDZrZFdZZmtpU0ZWZkhnZExRcmJi?= =?utf-8?B?SkpyNTlVTTgzcXVtbnVkUFd2S3doSlY2KzBkaDl5TUwxVGQ0UUxEcG81eE4w?= =?utf-8?B?aCt3RVNhaWVZQVRRbGdzMEUxOW0wbzFHeGlGYlhqa0lFZFk5UHhpWHR5NG5o?= =?utf-8?B?UjRMYmZhSHVsRVNSbXFySVZoelhQQ0ZiSXFTRzlJc0hvVTRoVHBnTHV6eVM4?= =?utf-8?B?alZlR093QlYwYTQwcnBac1JkY2lLVllQeks2d1pMdzRhazJkczNLMHdJaFRW?= =?utf-8?B?dVdlbjZNRnlzdzZ6dXQ2dUlhN0xxUzNzMy9RVU1lenBmbk1HeUQ4cjgyQ0dq?= =?utf-8?B?Wjl3bDEweVA4QWJQMmRvMmRWM2R2MU5oRjl4K0JhZmttY0JnaDJtZVVCV3Uv?= =?utf-8?B?UTc5bXRuT0RtdzNDYno0bFF0dzJUQzgvZWRScUVibXhFR01pVEFXR2owWXU1?= =?utf-8?B?b0N6VSsyOVdFb2tuNGVTT0I3UWlYalRpUkRxcE1PNTRLWkNvSUdRQms0cXZP?= =?utf-8?Q?eCsbaj7WczFkafmD8gdIOi+1hIjTxIbZxhGQJzSna9ZM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ee5d163-4f9c-403b-e565-08dabbd560c2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 06:50:35.4816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V2jG8nGoQLNMn4T+IBH74kIeRvYrb9DnadF72t28i5PsH9pRcHmbxsR5pafnXQ6+m9Rohh6IvqUBEN0m7KBV8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8202 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01.11.2022 02:24, Jiang, Haochen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Monday, October 31, 2022 5:15 PM >> >> On 31.10.2022 07:06, Haochen Jiang wrote: >>> --- a/opcodes/i386-opc.tbl >>> +++ b/opcodes/i386-opc.tbl >>> @@ -3056,6 +3056,18 @@ vdpbf16ps, 0xf352, None, CpuAVX512_BF16, >>> Modrm|Space0F38|VexVVVV|Masking=3|VexW0 >>> >>> // AVX512_BF16 instructions end. >>> >>> +// AVX-NE-CONVERT instructions. >>> + >>> +vbcstnebf162ps, 0xf3b1, None, CpuAVX_NE_CONVERT, >>> >> +Modrm|Vex|Space0F38|VexW0|No_bSuf|No_wSuf|No_lSuf|No_sSuf|N >> o_qSuf|No_ >>> +ldSuf, { Word|Unspecified|BaseIndex, RegXMM|RegYMM } >> vbcstnesh2ps, >>> +0x66b1, None, CpuAVX_NE_CONVERT, >>> >> +Modrm|Vex|Space0F38|VexW0|No_bSuf|No_wSuf|No_lSuf|No_sSuf|N >> o_qSuf|No_ >>> +ldSuf, { Word|Unspecified|BaseIndex, RegXMM|RegYMM } >> vcvtneebf162ps, >>> +0xf3b0, None, CpuAVX_NE_CONVERT, >>> >> +Modrm|Vex|Space0F38|VexW0|No_bSuf|No_wSuf|No_lSuf|No_sSuf|N >> o_qSuf|No_ >>> +ldSuf, { Xmmword|Ymmword|Unspecified|BaseIndex, >> RegXMM|RegYMM } >>> +vcvtneeph2ps, 0x66b0, None, CpuAVX_NE_CONVERT, >>> >> +Modrm|Vex|Space0F38|VexW0|No_bSuf|No_wSuf|No_lSuf|No_sSuf|N >> o_qSuf|No_ >>> +ldSuf, { Xmmword|Ymmword|Unspecified|BaseIndex, >> RegXMM|RegYMM } >>> +vcvtneobf162ps, 0xf2b0, None, CpuAVX_NE_CONVERT, >>> >> +Modrm|Vex|Space0F38|VexW0|No_bSuf|No_wSuf|No_lSuf|No_sSuf|N >> o_qSuf|No_ >>> +ldSuf, { Xmmword|Ymmword|Unspecified|BaseIndex, >> RegXMM|RegYMM } >>> +vcvtneoph2ps, 0xb0, None, CpuAVX_NE_CONVERT, >>> >> +Modrm|Vex|Space0F38|VexW0|No_bSuf|No_wSuf|No_lSuf|No_sSuf|N >> o_qSuf|No_ >>> +ldSuf, { Xmmword|Ymmword|Unspecified|BaseIndex, >> RegXMM|RegYMM } >> >> There's still no CheckRegSize for these last four. > > Sorry for not mention that. I checked code and I suppose if we are using one > memory operand and one register operand, CheckRegSize seems like doing > nothing since the check function will return 1 for memory operand. A comment ahead of the function specifically says "Some Intel syntax memory operand size checking also happens here." And as I've said earlier on - if that for some reason doesn't work here, it needs fixing. The only criteria that's relevant here is whether mismatched operands like in vcvtneoph2ps xmm, ymmword ptr [rax] vcvtneoph2ps ymm, xmmword ptr [rax] are properly rejected. Jan