* [PATCH] Remove extraneous parentheses in arm-dis.c
@ 2019-06-04 12:22 Alan Hayward
2019-06-04 13:26 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Alan Hayward @ 2019-06-04 12:22 UTC (permalink / raw)
To: binutils; +Cc: nd, Alan Hayward
When using llvm as the compiler, it errors with:
error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if ((Qd == Qn))
opcodes/ChangeLog:
2019-06-04 Alan Hayward <alan.hayward@arm.com>
* arm-dis.c (is_mve_unpredictable):
---
opcodes/arm-dis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index 0503d9365d..03aebb571a 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -6619,7 +6619,7 @@ is_mve_unpredictable (unsigned long given, enum mve_instructions matched_insn,
= arm_decode_field_multiple (given, 13, 15, 22, 22);
unsigned long Qn = arm_decode_field_multiple (given, 17, 19, 7, 7);
- if ((Qd == Qn))
+ if (Qd == Qn)
{
*unpredictable_code = UNPRED_Q_REGS_EQ_AND_SIZE_1;
return TRUE;
--
2.20.1 (Apple Git-117)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove extraneous parentheses in arm-dis.c
2019-06-04 12:22 [PATCH] Remove extraneous parentheses in arm-dis.c Alan Hayward
@ 2019-06-04 13:26 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2019-06-04 13:26 UTC (permalink / raw)
To: Alan Hayward, binutils; +Cc: nd
Hi Alan,
> opcodes/ChangeLog:
> 2019-06-04 Alan Hayward <alan.hayward@arm.com>
>
> * arm-dis.c (is_mve_unpredictable): Remove spurious paranthesis
Patch applied.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-04 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 12:22 [PATCH] Remove extraneous parentheses in arm-dis.c Alan Hayward
2019-06-04 13:26 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).