public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Dmitry Selyutin <ghostmansd@gmail.com>
Cc: Luke Kenneth Casson Leighton <luke.leighton@gmail.com>,
	binutils@sourceware.org
Subject: Re: [PATCH] ppc/svp64: support svshape2 instruction
Date: Mon, 12 Sep 2022 08:24:07 +0200	[thread overview]
Message-ID: <096b4190-d6d2-0f99-3490-7eb2ab51368d@suse.com> (raw)
In-Reply-To: <20220908182530.118842-1-ghostmansd@gmail.com>

On 08.09.2022 20:25, Dmitry Selyutin via Binutils wrote:
> https://libre-soc.org/openpower/sv/
> https://libre-soc.org/openpower/sv/remap/#svshape
> https://libre-soc.org/openpower/sv/remap/#svshape2
> https://libre-soc.org/openpower/isa/simplev/
> ---
>  gas/testsuite/gas/ppc/svshape.s |  6 +++
>  opcodes/ppc-opc.c               | 75 ++++++++++++++++++++++++++++++++-
>  2 files changed, 80 insertions(+), 1 deletion(-)

Just to state the obvious - svshape.d also wants updating.

> @@ -6843,6 +6915,7 @@ const struct powerpc_opcode powerpc_opcodes[] = {
>  {"svstep",	SVL(22,19,0),	SVL_MASK,	SVP64,	PPCVLE,	{RT, SVi, vf}},
>  {"svstep.",	SVL(22,19,1),	SVL_MASK,	SVP64,	PPCVLE,	{RT, SVi, vf}},
>  
> +{"svshape2",	SVM2(22,281),	SVM2_MASK,	SVP64,	PPCVLE,	{SVo, yx10, rmm, SVd, sk, mm}},
>  {"svshape",	SVM(22,25),	SVM_MASK,	SVP64,	PPCVLE,	{SVxd, SVyd, SVzd, SVrm, vf}},
>  
>  {"setvl",	SVL(22,27,0),	SVL_MASK,	SVP64,	PPCVLE,	{RT, RA, SVi, vf, vs, ms}},

The doc talks of 7 arguments, the first one being merely a 3-bit
one (offs) with the fourth bit there instead being a separate
"inv". Is the doc stale or the patch?

Jan

  parent reply	other threads:[~2022-09-12  6:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08 18:25 Dmitry Selyutin
2022-09-08 18:34 ` Dmitry Selyutin
2022-09-08 19:03   ` lkcl
2022-09-09  9:22   ` Dmitry Selyutin
2022-09-12  6:24 ` Jan Beulich [this message]
2022-09-12  8:43   ` Dmitry Selyutin
2022-09-12 10:30   ` lkcl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=096b4190-d6d2-0f99-3490-7eb2ab51368d@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=ghostmansd@gmail.com \
    --cc=luke.leighton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).