public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH ARC 4/5] Fix to pass ld-elf-ehdr_start-shared
@ 2016-04-04 12:51 Cupertino Miranda
  2016-04-05 14:31 ` Nick Clifton
  0 siblings, 1 reply; 3+ messages in thread
From: Cupertino Miranda @ 2016-04-04 12:51 UTC (permalink / raw)
  To: binutils; +Cc: Claudiu Zissulescu, Francois Bedard

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hi all,

Please review.
Fixed condition responsible for "ld-elf-ehdr_start-shared" test fail.

Best regards,
Cupertino

bfd/ChangeLog:

Cupertino Miranda  <cmiranda@synopsys.com>
    elf32-arc.c (elf_arc_check_relocs): Changed.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0004-Fixed-issue-related-to-ld-elf-ehdr_start-shared-test.patch --]
[-- Type: text/x-patch; name="0004-Fixed-issue-related-to-ld-elf-ehdr_start-shared-test.patch", Size: 480 bytes --]

diff --git a/bfd/elf32-arc.c b/bfd/elf32-arc.c
index e25e9ba..e369e20 100644
--- a/bfd/elf32-arc.c
+++ b/bfd/elf32-arc.c
@@ -1736,7 +1736,8 @@ elf_arc_check_relocs (bfd *		         abfd,
 	       non-readonly sections.  */
 	    if (bfd_link_dll (info) && !bfd_link_pie (info)
 		&& (sec->flags & SEC_ALLOC) != 0
-		&& (sec->flags & SEC_READONLY) != 0)
+		&& (sec->flags & SEC_READONLY) == 0
+		&& (sec->flags & SEC_CODE) != 0)
 	      {
 		const char *name;
 		if (h)
-- 
1.9.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH ARC 4/5] Fix to pass ld-elf-ehdr_start-shared
  2016-04-04 12:51 [PATCH ARC 4/5] Fix to pass ld-elf-ehdr_start-shared Cupertino Miranda
@ 2016-04-05 14:31 ` Nick Clifton
  2016-04-05 15:16   ` Claudiu Zissulescu
  0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2016-04-05 14:31 UTC (permalink / raw)
  To: Cupertino Miranda, binutils; +Cc: Claudiu Zissulescu, Francois Bedard

Hi Cupertino,

> Cupertino Miranda  <cmiranda@synopsys.com>
>      elf32-arc.c (elf_arc_check_relocs): Changed.

Approved - please apply.

Cheers
  Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH ARC 4/5] Fix to pass ld-elf-ehdr_start-shared
  2016-04-05 14:31 ` Nick Clifton
@ 2016-04-05 15:16   ` Claudiu Zissulescu
  0 siblings, 0 replies; 3+ messages in thread
From: Claudiu Zissulescu @ 2016-04-05 15:16 UTC (permalink / raw)
  To: Nick Clifton, Cupertino Miranda, binutils; +Cc: Francois Bedard

Committed.
Thank you,
Claudiu

> > Cupertino Miranda  <cmiranda@synopsys.com>
> >      elf32-arc.c (elf_arc_check_relocs): Changed.
> 
> Approved - please apply.
> 
> Cheers
>   Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-04-05 15:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-04 12:51 [PATCH ARC 4/5] Fix to pass ld-elf-ehdr_start-shared Cupertino Miranda
2016-04-05 14:31 ` Nick Clifton
2016-04-05 15:16   ` Claudiu Zissulescu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).