From: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Cc: "Cupertino.Miranda@synopsys.com" <Cupertino.Miranda@synopsys.com>,
"noamca@mellanox.com" <noamca@mellanox.com>
Subject: RE: [PATCH 1/3] opcodes/arc: Compute insn lengths in disassembler
Date: Thu, 07 Apr 2016 11:27:00 -0000 [thread overview]
Message-ID: <098ECE41A0A6114BB2A07F1EC238DE896617D6DE@DE02WEMBXB.internal.synopsys.com> (raw)
In-Reply-To: <1460027127-1121-2-git-send-email-andrew.burgess@embecosm.com>
Hi,
> +static int
> +arc_insn_length (unsigned isa_mask, bfd_byte msb,
> + bfd_byte lsb ATTRIBUTE_UNUSED)
> +{
> + static int tbl [32]; /* 0x00 -> 0x1f */
> + static int tbl_init = 0;
Please use bfd_boolean instead of int for tbl_init.
Otherwise, it seems sane to me.
Best,
Claudiu
next prev parent reply other threads:[~2016-04-07 11:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 11:00 [PATCHv2 0/3] ARC: Add another group of nps instructions Andrew Burgess
2016-04-07 11:05 ` [PATCH " Andrew Burgess
2016-04-07 11:05 ` [PATCH 1/3] opcodes/arc: Compute insn lengths in disassembler Andrew Burgess
2016-04-07 11:27 ` Claudiu Zissulescu [this message]
2016-04-12 9:27 ` Claudiu Zissulescu
2016-04-07 11:05 ` [PATCH 2/3] bfd/arc: Rename enum entries to avoid conflicts Andrew Burgess
2016-04-07 11:20 ` Claudiu Zissulescu
2016-04-07 11:05 ` [PATCH 3/3] arc/nps400 : New cmem instructions and associated relocation Andrew Burgess
2016-04-11 12:55 ` Cupertino Miranda
2016-04-12 11:00 ` [PATCHv2 1/3] opcodes/arc: Move instruction length logic to new function Andrew Burgess
2016-04-12 12:27 ` Claudiu Zissulescu
2016-04-13 13:32 ` Nick Clifton
2016-04-13 14:41 ` Andrew Burgess
2016-04-13 15:30 ` Nick Clifton
2016-04-14 12:40 ` Andrew Burgess
2016-04-14 14:45 ` Nick Clifton
2016-04-12 11:00 ` [PATCHv2 2/3] bfd/arc: Rename enum entries to avoid conflicts Andrew Burgess
2016-04-13 13:34 ` Nick Clifton
2016-04-12 11:00 ` [PATCHv2 3/3] arc/nps400 : New cmem instructions and associated relocation Andrew Burgess
2016-04-13 13:37 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=098ECE41A0A6114BB2A07F1EC238DE896617D6DE@DE02WEMBXB.internal.synopsys.com \
--to=claudiu.zissulescu@synopsys.com \
--cc=Cupertino.Miranda@synopsys.com \
--cc=andrew.burgess@embecosm.com \
--cc=binutils@sourceware.org \
--cc=noamca@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).