From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8225 invoked by alias); 7 Apr 2016 11:27:57 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 8200 invoked by uid 89); 7 Apr 2016 11:27:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:353 X-HELO: smtprelay.synopsys.com Received: from us01smtprelay-2.synopsys.com (HELO smtprelay.synopsys.com) (198.182.60.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Apr 2016 11:27:51 +0000 Received: from us02secmta1.synopsys.com (us02secmta1.synopsys.com [10.12.235.96]) by smtprelay.synopsys.com (Postfix) with ESMTP id 4761110C0386; Thu, 7 Apr 2016 04:27:50 -0700 (PDT) Received: from us02secmta1.internal.synopsys.com (us02secmta1.internal.synopsys.com [127.0.0.1]) by us02secmta1.internal.synopsys.com (Service) with ESMTP id 3BA984E213; Thu, 7 Apr 2016 04:27:50 -0700 (PDT) Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by us02secmta1.internal.synopsys.com (Service) with ESMTP id 1971A4E202; Thu, 7 Apr 2016 04:27:50 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 08ECC9DE; Thu, 7 Apr 2016 04:27:50 -0700 (PDT) Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) by mailhost.synopsys.com (Postfix) with ESMTP id F07F69DD; Thu, 7 Apr 2016 04:27:49 -0700 (PDT) Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by US01WXQAHTC1.internal.synopsys.com (10.12.238.230) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 7 Apr 2016 04:27:49 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCA.internal.synopsys.com ([::1]) with mapi id 14.03.0195.001; Thu, 7 Apr 2016 13:27:46 +0200 From: Claudiu Zissulescu To: Andrew Burgess , "binutils@sourceware.org" CC: "Cupertino.Miranda@synopsys.com" , "noamca@mellanox.com" Subject: RE: [PATCH 1/3] opcodes/arc: Compute insn lengths in disassembler Date: Thu, 07 Apr 2016 11:27:00 -0000 Message-ID: <098ECE41A0A6114BB2A07F1EC238DE896617D6DE@DE02WEMBXB.internal.synopsys.com> References: <1460027127-1121-1-git-send-email-andrew.burgess@embecosm.com> <1460027127-1121-2-git-send-email-andrew.burgess@embecosm.com> In-Reply-To: <1460027127-1121-2-git-send-email-andrew.burgess@embecosm.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2016-04/txt/msg00103.txt.bz2 Hi, > +static int > +arc_insn_length (unsigned isa_mask, bfd_byte msb, > + bfd_byte lsb ATTRIBUTE_UNUSED) > +{ > + static int tbl [32]; /* 0x00 -> 0x1f */ > + static int tbl_init =3D 0; Please use bfd_boolean instead of int for tbl_init. Otherwise, it seems sane to me. Best, Claudiu