From: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
To: Alan Modra <amodra@gmail.com>,
Andrew Burgess <andrew.burgess@embecosm.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: RE: [PATCH] ld/arc: Fix linker for big-endian arc targets
Date: Thu, 07 Apr 2016 15:20:00 -0000 [thread overview]
Message-ID: <098ECE41A0A6114BB2A07F1EC238DE896617D79D@DE02WEMBXB.internal.synopsys.com> (raw)
In-Reply-To: <20160407140659.GL18129@bubble.grove.modra.org>
[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]
Indeed the Andrew's patch breaks the build. Attached my solution for the problem.
Ok to commit?
Claudiu
> -----Original Message-----
> From: Alan Modra [mailto:amodra@gmail.com]
> Sent: Thursday, April 07, 2016 4:07 PM
> To: Andrew Burgess; Claudiu.Zissulescu@synopsys.com
> Cc: binutils@sourceware.org
> Subject: Re: [PATCH] ld/arc: Fix linker for big-endian arc targets
>
> On Tue, Apr 05, 2016 at 03:00:48PM +0100, Nick Clifton wrote:
> > > * emulparams/arc-endianness.sh: New file.
> > > * emulparams/arcebelf.sh: Deleted.
> > > * emulparams/arcebelf_prof.sh: Deleted.
> > > * emulparams/arceblinux.sh: Deleted.
> > > * emulparams/arceblinux_prof.sh: Deleted.
> > > * emulparams/arcelf.sh: Include arc-endinness.sh.
> > > * emulparams/arcelf_prof.sh: Include arc-endinness.sh.
> > > * emulparams/arclinux.sh: Include arc-endinness.sh.
> > > * emulparams/arclinux_prof.sh: Include arc-endinness.sh.
> > > * emulparams/arcv2elf.sh: Include arc-endinness.sh.
> > > * emulparams/arcv2elfx.sh: Include arc-endinness.sh.
>
> It's likely that the above is responsible for breaking
> --enable-targets=all builds. Please fix.
>
> base=`echo earcv2elf.c | sed -e 's,e\(.*\).c,\1,'`; \
> make run-genscripts "script_target=$base" "script_tdirname=tdir_$base"
> make[5]: Entering directory '/home/alan/build/gas/all/ld'
> LIB_PATH='' /bin/bash /src/binutils-gdb/ld/genscripts.sh "/src/binutils-
> gdb/ld" "/usr/local/lib" "/usr/local" "/usr/local" x86_64-pc-linux-gnu x86_64-
> pc-linux-gnu x86_64-linux "elf_x86_64 elf_i386 elf32_x86_64 elf_l1om
> elf_k1om" "/usr/local/lib /lib /usr/lib" yes yes arcv2elf ""
> Makefile:2200: recipe for target 'run-genscripts' failed
> make[5]: *** [run-genscripts] Error 1
> make[5]: Leaving directory '/home/alan/build/gas/all/ld'
> Makefile:2205: recipe for target 'earcv2elf.c' failed
> make[4]: *** [earcv2elf.c] Error 2
>
> --
> Alan Modra
> Australia Development Lab, IBM
[-- Attachment #2: fix.patch --]
[-- Type: application/octet-stream, Size: 362 bytes --]
diff --git a/ld/emulparams/arc-endianness.sh b/ld/emulparams/arc-endianness.sh
index 4d6158b..b970460 100644
--- a/ld/emulparams/arc-endianness.sh
+++ b/ld/emulparams/arc-endianness.sh
@@ -2,9 +2,7 @@ case ${target} in
arceb-*)
ARC_ENDIAN="big"
;;
- arc-*)
+ *)
ARC_ENDIAN="little"
;;
- *)
- exit 1
esac
next prev parent reply other threads:[~2016-04-07 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 16:34 Andrew Burgess
2016-04-03 8:38 ` Cupertino Miranda
2016-04-05 14:01 ` Nick Clifton
2016-04-07 14:07 ` Alan Modra
2016-04-07 15:20 ` Claudiu Zissulescu [this message]
2016-04-07 15:22 ` Andrew Burgess
2016-04-07 15:33 ` Claudiu Zissulescu
2016-04-07 15:50 ` [PUSHED] " Andrew Burgess
2016-04-07 15:42 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=098ECE41A0A6114BB2A07F1EC238DE896617D79D@DE02WEMBXB.internal.synopsys.com \
--to=claudiu.zissulescu@synopsys.com \
--cc=amodra@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).