From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-91687-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 126871 invoked by alias); 12 Apr 2016 12:27:48 -0000
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
Received: (qmail 126860 invoked by uid 89); 12 Apr 2016 12:27:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=
X-HELO: smtprelay.synopsys.com
Received: from smtprelay2.synopsys.com (HELO smtprelay.synopsys.com) (198.182.60.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Apr 2016 12:27:46 +0000
Received: from us02secmta1.synopsys.com (us02secmta1.synopsys.com [10.12.235.96])	by smtprelay.synopsys.com (Postfix) with ESMTP id 7A2D610C0538;	Tue, 12 Apr 2016 05:27:45 -0700 (PDT)
Received: from us02secmta1.internal.synopsys.com (us02secmta1.internal.synopsys.com [127.0.0.1])	by us02secmta1.internal.synopsys.com (Service) with ESMTP id 6E2444E214;	Tue, 12 Apr 2016 05:27:45 -0700 (PDT)
Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239])	by us02secmta1.internal.synopsys.com (Service) with ESMTP id 4BC714E202;	Tue, 12 Apr 2016 05:27:45 -0700 (PDT)
Received: from mailhost.synopsys.com (localhost [127.0.0.1])	by mailhost.synopsys.com (Postfix) with ESMTP id 3A749D09;	Tue, 12 Apr 2016 05:27:45 -0700 (PDT)
Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2.internal.synopsys.com [10.12.239.237])	by mailhost.synopsys.com (Postfix) with ESMTP id 2C777D08;	Tue, 12 Apr 2016 05:27:45 -0700 (PDT)
Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by US01WEHTC2.internal.synopsys.com (10.12.239.237) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 12 Apr 2016 05:27:45 -0700
Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCA.internal.synopsys.com ([::1]) with mapi id 14.03.0195.001; Tue, 12 Apr 2016 14:27:40 +0200
From: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, "binutils@sourceware.org"	<binutils@sourceware.org>
CC: "Cupertino.Miranda@synopsys.com" <Cupertino.Miranda@synopsys.com>,	"noamca@mellanox.com" <noamca@mellanox.com>
Subject: RE: [PATCHv2 1/3] opcodes/arc: Move instruction length logic to new function
Date: Tue, 12 Apr 2016 12:27:00 -0000
Message-ID: <098ECE41A0A6114BB2A07F1EC238DE896617DEAF@DE02WEMBXB.internal.synopsys.com>
References: <1460027127-1121-1-git-send-email-andrew.burgess@embecosm.com> <cover.1460458691.git.andrew.burgess@embecosm.com> <cb64992909da171def628e036ee5f6cc94e71058.1460458691.git.andrew.burgess@embecosm.com>
In-Reply-To: <cb64992909da171def628e036ee5f6cc94e71058.1460458691.git.andrew.burgess@embecosm.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2016-04/txt/msg00178.txt.bz2

Hi Andrew,

> +    case bfd_mach_arc_nps400:
> +    case bfd_mach_arc_arc700:
> +    case bfd_mach_arc_arc600:
> +      len =3D (major_opcode > 0xb) ? 2 : 4;
> +      break;

Ok, this solves the hole between 0x07 and 0x0b existing in your former prop=
osal. I think this implementation is safer than the older proposal and nice=
r than original code.

Cheers,
Claudiu