public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: jacob navia <jacob@jacob.remcomp.fr>
To: Michael Matz <matz@suse.de>
Cc: binutils@sourceware.org
Subject: Re: SUSPICIOUS CODE
Date: Thu, 13 Jul 2023 19:15:51 +0200	[thread overview]
Message-ID: <0FCFB248-4645-44D1-923F-0F0EF30C8F2A@jacob.remcomp.fr> (raw)
In-Reply-To: <alpine.LSU.2.20.2307131347320.13548@wotan.suse.de>

OK then. All those « details » were unknown to me.

This is actually normal. 

Free software supposes that many people read the code and examine it for bugs. I was doing just that, and without comments, the code looked suspicious. 

In no way I was trying to say your work was badly done or similar stuff.

Thanks for your time.

Jacob


> Le 13 juil. 2023 à 15:54, Michael Matz <matz@suse.de> a écrit :
> 
> Hello,
> 
> On Wed, 12 Jul 2023, jacob navia wrote:
> 
>> This change was introduced on Aug 18th 2011 by Mr Alan Modra with the 
>> rather terse comment: "(get_frag_for_reloc): New function. ».
> 
> Nope.  The third loop (the one you're asking about) wasn't added with the 
> above, but rather by commit 740bdc67c057 (also by Alan).  It contains 
> testcase and justification.  (Hint: as last resort, and only then, a reloc 
> is associated with a frag at the _end_ of section. frags can be 
> var-length).
> 
> The testsuite is run (as usual with many GNU projects) with 'make check' 
> after the appropriate configure and make steps.
> 
> 
> Ciao,
> Michael.


      reply	other threads:[~2023-07-13 17:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 15:12 jacob navia
2023-07-12 22:33 ` Alan Modra
2023-07-13  6:00   ` jacob navia
2023-07-13 13:54 ` Michael Matz
2023-07-13 17:15   ` jacob navia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0FCFB248-4645-44D1-923F-0F0EF30C8F2A@jacob.remcomp.fr \
    --to=jacob@jacob.remcomp.fr \
    --cc=binutils@sourceware.org \
    --cc=matz@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).