From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 1E2F038346A7 for ; Fri, 12 Jul 2024 13:03:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E2F038346A7 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E2F038346A7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720789386; cv=none; b=BGks+wrEtZ/j0poqD0XYQSV3L1FXl2YrN3xohNCO2BYN0Zk7mUmvqdHVJqBm/imEci+9ozM72/D8+Xvlo3eUYsV3JTMjObx6/b+l6TTMG81ug/wJMGIlvwWj60u9vcVSMYcHbRsxxfKEC22xaBsKPIg2c7t/8QgvXBUAKMK23YU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720789386; c=relaxed/simple; bh=VvMfuD8ypQ/fzTVnxeDOMXnDK8gB10fqto0FB93ltU4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=FMsi7G74SkMx3XZgpMFiPeMpHpTduAyWcJ+6jHAhmYEkSFLBCE6zBjXO48Ge47E8YnaYBK6DgeFhC38Cil7Z15iO5wtOeCC5XSV+MJpX6mBagSnt4eaDHmbxZ67S8zRnF9QMJruBG7vQYmKqQEooCJt5+qWWDZW701zM06E6xuY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3679e9bfb08so1147523f8f.1 for ; Fri, 12 Jul 2024 06:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1720789384; x=1721394184; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=m8USK1u7MVsENIiZtOA4WwhHWMZhtePcFdmiLSTc9x8=; b=QVJaCRQLuu6i8GIC2lDjhQDjeQQ27JtzVFmTzz8TiaqHj98qoOjM2kWdtNW4dSMme4 ol1TUywigg6v4UVMI7cBKhbmiOvdMkLXc5I7EK/8ORa+EA0wzEMav+Impaq1X8uEh2RQ 164HuDzEv7CzJckBgVfb6x1TEwFWUcvW4sr7XwuolwcDW5wQcie3vnZPan0AUzi8Q04W eB/tW4z0+zqGMtnpOCwNaUNy+zgPIEsAnhWqeuKzs0vqqBzwkwwFnjxqUYtGeCQ4+ivS wgti8RGRHCWrl+RDFr+ZCFIJ4arkw1Rno9qrRcfVdnHXc+KwWxuA2/MNX+cH5V0GW1oM mljw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720789384; x=1721394184; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m8USK1u7MVsENIiZtOA4WwhHWMZhtePcFdmiLSTc9x8=; b=bNXivWHuyG445/ku/F4AfIJYmZxeeah61ThPvRn6En12oErT9w4V9OpG7cKNHtlPb6 Nl++MHM89/tWUCZLCxinll79o5pwRFFCgANWj28+nfK6qp0FT6rDJqiSq9CZfBAL6g83 cCILHT4s2yjTUEzRQzdnz5ffE3xErZDhnVXUDZvlNkSKHF2Eg/cesNlyFAGN88h37PN7 lnqnEf7NqHB9gaPbL7DCv/ajKvNfzTGOqu2H691Nz462etPqxWNjLURXpw26YUj23muo t1zVl+43n8DbKHDSytvuXVBc95DGF1eYYtT0KoPQXOYNNghO3sWOUqWZ+/bUZ8BHAUpk 7SCA== X-Gm-Message-State: AOJu0Yyp+gI20yz+BOEZBBMHT8A4i4r5UiI8qiUAB0wJKxmYMmEWvVMS vbwwZ7Xx4JptJH4XCZJY90oJcbYKHrCXOzkOiHxmciq0izJI+LqS+D/0XkIDk+PFNY3Vv5Xafu8 = X-Google-Smtp-Source: AGHT+IG/Yg+SJOwaTPpoaL3n/UQxzmqygJvyj49PU+VbMapDRB7bpBLnRwHvOZXkGZV3aNl6TcqnxA== X-Received: by 2002:a05:6000:2ae:b0:366:ee84:6a77 with SMTP id ffacd0b85a97d-367ff6e7a2fmr2677004f8f.3.1720789383704; Fri, 12 Jul 2024 06:03:03 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b439674c4sm7377649b3a.102.2024.07.12.06.03.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jul 2024 06:03:03 -0700 (PDT) Message-ID: <0a54d7e2-b97a-46a4-a6a4-2b38e610dc86@suse.com> Date: Fri, 12 Jul 2024 15:02:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 07/17] Arm: correct macro use in gas testsuite From: Jan Beulich To: Binutils Cc: Nick Clifton , "ramana.radhakrishnan@arm.com" , Richard Earnshaw References: <1a02fdb1-08c6-4ac2-8494-3fa14be9c81f@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <1a02fdb1-08c6-4ac2-8494-3fa14be9c81f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3024.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The way the inner macro invocations are written doesn't quite work as expected (and would actually break subsequently): Due to overly aggressive removal of whitespace by the scrubber, the incoming \sym and \offset arguments actually get concatenated; an empty 3rd argument is being passed to ldrtest2. That just so happened to work as intended; any use of \offset alone would have exposed the problem. Quote the 3rd argument, thus retaining enough whitespace to be independent of scrubber internals. --- a/gas/testsuite/gas/arm/group-reloc-ldrs-encoding-bad.s +++ b/gas/testsuite/gas/arm/group-reloc-ldrs-encoding-bad.s @@ -14,7 +14,7 @@ .macro ldrtest load store sym offset - ldrtest2 \load \sym \offset + ldrtest2 \load \sym "\offset" \store r0, [r0, #:pc_g1:(\sym \offset)] \store r0, [r0, #:pc_g2:(\sym \offset)] --- a/gas/testsuite/gas/arm/group-reloc-ldrs.s +++ b/gas/testsuite/gas/arm/group-reloc-ldrs.s @@ -14,7 +14,7 @@ .macro ldrtest load store sym offset - ldrtest2 \load \sym \offset + ldrtest2 \load \sym "\offset" \store r0, [r0, #:pc_g1:(\sym \offset)] \store r0, [r0, #:pc_g2:(\sym \offset)]