From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Jeff Law <jeffreyalaw@gmail.com>, binutils@sourceware.org
Cc: Nelson Chu <nelson@rivosinc.com>
Subject: Re: [committed] RISC-V: Make g imply zmmul extension.
Date: Sat, 17 Sep 2022 03:28:58 +0900 [thread overview]
Message-ID: <0a71ae60-4396-6318-850f-2bf0073b4ca5@irq.a4lg.com> (raw)
In-Reply-To: <d6038672-faa2-9068-1c0f-434de294ba0e@gmail.com>
On 2022/09/16 11:33, Jeff Law via Binutils wrote:
>
> On 9/15/22 19:39, Nelson Chu wrote:
>> bfd/
>> * elfxx-riscv.c (riscv_implicit_subset): Moved entry of m after g,
>> so that g can imply zmmul.
>> gas/
>> * testsuite/gas/riscv/attribute-01.d: Updated.
>> * testsuite/gas/riscv/attribute-02.d: Likewise.
>> * testsuite/gas/riscv/attribute-03.d: Likewise.
>> * testsuite/gas/riscv/attribute-04.d: Likewise.
>> * testsuite/gas/riscv/attribute-05.d: Likewise.
>> * testsuite/gas/riscv/attribute-10.d: Likewise.
>> * testsuite/gas/riscv/march-imply-g.d: Likewise.
>> * testsuite/gas/riscv/march-imply-unsupported.d: Likewise.
>
> Does this happen to fix this kind of failure that started showing up a
> week or two ago?
>
> /tmp/ccdAErP7.s:6522: Error: unrecognized opcode `mul a5,a4,a5',
> extension `m' or `zmmul' required
>
> I started chasing it down and concluded it likely wasn't the compiler,
> but couldn't take it further before covid knocked me out. I'm just
> starting to try and catch up on things today...
Oh no. I apologize for a severe regression caused by my patchset
implementing 'Zmmul'.
I inspected the riscv_implicit_subsets array (that Nelson fixed "m")
myself and found that only anomaly is "g" (there is a good reason for
this and is harmless). So I believe that his patch fixed all extension
dependency issues so far.
Tsukasa
>
>
> jeff
>
prev parent reply other threads:[~2022-09-16 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 1:39 Nelson Chu
2022-09-16 2:33 ` Jeff Law
2022-09-16 3:26 ` Nelson Chu
2022-09-16 3:30 ` Jeff Law
2022-09-16 4:17 ` Jeff Law
2022-09-16 18:28 ` Tsukasa OI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a71ae60-4396-6318-850f-2bf0073b4ca5@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=binutils@sourceware.org \
--cc=jeffreyalaw@gmail.com \
--cc=nelson@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).