From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 998AA38A90AB for ; Fri, 16 Sep 2022 18:29:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 998AA38A90AB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 72B86300089; Fri, 16 Sep 2022 18:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1663352941; bh=2W7Ve4RhBFjpOL4DquBLdyiNBKa7Y6k3FVLvutiYMMM=; h=Message-ID:Date:Mime-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=jwZCUVfB77iFVMl3nemzUqrGzJZs1SkTxenZySFK2MlQtBfiG2/Q4mInjn8FXhGdI fZuEc1Pq2fErPUKudX88HFoJ7b44um78ERExDKblp5KPdecXllW8Lqdx3k4MtNfFnb QH6v1tMHxyTL+7djPnslwmBhEXXU6cVBnFgUv2z0= Message-ID: <0a71ae60-4396-6318-850f-2bf0073b4ca5@irq.a4lg.com> Date: Sat, 17 Sep 2022 03:28:58 +0900 Mime-Version: 1.0 Subject: Re: [committed] RISC-V: Make g imply zmmul extension. To: Jeff Law , binutils@sourceware.org References: <20220916013903.45339-1-nelson@rivosinc.com> Content-Language: en-US Cc: Nelson Chu From: Tsukasa OI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022/09/16 11:33, Jeff Law via Binutils wrote: > > On 9/15/22 19:39, Nelson Chu wrote: >> bfd/ >>     * elfxx-riscv.c (riscv_implicit_subset): Moved entry of m after g, >>     so that g can imply zmmul. >> gas/ >>     * testsuite/gas/riscv/attribute-01.d: Updated. >>     * testsuite/gas/riscv/attribute-02.d: Likewise. >>     * testsuite/gas/riscv/attribute-03.d: Likewise. >>     * testsuite/gas/riscv/attribute-04.d: Likewise. >>     * testsuite/gas/riscv/attribute-05.d: Likewise. >>     * testsuite/gas/riscv/attribute-10.d: Likewise. >>     * testsuite/gas/riscv/march-imply-g.d: Likewise. >>     * testsuite/gas/riscv/march-imply-unsupported.d: Likewise. > > Does this happen to fix this kind of failure that started showing up a > week or two ago? > > /tmp/ccdAErP7.s:6522: Error: unrecognized opcode `mul a5,a4,a5', > extension `m' or `zmmul' required > > I started chasing it down and concluded it likely wasn't the compiler, > but couldn't take it further before covid knocked me out.  I'm just > starting to try and catch up on things today... Oh no. I apologize for a severe regression caused by my patchset implementing 'Zmmul'. I inspected the riscv_implicit_subsets array (that Nelson fixed "m") myself and found that only anomaly is "g" (there is a good reason for this and is harmless). So I believe that his patch fixed all extension dependency issues so far. Tsukasa > > > jeff >