From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2065.outbound.protection.outlook.com [40.107.6.65]) by sourceware.org (Postfix) with ESMTPS id EC536383485B for ; Wed, 14 Dec 2022 08:25:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC536383485B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QsvzUOd3cRUiiB20WCdhvfEv4sR0DYwt7t6ZMMDaSfncHawu7mPp4Hd9gShN37aBy3sil+cO//JsBGDH9DCCTeziPpbebnagdRhZq/lHRR/FEJZD+AqW4UY+EmpjUg3tjnRxU6IsoyzrZwueHHsbltUeO5Rk2D+RdGjzqlYlhl3P646sZY79a9CoY9L2XDN2/bcDZc/r6Z9OWObQdE9V1livy//Ld6dNr1yrFcwBPUk/S4CJ4UVzf6jTqFdR4YsYD/moArsuFR1sDi+XUstTPY25HfSdubRrHvyj1f1V+uJ51aWJ5Kbx9ielwaCp6SdAAGS9YLngTfgP4APy6H10jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cMM9EQkaeMo/1TWYt2CoJ37AgU5t+CPjWLan7RMJcGY=; b=gCHndjedEeeRaTzo3PodhmX1dNOSJjDafyjVBaQxZd0HDwZ70i0dyWnWcnZArPw3OXpX6RRrrNO4laFtaly5WeXTfxbjWTCl8H6KtaQ+pOz9Q65fmZVUx10lUMBL/flKV/4BdWy4hUD6V0Q9cKRY+FP39pgfjnyAZe5OxVwPviRM2uZlYM3sDYXkKJV8H6R8yR+2R8ad3mgFCNv0wXTD+k8rHa/AgUTuMhHNciPTDmQ3IvbIwH3dC4S1mjDCut0nNrRK2/MZmlyyN6wsEQIkXg6pKWskn0jsmbIuUqh5lQgQ6irhVf3MWnTlBoYPj+Lg29PzbjQhUQ6CSj3Qzl0+1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cMM9EQkaeMo/1TWYt2CoJ37AgU5t+CPjWLan7RMJcGY=; b=g0O4kKDeum8gPzH4AgBe8FZkrgXeFAz6JY2qzZ6DhFf1Zy/nh1HZa4vF0kAk/78wqRextIQOvlrBw10lyOsk605Q7d4QGZEp9JbFtpAaL4o/jJ0OFUHD8MskRspkoK+oC4A5XQmfj333TSd2xrzZEcUbESa5PCVGPD1bi3ui1yw+hXlak2ntLkFydrgEA3zqixkAstJPb3RXWbZd57cdOoA8fOsk3fGlmYBQSS5FrahctuSh86JVaVnLiL6mM6DiHT5RrFCnREVqXaH1XYwPZenjtIEMz4cmVZRm2TIpiw8CcFaY2yBwUa7yaFcdoJx4CPNavoxreJRyMtmbeKReuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8038.eurprd04.prod.outlook.com (2603:10a6:20b:2aa::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11; Wed, 14 Dec 2022 08:25:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 08:25:54 +0000 Message-ID: <0aa2d866-1de1-640c-87ef-592a5c48c704@suse.com> Date: Wed, 14 Dec 2022 09:25:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: x86: generate template sets data at build time Content-Language: en-US To: Alan Modra Cc: binutils@sourceware.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0034.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8038:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a91537a-bf57-4609-8652-08daddacd129 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0xVNZehWwUY+A9sRzIE69MMkyLLixUvSghdSqbg5q9/b84/OVN8cS5V7P32noivk5V5brkWrVDDXR/2AUwqDzwoH1S6InbpuGa/odNegkPZC4xrMTSrc7iKpshxkEIKxMOCGD10fvgJHZSp2hFP1lyeeIVH4kxwQCWDTnZhINRypU49jm40XdPI8mgrPL7uVuWDkzfUfQj6cYPI1DyGK6ZC5j6V6/QYx3GZpKyu4N64TT3Pw2PwDRo4jNquHEdRibU9WiNMuhEhZ+A4OHgB5Z4HDPQTLRi7gEXdIe2+YL3vT6FfVSto+T8QLP8x8aAoTpdGZT0RmMOdhSwjL/PVQ2Q+oS3+AUqRJM3pGpzzQ3ToHuSp8zwgt+0T+tPr17rWpGmVTV1EOMLyR0/Hso744cVYkPABaxZbs2jHR3WvuTK/zTVV1BJxnKgMefgMI/EF/pg7oaPXGokn3TanMuAmB2/VjD91Gd5TEeu66rz72xFUe39+3DB7fbdvImrov2Sok2EJyXQ6vrhQcjcSZtTg82sHGHNE8CL6cBhuAKvMCD69Z2hnzG/iYfeLA7q0Xf9PM2OVfbkWljjGvUkIl2YUeDsXiuMF8jECeU8qW+Mc7zK3vF4BFjznb0w29g+Z2NLQw8vSJNllwUq7JBUqxDFZLuK9zNfm4zSKn7DfjV0NraKZc2P7FLt1UJ0+z/VGhut0AlURmYUG2l4tXdUl31UV4ZlcQGIFQyj3qqUaAsbiwXzA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(39860400002)(366004)(346002)(136003)(451199015)(83380400001)(2616005)(31686004)(316002)(86362001)(31696002)(478600001)(6916009)(36756003)(38100700002)(6506007)(53546011)(186003)(26005)(6512007)(2906002)(6486002)(8936002)(66946007)(5660300002)(41300700001)(8676002)(66556008)(66476007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVVjR3ZJcEpMRW1NL2xac1ozS2VEOTcxT2d6VUVkZHMwQzZ1OEt4dGdybkQ3?= =?utf-8?B?OHBlUUYrY2sxTHJRckVIZ01VYWlhTTdEWFR2ZGk4dHk0Wk45RnJIaXZOREJG?= =?utf-8?B?eGFpSHlZaXhEMk9aZWthM2NvNCt6MXk2UEVPVnJ5ZmFFOUg5TmxmRUlpellG?= =?utf-8?B?YW93VU0rbTVIZXRoT09uWEVZU2JRYjFnRHU2YXdvdGx4aDlublVxRjdVSDBZ?= =?utf-8?B?dUVoai8zaHZPS1FNYWYyZFd1bDlDR0YzSkdtSFNzM044MzIybEI3MXZJU0t3?= =?utf-8?B?OUVpdG52WEV3eUFBWXdZSU1vYVpGcjU1ZUY2dWRrVlZaM211WmJqbXFoVC9r?= =?utf-8?B?aG1JQkhXL28ya3dxZWlqb2pFcm1laEZDa3YycmhmN2FRL1lPNVlhTnpLY1Er?= =?utf-8?B?cjFNZ1JmdmR0ck45VElkTEwzQzZpNTZwckc3NkwxNTBXNjRSOVZyVDBTR0ZK?= =?utf-8?B?ZmVFWmJULytBL0pocEhYa29rTkJ4WFZ3NTJ2S0tJM2pmRjJ1WHEyYmcydE1j?= =?utf-8?B?bmRmTm8yeCttU3p0K3VHWnRwMmFVRUJwaEl6aXpKZmZBcGQvN2VWMWdRcDQ0?= =?utf-8?B?dEErakVtNHI4SndEQnFiUnJkVGNnN2tydjlJTmZlSW5TTm1ydThiemhSN0xm?= =?utf-8?B?ZGZPeStLWkVSWXU0SHlwYTdOaDV3Q0xpUlJGdEFIcmN2OTNuVUcwcEd6c0V4?= =?utf-8?B?N0lNTVhpamxmNWxpV3Vhb25VS3Z1NmdqNUlmaXZIcXZVR0lMbWN0UTRhdEdJ?= =?utf-8?B?U3luQUNTbHNYTlRtOUw3dG85RjZmVnRxSzZmWFU4YUZ4N2NrWUlpSUNQRjdx?= =?utf-8?B?NVJ3QlplcURSRy9QdGt6dTRjNEE3NUMvZjk1cERDbjMxVGU4aUJqUDNrV0JF?= =?utf-8?B?a3I3REpBczE1NDVrcHh6QmFqaUlOZnNFRmFTcmJGbHREQnByTW1kQ1pvOHlL?= =?utf-8?B?Ly96VmJWOExhQkFuNExlOXlFMlBKQS9ZaWRYRHNtOFR5N0pGZC9yNnQ3YXlj?= =?utf-8?B?T2d5d1Uya2Z5VklacDNTS3B3SndYZHNERHZoOXpIQms1ZGtCWUM1U1AvSTh6?= =?utf-8?B?c0doWFBFZlIyN1ZuZUNzOWhMNUs5N1JQLzhQNWJuWVI3clRTTUhvQUlYcmds?= =?utf-8?B?UTMwdjAvRHExWDl1amdhMWg2eW1lTktFSktHYSsvUXRHQ1ZOc1Y2Szc1MlUw?= =?utf-8?B?cU16NUlEVE9UandESloyL21ZVDRtZDZyVTFBdjVUdm9uUDM4ZmF2MnU0MXpw?= =?utf-8?B?VjJxMTE0OU1wOUo2RnNLY3h0SE5MNDRiaS9Pd3dNbHVEa0d4ZTA2U1A0V1ZZ?= =?utf-8?B?QnVKSzRGSGdreCtKSWx4eUxBUFc3ODZ0RVlqaXBMTkN4ZE5BdmhrNzkwUURm?= =?utf-8?B?dXF1TXREQUV0SlJKZnArZkQwUzg5Z2VjdGJ2RVRyQkxhRzZKaXdwYkJ0U2tS?= =?utf-8?B?LzlyVkJFTDlwZFkrZjI1U2w5S1J5UFhLTENKN2s0NGFCVno4OGNHWVZGaTJ6?= =?utf-8?B?aFIxODUwazEvMkVmM0NOZG9FYSsvNGthQmpMc3ZnU0tYTThSM043LzQyM3h6?= =?utf-8?B?UWwwanQrWEFXcXM2NVlidmpLcm94MzMzSUJmT0w4dXdhOCs1dVNhVGljT3dY?= =?utf-8?B?aE0zcWJ0bHgzMTlPY3hZL2RKU005Z2xxOEdnQjl5cDdGYkZ1ejlpczErU0VC?= =?utf-8?B?Si9rcmF5VHErNFRYL2huRWYvcUNkTU5zaFoyREhxUVNGVGkxK0Iyb3hSdzEw?= =?utf-8?B?aktsYVJhSFFPc0dwV0l3MU5IQVBYN0tCM3lXTWdTUENyalBpNDFzUTlXRE1T?= =?utf-8?B?U1JhdGdTdmFHSW50OVMrTXI2UHA4MHlYMkgrVlpQckhDcWloZ01saDQ4WEx2?= =?utf-8?B?V250ZmUyN3VzNmhFSmlSdW55VEFEOExva29YWU81clIrOEg0RHFVRFNJYjg1?= =?utf-8?B?Wlo5TnBqWmtjMzUveDcwRlJQLzl5S29XWTJzUFJSZ1RLbmZqKzJCUm5Gc1Ny?= =?utf-8?B?N0M5a1IrTSswQTg0YVc0c1A5anJEbW1xOHR0SlhMZWwzUWF6RWFvQVV3K2Jq?= =?utf-8?B?cTRsUy9RdlVvQXNQcC9qd2hNVS9ZSjgzODV2QnZvL3U1N0lack5nVEVhRHNh?= =?utf-8?Q?+48M5vV54uaynm9h5StJwy/yg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a91537a-bf57-4609-8652-08daddacd129 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 08:25:54.1494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l04BWFRLAPD3WbLHlUl/10B1xCbINpoPixWZQxk4fJyDIsOkNIjmXoNJow0nm5LeqZs+nPgHlzm9HMrv28ua2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8038 X-Spam-Status: No, score=-3028.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.12.2022 09:19, Alan Modra wrote: > On Wed, Dec 14, 2022 at 08:40:37AM +0100, Jan Beulich wrote: >> On 14.12.2022 06:14, Alan Modra wrote: >>>> + /* Type checks to compensate for the conversion through void * which >>>> + occurs during hash table insertion / lookup. */ >>>> + (void)(sets == ¤t_templates->start); >>>> + (void)(end == ¤t_templates->end); >>> >>> This results in asan complaining about "member access within null >>> pointer of type 'const templates'". >> >> Interesting. How can it know that current_templates is still NULL? > > It is instrumented and hits the error at runtime. Oh, I see. (Apologies for my very limited knowledge of asan behavior.) >> (I guess one can't expect it to realize that with the cast to void >> this doesn't really stand a chance of exhibiting UB; technically >> the compiler _may_ generate code for this nevertheless, and that >> code _may_ do anything due to it being UB.) It's also not clear to >> me what to do to work around the issue: Assign to current_templates >> instead, followed by assigning back NULL after the checks? (This >> would feel like clutter to me.) Are there other "standard" ways of >> working around such border line asan complaints? > > Yes, check for NULL before doing the operation. In this case I'm > inclined to just delete the type checking. No, I put the checks there specifically, as otherwise nothing will guarantee that breakage of the underlying assumption will be noticed at build time already. I'll wrap the checks in a conditional then. Jan