From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2069.outbound.protection.outlook.com [40.107.103.69]) by sourceware.org (Postfix) with ESMTPS id DCD323854811 for ; Wed, 26 Oct 2022 13:53:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DCD323854811 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nBoMjAakoJ3pB/e54ZkyR4fefQFUwF7e40+pCw8nzA9drtsfKI8Wdsqchau2hSmxm+XMY14az4bYYRpJt4Ji/+l4ktpn5VUFisxfSZHrUTxtq2LiHv6CvWBOo3gcI60KOIFfnG02L5LU7vtsOV8BA8L50TvFZl16wBfYh7PBWE3Ju7ptfa7hjaXB1t6ysAnnWaRIZ2CcyHGNC8DfTfojUE5H/E9EAt05JLNi7Sw1TXQlii2iJWfT6K1ke8Ezu6quMav+RsKTQciTYOhBItgrlE4tgro/TcxYNyNiNs9ahEZx0V0eOq4LHuI+AeA8aLbF41JtFZiC+Fu0irFjfVaVtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kwLjgQyn5KG8yXR4IBEeTAAv/AqGuYxKmPYWwVP2sRM=; b=lHgms023w0RzfeQjLmxMSSl+CBzNZOqIr1zKrCfdodj23RTgfakCWY2WoqslBnaOwF2YsTur0zZluKAJKAoaGllw4f6JNjfxIkVn4lyhC4TEBP/OEUm/35vAgmmaprOuXh2cnK55HHrNhFpcaORa44oO4Kj3QtFfgszGov0BeNrCDabtjfebRUdyCreZ1O4QSXswo7ElPH+1gUhD1RQjfFGHhnQnpcGInZZmbuAhibCiJ45YRcfmpGs9PP3uO0o7x/27OnebFwJlEk3cgeEODGOQ56OPyuudw4f1OkQ707eGryCVLCeHEGhJ36vD3NJ9MmmNMhSySlyMZ0xFiUv4nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kwLjgQyn5KG8yXR4IBEeTAAv/AqGuYxKmPYWwVP2sRM=; b=f2gFBZJw7gt3UamEsUEaMCG14QmSZellKsZLAK61X3CHTwKlCwmMS3rLAsQkzqPF+RFNM/GDJsLnXSY7CG+b62xnylTKf0+MvxJT6tksrJrNx9n+Y4j2zMuOfWxIvTKOS/l622enSZTnb7gwi30+Fto7DLOspY1qyk798CZOsdf1CNcRoXPJ+f2AS5a/537DRYI0MQdokl8W9covRb+2scp3H2YSuqdDyh/z82loi6uc3vNrILrJGkvjS/Sx8BLX8Md5dV8TilgMIHG4mnmQ9bG5fPhQpsbL0R6ywj+VvJVzqy2idmER4FLcLRTy+YdYgl79vUed30oTAyPDflKBBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9288.eurprd04.prod.outlook.com (2603:10a6:20b:4dc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 13:53:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022 13:53:26 +0000 Message-ID: <0aa4d551-e9ab-5e09-4f94-c672b7724915@suse.com> Date: Wed, 26 Oct 2022 15:53:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 10/10] Support Intel PREFETCHI Content-Language: en-US To: "Cui, Lili" Cc: "binutils@sourceware.org" , "Jiang, Haochen" , "H.J. Lu" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-11-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9288:EE_ X-MS-Office365-Filtering-Correlation-Id: 256aa17e-ab2b-4fb7-c197-08dab75974c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AtghibL/6Lgxt4cFTjdgMEeo5BgNCdgSUR2fbHLGR479pUhkvC242EG8b2l6I/HgvskmnqE4pLkrRxjCHZznMi4UQphoIvu0r2lNYbWqBInVqc8GUpkC2EUBLoT48VJm0Ro5z5wmOH5v6My1wM1i/fkrlkZ04DE6GexmZ2Ru89nfRorWuCe/VQeupkp8Z9sl3h2tqKecba55eTz8dXTcFi0nAvs1EtGLNaTzYpPj7pd6fYoaHh80XmfxucL2rDCK0sB26Wel/W8kgOfqHw8ClbYUVc1pAY+JsD6+FK/D4Lv2tNK65JYO2XIL1FpVWnjyoKkD5WxIPIKoa9ll9rpFmPeYMSMl+8VQXDRTd90sg+XoImQl0yojKTUsaj8Qbbytvla5pv0xvF4nYUw9HIR+Zj8rvuKeX/7d8Mx1ohcDYtjrgZGTwfI6kph81SgNyCJzmdAj8KYOmhhD69etZ08OCdd/KbOWCFOsjj2dM6MFF1urAnTHoQf9BjJjRJUkWmdTG1b95vHEWlahBQhLtLaUZnuE2TlZLE8jhlWDEt3mhwVreIk1sOKx0mwsdNL8p/zV1vprQm1yAHmWDhddnMWgMrLVzCgUtGqcR0Mqes41RMWcTY7tVPqnnYdRUEG+jPyTjVeDcrb1ijLZp1XGjuH1wmLC62FoLyAywoshaTjycSj4U4PCJNfJtiw4MTyHEaqQ/C2xraTIyE+zbE72SX4Jh8c+iKD0AvU0iC6WiX2Lz/g2vr5qrhI0cvziQG9qT6vHzqxD09vJGU8CiwL1dJ9gq+9j2aQOFiIjGGLAScOMwtI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(39860400002)(396003)(366004)(136003)(451199015)(2616005)(8936002)(6486002)(54906003)(478600001)(5660300002)(38100700002)(2906002)(66946007)(4744005)(66476007)(36756003)(316002)(6916009)(8676002)(4326008)(41300700001)(66556008)(186003)(6512007)(31686004)(26005)(86362001)(53546011)(31696002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXZ2amh4K1RHajJndVNDOFdDM1hoYkZNU2VseDc2RlVCSnpHRXpLekNCbjNK?= =?utf-8?B?QS9IcnltQ01YeC9aZ1N5UkZXRWNGT1h3MjJMSkpDaEI3eTlGOWhqeElMV1lq?= =?utf-8?B?UFJzMTdzVXpsbWxKd212QjAvUytpd24vRkVUblJ4bG1wT1g1Vk1vOFlJMGFy?= =?utf-8?B?VlFaUEdNRGxMT2VEdSswZTBOd0lVbHUxbGIyZE1CMThUSW03aFFidmZ6b1lz?= =?utf-8?B?WHVZcGlkczUzTzByWGUxNlpwUkNmWTZsLzhUb1JoaUVta0VEMU5BSlA2N2Jt?= =?utf-8?B?ZEdVL2x5THFBY3JhV0IrZmFhT0pKRTdyYjVjckpnU2d3U0FCbnhpUkNFZUw5?= =?utf-8?B?QVI2di9mL1J5TDBwbHl4Y21EejFvTG56Z0hOM25aOXl2dUJESHBhZ3RreU92?= =?utf-8?B?WTNTdEhmLzRwblYzZWZqdUs4OEJPNmM5UDhpcnNMTUZmWlNURzVEKzd1d1F5?= =?utf-8?B?a1ZMRmRQOXNYdk1udVFMVmNPRURZTDEyanlSak9kZkRzYVdKZjdEWThicFdF?= =?utf-8?B?T1VwUjB6REptVUphZndHRTZxYW5SdWNJRjViZjRremdNbDVDdVV1ZEFqMjZ5?= =?utf-8?B?NHdpNU92aElkWHBNcElRN2xxdGhqMi94RmM4TTVFdTEwNzBPTzl3L0JMM2NX?= =?utf-8?B?U3gvcXlabmJtb2dleHl4b29aUHhZMFJ0Syt3UlpXaTdtQXVaR29YaEZYUmZN?= =?utf-8?B?SnBxYWhDMWRKeWhYcklZMFp4eFVxOVlaSmVxMmVOMUltbTVHd1FqODhvcUU2?= =?utf-8?B?VStsV25ZdUdOaHZBT1d4NFFMaWdlOTc0SThLdTNCejRkc2EzT2VlNGY1NGYx?= =?utf-8?B?S24xWjc2bitJZC9FYkhtS0UxM0JZT3FndXJmQ0ZRWGdBUTdRZ3ltZjBBd0Nx?= =?utf-8?B?aENkRFVxdDV6UTQ3dVpuRlNwQSs2Szl0NjdaK3kvRDY0am96cXlJQ0w3dG00?= =?utf-8?B?eGQ3MytUdkc5ZVpUNG9nVnJ3UXZVQUpLRjJ2cU1uYzlkbmQ3c0xMdENtS2VD?= =?utf-8?B?YzYvSGR5SCtLSHZRaUd2VG1pTFBMR3U5ZDV3V0lPczN2b1c1VlhqU1ZydmNP?= =?utf-8?B?bW1vK3JXc0lEaTdJaUNOK01UY01ScXdpNjVxNTBxMTQxeUQvc3phMEtUMjZT?= =?utf-8?B?SUwwaUJtUHlEUjlDMHpwV2xUbmJ1Tjc0UHNXcEw2L3FueUtMVHNDMXRlYUJa?= =?utf-8?B?MXR4WnBsRXJ1TDNIbUFOWWJEQXVxK0FIZDMvSmlMVkF5d0RPVzFyU01obzAw?= =?utf-8?B?UmV4RGNFWk1YcHRlcHcrQVNKc0lOM0FrOS9xcjliQVEzRU1YT0ZHNnVmQkVv?= =?utf-8?B?YWdkZ2g0M0Y5UHRyVzFlUzJkRVBxQWdBajN2bi9mUU5sMFpZU0x4T3E1QUto?= =?utf-8?B?YWhnMjVSZWdPSE8yMlRGSmtjRHNjR0cwT1ZkNE9sdG15SDVnRnpScStKekpR?= =?utf-8?B?cm5NZ0xleVl6anpWWjJIMWtRY2FEbURpdXBWeEtpREtFWS91ZFgwNmp4WGtv?= =?utf-8?B?VjlmKzJoWVZPbUs1WWY3bTFMcUJROWxnMnBnbGU0eEdic0dNK0M1R0dhdmZM?= =?utf-8?B?WmZxZjFiSWpDK0k1WGdLZldBWjladUp0eE9TQWFUQlJQK0Z4RU1hSW1zbmVR?= =?utf-8?B?Snp1ejlOV01hMGg1dU1zUUlEVWRLTUNKb1JWcFVZdTJQaGFJMjdvaFFvNzBr?= =?utf-8?B?UzY1bkFYYk9PQmYwRmZYcjMwMU1CUG1rQllhLzJ3eXJyemJiS1BXSVFBOHBU?= =?utf-8?B?WXBFbXBwdWxPZTdENzd2RDJXb1U3bGlQdEwyenNRcGRyZVA3VDJSb0RCQXB2?= =?utf-8?B?VTJndGJDSTZnbFg0aG1zTGptZzVBQXBQYUxJWXdjRHAxTk1DNFB1dFhKTk1P?= =?utf-8?B?bG5iTHdTTUREM2VyWWtRemhpMzViYkc0VDlHbjVxa2VxTEZzSCsrNGtQZ0I1?= =?utf-8?B?bVE4MmsyeVRPd1orNUkrT3ArY2R3cWRCT1p4U1FJSmpkZmpoelNjWHBsekxj?= =?utf-8?B?MWVJb2hnOW5sZEdVOWtNVllnSk5SY1ZicU5tdzhhZldsNTRGa0R1N0x0TXlh?= =?utf-8?B?UTBoV1ViRFl0akZtVGw5TFN3dk9nMEE1REdNVllMTE8yZnJveHU4bTlyNUc0?= =?utf-8?Q?Fw8nhFcIbhp2XbD1ofuqsFi1g?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 256aa17e-ab2b-4fb7-c197-08dab75974c7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 13:53:26.6504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NUARgycdEIbDgUeMtWi8fU6kl9p9mjKnoN2BQeUoaLeKb5AXABt1I563UDFt57TKcKRUT4D5LH4uQUctI4YlUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9288 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.10.2022 15:42, Cui, Lili wrote: > Changed it like this. I referenced nopQ, but I don't understand that actually we don't have a 66 prefix, but set DFLAG for it. DFLAG represents absolute operand size, i.e. not relative to default operand size (which would be flipped by a 0x66 prefix). > + if (ins->intel_syntax) > + { > + ins->mnemonicendp = stpcpy (ins->obuf, "nop "); > + } > + else > + { > + if (ins->rex & REX_W) > + ins->mnemonicendp = stpcpy (ins->obuf, "nopq "); You also want "USED_REX (REX_W)" here (perhaps ahead of the if() to match the majority of other uses). Jan > + else > + { > + if (sizeflag & DFLAG) > + ins->mnemonicendp = stpcpy (ins->obuf, "nopl "); > + else > + ins->mnemonicendp = stpcpy (ins->obuf, "nopw "); > + ins->used_prefixes |= (ins->prefixes & PREFIX_DATA); > + } > + }