public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Kaylee Blake <klkblake@gmail.com>
To: Binutils <binutils@sourceware.org>
Subject: Re: RFC: [PATCH] ELF: Don't require section header on ELF objects
Date: Mon, 9 Mar 2020 12:29:48 +1030	[thread overview]
Message-ID: <0ad58560-3dd4-badd-5661-9f74905a7df3@gmail.com> (raw)
In-Reply-To: <CAMe9rOqd7S6x1nd6Q_-vyHaDrqJBLyMhk5EOwS7V4_N9x5otjQ@mail.gmail.com>

On 9/3/20 12:06 pm, H.J. Lu wrote:
> On Sun, Mar 8, 2020 at 5:05 PM Alan Modra <amodra@gmail.com> wrote:
>>
>> On Sun, Mar 08, 2020 at 04:46:51PM -0700, H.J. Lu wrote:
>>> On Sun, Mar 8, 2020 at 4:35 PM Alan Modra <amodra@gmail.com> wrote:
>>>>
>>>> On Sun, Mar 08, 2020 at 11:06:33AM -0700, H.J. Lu wrote:
>>>>> On Sun, Mar 8, 2020 at 10:59 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>>>
>>>>>> Any comments?
>>>>>>
>>>>>> Kaylee, do you have copyright paper with FSF?
>>>>>>
>>>>>> H.J.
>>>>>> ---
>>>>>> Section header isn't mandatory on ELF executable nor shared library.
>>>>>> This patch adds a new linker option, -z nosectionheader, to omit ELF
>>>>>> section header when building an executable or shared library, adds
>>>>>> an objcopy and strip option, --remove-section-header, to remove ELF
>>>>>> section header from an executable or shared library.
>>>>>>
>>>>>> The PT_DYNAMIC segment contains DT_HASH/DT_GNU_HASH/DT_MIPS_XHASH,
>>>>>> DT_STRTAB, DT_SYMTAB, DT_STRSZ and DT_SYMENT, which can be used to
>>>>>> reconstruct dynamic symbol table when section header isn't available.
>>>>>> For DT_HASH, the number of dynamic symbol table entries equals the
>>>>>> number of chains.  For DT_GNU_HASH/DT_MIPS_XHASH, only defined symbols
>>>>>> with non-STB_LOCAL indings are in hash table.  Since in dynamic symbol
>>>>>> table, all symbols with STB_LOCAL binding are placed before symbols with
>>>>>> other bindings and all defined symbols are placed before undefined ones,
>>>>>
>>>>> It should read
>>>>>
>>>>> ---
>>>>> all symbols with STB_LOCAL binding are placed
>>>>> before symbols with other bindings and all undefined symbols are placed
>>>>> before defined ones,
>>>>> ---
>>>>
>>>> That's new to me.  I don't think there is any ordering in .dynsym
>>>> among non-local symbols.
>>>
>>> I will get clarification from gABI group.
>>
>> Well we certainly don't do such sorting.  For example, from a freshly
>> build ld/ld-new --enable-targets=all
>>
>>    148: 0000000000f08380     4 OBJECT  GLOBAL DEFAULT   25 opterr@GLIBC_2.2.5 (3)
>>    149: 0000000000402f80     0 FUNC    GLOBAL DEFAULT  UND calloc@GLIBC_2.2.5 (3)
>>    150: 0000000000881536    35 FUNC    GLOBAL DEFAULT   13 _obstack_allocated_p
>>
> 
> I will make 2 changes:
> 
> 1.  Update -z nosectionheader to guarantee that the last entry in
> dynamic symbol table
> is defined.
> 2.  Update --remove-section-header to issue an error if the last entry
> in dynamic symbol
> table is undefined.
> 

With some testing, it seems like ld will emit an ordered symbol table
iff it's using the DT_GNU_HASH hash table style, and my understanding is
that DT_GNU_HASH in fact requires this behaviour. So in that case, we
don't need to do an additional check, because we only need the ordering
if we are looking up through DT_GNU_HASH instead of DT_HASH.

-- 
Kaylee Blake <klkblake@gmail.com>
C is the worst language, except for all the others.

  reply	other threads:[~2020-03-09  1:59 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-08 17:59 H.J. Lu
2020-03-08 18:06 ` H.J. Lu
2020-03-08 23:35   ` Alan Modra
2020-03-08 23:46     ` H.J. Lu
2020-03-09  0:02       ` H.J. Lu
2020-03-09  0:02       ` Kaylee Blake
2020-03-09  0:05       ` Alan Modra
2020-03-09  1:36         ` H.J. Lu
2020-03-09  1:59           ` Kaylee Blake [this message]
2020-03-09  2:23             ` Alan Modra
2020-03-09  2:35               ` H.J. Lu
2020-03-09  4:14                 ` H.J. Lu
2020-03-09  4:59                   ` Kaylee Blake
2020-03-09 11:56                 ` Alan Modra
2020-03-08 23:24 ` Kaylee Blake
2020-03-08 23:29   ` H.J. Lu
2020-03-08 23:38     ` Alan Modra
2020-03-08 23:45       ` H.J. Lu
2020-03-12  2:14         ` Fangrui Song
2020-03-09  8:13 ` Florian Weimer
2020-03-09 12:54   ` Kaylee Blake
2020-03-09 13:06     ` Florian Weimer
2020-03-09 13:14       ` Kaylee Blake
2020-03-09 13:16         ` Florian Weimer
2020-03-09 13:28           ` Kaylee Blake
2020-03-09 13:29             ` Florian Weimer
2020-03-09 13:45               ` Kaylee Blake
2020-03-09 13:54                 ` H.J. Lu
2020-03-09 14:02                   ` Kaylee Blake
2020-03-09 14:52                 ` Florian Weimer
2020-03-09 15:07                   ` Kaylee Blake
2020-03-09 15:29                     ` Florian Weimer
2020-03-09 13:44     ` Alan Modra
2020-03-09 13:54       ` Kaylee Blake
2020-03-09 22:34         ` Alan Modra
2020-03-10  0:14           ` H.J. Lu
2020-03-09 14:34       ` Michael Matz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ad58560-3dd4-badd-5661-9f74905a7df3@gmail.com \
    --to=klkblake@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).