From: Nick Clifton <nickclifton@nickclifton.clara.co.uk>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Alan Modra <amodra@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH] Add documentation of warning if byte size exceeded
Date: Fri, 10 Mar 2017 15:42:00 -0000 [thread overview]
Message-ID: <0aec9701-c006-695b-eae7-0f54ed744f2d@nickclifton.clara.co.uk> (raw)
In-Reply-To: <20170307094203.GB21536@eros>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
Hi Tobin,
>> GAS throws a warning if an attempt is made to declare data that
>> exceeds the size allocated when using directives .2byte or .4byte.
I have taken your patch and extended it slightly in order to tidy up
the wording. Attached is the patch that I have committed.
>> I see that the patch prior to this one (commit d10ef45) has caused
>> build fail for someone.
I did not see this. The documentation builds fine for me. Are you sure
that it is still a problem ?
Cheers
Nick
gas/ChangeLog
2017-03-10 Tobin C. Harding <me@tobin.cc>
Nick Clifton <nickc@redhat.com>
* doc/as.texinfo (2byte): Tidy up wording. Add note that
overlarge values will produce a warning message and be trunacted.
(4byte): Likewise.
[-- Attachment #2: as.texinfo.patch --]
[-- Type: text/x-patch, Size: 2389 bytes --]
diff --git a/gas/doc/as.texinfo b/gas/doc/as.texinfo
index a8f014b..3b3e931 100644
--- a/gas/doc/as.texinfo
+++ b/gas/doc/as.texinfo
@@ -7345,9 +7345,11 @@ instead of zero. Using @samp{.zero} in this way would be confusing however.
@cindex two-byte integer
@cindex integer, 2-byte
-This directive @code{.2byte}, which is available for ELF targets, expects zero
-or more expressions, separated by commas. Each expression is assembled into the
-next two bytes.
+This directive expects zero or more expressions, separated by commas. Each
+expression is evaluated and placed in the next two bytes of the current
+section. If an expression will not fit in two bytes, a warning message
+is displayed and the lowest two bytes of the expression's value are used.
+This directive is only available for ELF targets,
@node 4byte
@section @code{.4byte @var{expression} [, @var{expression}]*}
@@ -7355,9 +7357,11 @@ next two bytes.
@cindex four-byte integer
@cindex integer, 4-byte
-This directive @code{.4byte}, which is available for ELF targets, expects zero
-or more expressions, separated by commas. Each expression is assembled into the
-next four bytes.
+This directive expects zero or more expressions, separated by commas. Each
+expression is evaluated and placed in the next four bytes of the current
+section. If an expression will not fit in four bytes, a warning message
+is displayed and the lowest four bytes of the expression's value are used.
+This directive is only available for ELF targets,
@node 8byte
@section @code{.8byte @var{expression} [, @var{expression}]*}
@@ -7365,10 +7369,11 @@ next four bytes.
@cindex eight-byte integer
@cindex integer, 8-byte
-This directive @code{.8byte}, which is available for ELF targets, expects zero
-or more bignums, separated by commas. For each bignum, it emits
-an 8-byte integer. If the bignum won't fit in 8 bytes, it prints a
-warning message; and just takes the lowest order 8 bytes of the bignum.
+This directive expects zero or more expressions, separated by commas. Each
+expression is evaluated and the resulting bignum is placed in the next eight
+bytes of the current section. If an expression will not fit in eight bytes, a
+warning message is displayed and the lowest eight bytes of the expression's
+value are used. This directive is only available for ELF targets,
@end ifset
@node Deprecated
next prev parent reply other threads:[~2017-03-10 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 9:22 tcharding
2017-03-07 9:42 ` Tobin C. Harding
2017-03-10 15:42 ` Nick Clifton [this message]
2017-03-10 21:58 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aec9701-c006-695b-eae7-0f54ed744f2d@nickclifton.clara.co.uk \
--to=nickclifton@nickclifton.clara.co.uk \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=me@tobin.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).