From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6EE243857B93 for ; Wed, 27 Sep 2023 13:38:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6EE243857B93 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695821910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R9SI17wF8/myQfShZmQTy6lh9nSr7f5bJRQuV1hsNLg=; b=YcB6UT24kY21LkTknLxqJXKhBv6gneu1Od8grhAKJU2ykMljDftk8N30JRjV3aF7GosysO qpeZD/8d0QdkGU155Gbdg0l7HWnngikw83WKK9JNlf5SdklZmdGBA6T2Fd+p0F1Mv2WLhO 99p380LseO1mxsKJ2gKcX2b4QdgxoXw= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-zJ_Ht22cOsKNHERyNHCGOw-1; Wed, 27 Sep 2023 09:38:28 -0400 X-MC-Unique: zJ_Ht22cOsKNHERyNHCGOw-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-5a1d352a86dso103807457b3.0 for ; Wed, 27 Sep 2023 06:38:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695821908; x=1696426708; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R9SI17wF8/myQfShZmQTy6lh9nSr7f5bJRQuV1hsNLg=; b=wIwID74G13ADPiwpAjbC5NrDhFn+Yn1URwjN9KeF/ghoTjYNhfCqDYsiFygpefOSs4 BLqiFobHj025MMEvbgey8UzZOVuX4j/aB2sEscxU6zdrJCSNoWQNc+rDrvllt0iZkSZY zKU7ZiEcffZrjKdDuHCfg7dGHLei8sRpKX2SxfiAI8m+DZAOlLJUnxYteNbsuVpZJBs2 UzSB5LxKGnAzOabOSExCWNHI/T/KwZlXblCwX5QdKnQFkE3fZ4YhLSTi6KgFlZ5osZmB btgGkOgr2I4H6Fz5ETRtQeddIjo7gWBeLS/fwr+yRpOpss80t456LoGkmqwokoy+UD0d V8wQ== X-Gm-Message-State: AOJu0YzVrQJYtzGMyOisCpm9spDLtQnX36JnbVJoyNWww6JSFC6YTOmG gnzKwlYlPqjEQDT+pj2z5CfOEdZw6q+M/rgBurrb4fFxsUMlzBixFl03eNJ3MB+zs4vQlpmEOUE wyEu36r2OZBFm6jWrrja3hj6nJQ== X-Received: by 2002:a81:8413:0:b0:59b:5231:50d7 with SMTP id u19-20020a818413000000b0059b523150d7mr2197029ywf.10.1695821907910; Wed, 27 Sep 2023 06:38:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGxiSTmeZV6GSZiC3NbZuW/dwe+xspr8LK9C8OJktmeFY1C3wbESvy+pVSKDtagCQbeNLylA== X-Received: by 2002:a81:8413:0:b0:59b:5231:50d7 with SMTP id u19-20020a818413000000b0059b523150d7mr2197014ywf.10.1695821907579; Wed, 27 Sep 2023 06:38:27 -0700 (PDT) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id a5-20020a0cb345000000b006588bd29c7esm1856932qvf.28.2023.09.27.06.38.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 06:38:27 -0700 (PDT) Message-ID: <0b0c6527-b1b8-590d-9759-3f0d8efd2eb1@redhat.com> Date: Wed, 27 Sep 2023 14:38:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] Add support to readelf for the PT_OPENBSD_NOBTCFI segment type. To: Frederic Cambus , binutils@sourceware.org References: From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Frederic, Approved - please apply - but with one very small change: > #define PT_OPENBSD_WXNEEDED (PT_LOOS + 0x5a3dbe7) /* Program does W^X violations. */ > +#define PT_OPENBSD_NOBTCFI (PT_LOOS + 0x5a3dbe8) /* no branch target CFI. */ > #define PT_OPENBSD_BOOTDATA (PT_LOOS + 0x5a41be6) /* Section for boot arguments. */ Please could you use a capital letter at the start of the comment. ie: > +#define PT_OPENBSD_NOBTCFI (PT_LOOS + 0x5a3dbe8) /* No branch target CFI. */ Cheers Nick