From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 115CF3858D3C for ; Tue, 17 May 2022 13:44:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 115CF3858D3C Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-29-6ZngcLH_MFmy-ilAX31GEQ-1; Tue, 17 May 2022 15:44:14 +0200 X-MC-Unique: 6ZngcLH_MFmy-ilAX31GEQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oGM8Y7/ZdfDKS3xOTyKSM1rEV10/tyo6Yy2J4T5qUAwIU/iLDRX7+NrEVE+8e25/NBbUNOzFJOQP1LtUhgxE2Au0QFGRz3h9NV+qlQtWEVMK9ZRP5/Xe6WRuHeodkD5Haguj7NX7dABYL7D9rIjUUggMt2XjdyxHh4xDKUaFxmv1XnQFy8x7GL+S6y11GmydnisYxxCcCZkEVlTw+yTpkwrJYipEaknPOTdze0whI2jh+R770HPpsh6JwcG5ITJpYKMft1uYgsqlYEJ8JkzjaB3LeM/Lc5plz1b6jhEin9/8CxRqZj2w618Ladsy9GTMbx8muBJ4LV/Z2aN0m+rHXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+CpCUIrYqj7DcuGHTJQMQBO5jf0jg/T6syNR/aNxq60=; b=cqtAjhcltu4zJ6aLc+HB4W/EVvWe5eQC+juVVrTgOaz0gJi799ubRM9/O4aKGynqToPL04pqRRq4RbpF+4VZ7AusT5kNalaM0zEaxIX1CAOEDI88YdJTb5Fuf5Fx6wLv2JMDcI8KQRGcZLdoJBsVQTT19VPZ05n9IIrg5/jLaLuTn3PokXJCTrr2UNp9qeIB9stEEPm7SELg0j6HUDPCSHR7QAvvxUgu4dgpJjxnzQcF9rA6tIe8bB53iu9Xh9Cn1wjQNM3mKiN93aNNnW3xL9uPbO9nNMql1T3W6wIgZ3FJrWz2wUJwh+BiKS3GDyRgR90Cz0MkwoPzdu1UUUKJHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6665.eurprd04.prod.outlook.com (2603:10a6:10:10f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 13:44:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 13:44:13 +0000 Message-ID: <0b8542bf-b15f-cf28-0cc2-f0bc158aebc8@suse.com> Date: Tue, 17 May 2022 15:44:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH,RFC 3/7] libctfframe: add the CTF Frame library Content-Language: en-US To: Indu Bhagat References: <20220507005223.3093035-1-indu.bhagat@oracle.com> <20220507005223.3093035-4-indu.bhagat@oracle.com> <56857abe-32c2-9f16-0ac2-99a82ebf3d7d@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <56857abe-32c2-9f16-0ac2-99a82ebf3d7d@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0024.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d558b43-50c1-4eac-c0c1-08da380b53d3 X-MS-TrafficTypeDiagnostic: DB8PR04MB6665:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l1Q9TZh6QAvWkqLEX2E1cWF6g/M67yQPPhLpYGSdh/wiTMlVERe2eV7TyE5UfXuXAgh/dK0RSHlds7Gl4SYFblZv5soUQgL+x1PVQ0v24qlBc9AguvMvO1u2Y7GCl5+Cbtm8FwSCN96ZOGtomhceNbs2EhXMxB7JtrN8VfuhUAiSU0CXKOAJjyEXWtEXWC1AwcGZtUg6DVrQY2kVZ2WrbgXrLVWU2BUAla8d7w0K5fih9fb/IEIr6ghVtC9ATUdhDYqKT3zV0TI6ogT10EID4V6/ndNGeShZOSsXfCDGYK0JeJhh/yzDg79XCFENgZXhW4mRVolg4vwFaniA78jLcTJMD0r/XAfuIii0Ksx1UVcpEGZghrDJw5kHcSvrnVbMksvoVdr+Ybm2bWeCpO+b6KYVQEoxflAIJ95Dh/N/g/THeyLGxWKgkIbsPXj2+C651Y8kAvSCusNoKPqmEvVWIDGL6QNk8S5tMH5uq1NKpxK8KcQjXWXN/RnVUJZ9qx8EeUkXzIahO/3BQGGpJqMt6kQxmSPj2BR+YhtywDrSpNwnZOq5sPRiswt5S6jmjY+wmzMqfv1oSEx52+/Ec5dIsM2b5pqd0nMRIcnrvSlWsrgs3D6st/tkcc8p/aVIDlVP2TS7HJ2Q+T6GUDcGh1xj7tnzR/3WpOw7ktijjthAR8v4Xi67j1VuESm8ZgOusXwfw/c4+DKLS9pFStfIt7fg0/Qll8SsKSpBfPFb4Y5TMmvsL2kxdu5zANE4ffBNi+9P X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(83380400001)(2616005)(66556008)(26005)(6666004)(6486002)(8676002)(31686004)(86362001)(4326008)(6916009)(66946007)(6506007)(31696002)(508600001)(53546011)(186003)(36756003)(8936002)(38100700002)(6512007)(2906002)(66476007)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1laN0JOR0FPcFBrNFN6b1ZEOHJxb0UraGRvUkF2NmV3TXRvcnFnWC9rTGRj?= =?utf-8?B?UkViSElCZGNiM3gxR2tPMDNkUUVkcFVrVDFzdThsdjNSYllVc2VxeVVtd3Bu?= =?utf-8?B?amFud09SNHpsVVphN0VWamQ0YVowSExiUzlXUktmVVZYbnZ1ekxKaXBDdStV?= =?utf-8?B?b0NEUVFXWDN1QWFGMmtFVzd5cXVhQlZuWkpTRVF2YkZ6cnNyU295VDI2RHZz?= =?utf-8?B?V3cwbzJSMS9tb0ltb04vQ3hRdzRJRFhwUEd2QzlNR241V0NvblVFOHc2SGNv?= =?utf-8?B?U1Y1NWNIZkh2RXRNNmtFd0thdGdYMVRxTGx3NFM4OGRoL0J5aC9IdW1HYXp1?= =?utf-8?B?dWhuMTNUQmdyTmtKTFRLTTdYVW5QNVlOem1iSWFGeHlvRXNvcXFVT05HOGNu?= =?utf-8?B?aFVqTzNtUmIvSXJEVG45Q3NXZ1hFc3VuL2FxS2prMnFWNHEvY1R1NWJsT1Fm?= =?utf-8?B?Wlk5SE1vaU1PZXdSbTgweEpMcjFGRnc2OEVSa0tjWDhLR2NIc3ljY0JxMlUx?= =?utf-8?B?dzNiMWZQZ1VuTjNvRUJRU0RMMEdTbGk0cysrMldWTHhaZkxzZnpBd1YrK2RX?= =?utf-8?B?bmpCT3pHZWpiTTJaSnREZ0lHQ3lXZVZJVWRIQ1phUVdsVHo0bG9udzR2YThQ?= =?utf-8?B?eWNjaHZDSktIQ2hWWndxWU1wdzVuWHlMT2pGNXpqSG95WmRiazR4QnJQOUFR?= =?utf-8?B?VHBybmxxYjRTNnZhTlpReXpBRmw1VS9wSmthNU9LaENoa3A4TVp3KytDRmJ0?= =?utf-8?B?TnJPRXpzVERvYlZaSzBtaTRvREo2V0pRVUhiV1hiTmpNU2ZQM2ZBUncydDBE?= =?utf-8?B?U3EzR3pLT0NtVHBYTjQ0L3VQLzVrc2NnZXE1eU5YdmdEYXM4TlkwMjJXK2hS?= =?utf-8?B?bGxkTU90ZHNMdnhRVzN1cmZ5QlBMaGY2WWFDYzZaL3cwTVNqV3JZSlpuYjlP?= =?utf-8?B?OWFTR0RlUk5SSTZFTnl0SHVtSzZHdk1qdlltK3NvNGNESnNpakZWSGhodUhh?= =?utf-8?B?NG4rQTYvSGoxMmVvUE12WHZCRE9LWVREQUZQa0NJamZRNDZMTkc1NUZidmo5?= =?utf-8?B?T0lGVFk3SE9TWmEwYktQcnl1TjZRc1h5cFFNb3pOUGdKWDZqNWJrZkh3VDAx?= =?utf-8?B?UnhTZmkyR0xjT1FrS0FqUCszVFBGUGZSelF6N3F6MGpieDNhYitqMHVQUVR5?= =?utf-8?B?amNXOGpQc3lFRGlQdzYrR0JMVk1xcDZEdSs1S0xNOXJPMGpBdThtTDRRUEVJ?= =?utf-8?B?N2wrTFg4WkZFd3lHcyt4SXJ4bEFLRGt5ZXY1QStxN0JKVVBNZXRMaEduS3RD?= =?utf-8?B?NDBvbUFUVkR1QUdYL3RPakJkSC9Ua0RtUGdHUVAxZDk5V09HeEhwbmJrYXNX?= =?utf-8?B?dXVrRUF3WWFhZkhHQXg5blpFMzhCZVlRb1pQNC9RdDVqRlhQVjF1SWpXM3ZG?= =?utf-8?B?UXB4L3FqVEI0eXcxRGsyTlM0T1ZNM2RoNmVySDV5d0J1YUZJMlRldTBFOGxG?= =?utf-8?B?ZlI2QTlUUEoyZUlRL04vL1RUQnJLWjV2dHFJRWxBaUlsdWxUTitoY2RmMWVK?= =?utf-8?B?cjZCM0ZpVVZ4aE5hV3pJU0MzTDY1aCtCemphTzRmbkxTeWNQQ0VtdUcvVWhj?= =?utf-8?B?YXg2Ynd3cTlTcmVTWGlPSThBOTZLV3JlcXUxUTJZNGltZFJqTEd3RU9lb3lP?= =?utf-8?B?cmd1RDFTMDdCSFplMSs5UG9yL0dZSEMvNHQ3dFFIRzRqZFFHcEcyb05CQVk5?= =?utf-8?B?OVdiT1pRYUF0ampKLzFRMkFSSFpkNDZqVUx6dWk3dGlZUzVqdFJaUlM3ZTF3?= =?utf-8?B?dGRaQjMzdEVEd2dqWm1TUjUyM2RPaGJKUFVZY1RORC9CZGZ0Qk94ckdDOWdT?= =?utf-8?B?MHFWSVFpbnBhclV5SHpLbWYxM2NtRkRNZ0Q1MkVOTzlrTk96TDRyQ3duU1pm?= =?utf-8?B?aXpvV00vYXh6bGx4OEwxOXlFQzVUYmlueTlRcUE5VWFOSXVNVFRITGxiRXBV?= =?utf-8?B?aTY5RG1mUmNWMDkxbHJVT3FEeG4vZnZQWWpKRWt1SjRiRUd4Q21WQ1RXSDQr?= =?utf-8?B?by9zcjlkYUZCU0VkTWovdDFiK0pUcEh4YkZxTzJHWnJtYWVjYWhwTzJFQXN1?= =?utf-8?B?azlBb0VoSU1LbjA5NmxVWExjRDdsVmhJZ3drZFNySWgrRGQ5L0Z6UWxGcUl2?= =?utf-8?B?WU9zSFJTZ2cvcVNtLzJTNnFHS1FnL3cwcEJNWTZzMTRsazl2UytzaHpzdnIr?= =?utf-8?B?RnZsdStKRUZXbXFvTFlZSGtSU0Y4amVJNXdzekthWE01a3pPRWg4VDZqTGF6?= =?utf-8?B?ZFg1dk5hVU52Sm5FakZ0QVExOUkybWpRMkFiVmxESk9jakFZeGZOUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d558b43-50c1-4eac-c0c1-08da380b53d3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 13:44:12.9934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GdeJ8NfLPO25JzlHDESWcA2pC/SiDSsaTAfVBeBqnzM8S0Ujf68zZZ51Pwgap4iPHCi4S8onwYLrbMDKcoIfzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6665 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 13:44:22 -0000 On 09.05.2022 00:00, Indu Bhagat via Binutils wrote: > On 5/6/22 5:52 PM, Indu Bhagat wrote: >> From: Weimin Pan >> >> libctfframe is a library that allows you to: >> - decode a .ctf_frame section >> - probe and inspect a .ctf_frame section >> - encode (and eventually write) a .ctf_frame section. >> >> This library is currently being used by the linker, readelf and objdump. >> The file include/ctf-frame-api.h defines the user-facing APIs for decoding, >> encoding and probing .ctf_frame sections. A set of error codes together >> with their error message strings are also defined. >> >> Endian flipping is performed automatically at read and write time, if >> cross-endianness is detected. >> >> ChangeLog: >> >> * Makefile.def: Add libctfframe as new module with its >> dependencies. >> * Makefile.in: Regenerated. >> * binutils/Makefile.am: Add libctfframe. >> * binutils/Makefile.in: Regenerated. >> * configure: Regenerated >> * configure.ac: Add libctfframe to host_libs. >> * libctfframe/Makefile.am: New file. >> * libctfframe/Makefile.in: New file. >> * libctfframe/aclocal.m4: New file. >> * libctfframe/config.h.in: New file. >> * libctfframe/configure: New file. >> * libctfframe/configure.ac: New file. >> * libctfframe/ctf-frame-error.c: New file. >> * libctfframe/ctf-frame-impl.h: New file. >> * libctfframe/ctf-frame.c: New file. >> >> include/ChangeLog: >> >> * ctf-frame-api.h: New file. >> --- >> Makefile.def | 2 + >> Makefile.in | 1288 ++- >> binutils/Makefile.am | 2 + >> binutils/Makefile.in | 1 + >> configure | 2 +- >> configure.ac | 2 +- >> include/ctf-frame-api.h | 210 + >> libctfframe/Makefile.am | 38 + >> libctfframe/Makefile.in | 915 ++ >> libctfframe/aclocal.m4 | 1241 +++ >> libctfframe/config.h.in | 144 + >> libctfframe/configure | 15118 ++++++++++++++++++++++++++++++++ >> libctfframe/configure.ac | 75 + >> libctfframe/ctf-frame-error.c | 49 + >> libctfframe/ctf-frame-impl.h | 55 + >> libctfframe/ctf-frame.c | 1515 ++++ >> 16 files changed, 20650 insertions(+), 7 deletions(-) >> create mode 100644 include/ctf-frame-api.h >> create mode 100644 libctfframe/Makefile.am >> create mode 100644 libctfframe/Makefile.in >> create mode 100644 libctfframe/aclocal.m4 >> create mode 100644 libctfframe/config.h.in >> create mode 100755 libctfframe/configure >> create mode 100644 libctfframe/configure.ac >> create mode 100644 libctfframe/ctf-frame-error.c >> create mode 100644 libctfframe/ctf-frame-impl.h >> create mode 100644 libctfframe/ctf-frame.c >> > > Hi, > > This patch did not make to the list as it exceeds the 400 KB limit > > -------------- > > Your mail to 'Binutils' with the subject > > [PATCH,RFC 3/7] libctfframe: add the CTF Frame library > > Is being held until the list moderator can review it for approval. > > The reason it is being held: > > Message body is too big: 666389 bytes with a limit of 400 KB > > ------------- > > What is the recommended way to address this ? Splitting this patch up > with libctfframe/configure in a separate commit will not address the > issue as the libctfframe/configure will still be larger than 400 KB. A common way around this is to supply the patch as an attachment instead, possibly even compressed. Typically such large patches are mostly mechanical changes (or even changes to generated files, as looks to be the case here), and hence fair parts of the patch won't need commenting on. It can therefore make sense to attach the full patch, but at the same time inline the non-mechanical parts for easier commenting. Such splitting will of course want pointing out very prominently. Jan