From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2085.outbound.protection.outlook.com [40.107.22.85]) by sourceware.org (Postfix) with ESMTPS id 0E7573858421 for ; Tue, 20 Dec 2022 13:10:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E7573858421 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1ZLuwvICSiCl7zioT47swzY3hBNg4bvEgn94oTUqmQjmSf6ZtKDKueTj2lDU8Zb1j9qOMSTl2TUFtMHVOmnqI9woG6QYTOI6Llm7v7+4iSx7PlGTOnXDhbmGJfW2w4QZemssEN97fo3l3U/Aa4XHtz9Xh6RGNmz8+XmvmPyoo7Qu1I4ZxiNT99sasgiQqznYExT3IDukEBrpfG1fF14g9GSXtU2iNDUN9VU658dvL46LXkuUNkpMc1iyxlOFU5or6/fMfcYxbI/X6vreji58q/DJqo9npTR5j05NEzmib4vax+CK+LQwADEeVjR5snGeFuMHfd/Xwtkzc/Alfzotg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cOVkRNjWieAHGK+TAV8m3pRpg/ZUpBJzRfY9RfZ4yXM=; b=lV5sDD9Q7cE18eAOMvtUK4PsRq2Lj81OLEFOC1a3SVxNRhFgJ7H8i9G1KdOndZoaEtnFKaJyVFmwQ4JjfuM+1Ny6EVtLT2o3gryRRLV5c39DBHT2uYumK2UFUIKTRKOLxpEDApX6MRvXPsuOJZUdhs+szMfs/Xhmci/K+NODzLQkAqK3RyqQsbTji1uerebfWB+dTmtCpGPMtfiMmOH/e3rzUpIM4k/jA//eQrDOuBSZZmblEJfISaS1XcCwhfmGKbiQhARByJGXSmbvxGZY+PK5mTB2weqIOUirFrArTipaSWtWdlIiUQPzkaJPxNxS57Cz5YzTy/iko8MilnJIgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cOVkRNjWieAHGK+TAV8m3pRpg/ZUpBJzRfY9RfZ4yXM=; b=uA9VxcBKd+LicFvP85bN1mcQiYZX4h7p4t4BvsuXlgzRQ4zOb4iKoCLMNDwxisM7vB/X2/6WGvyZhqhF4nnokVWlliZCswvowe4e9hX0WDKJPvEyCK53fu2YOJbZYpFGFgn2O2SJoynbKYuZ8Eb0BXL8uRoDvfjyseP38C+Q9vC36vFZ5WOXUUs89rBZWISQ9Shc8cfVdsw9JEIOhheOn6R9YJF2wiS2UnX5zkFmh99fRfnPo5fu/huOJDOwDmP2pVJy1IHsbQ0jLvsS8Qw+WKx4TWYW7CxH4xYhbOzqMs3TiYTVoAGRXQnXHlae7Jml5WfA4fiohpUW6ccwYCNL6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8123.eurprd04.prod.outlook.com (2603:10a6:10:243::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Tue, 20 Dec 2022 13:10:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5924.016; Tue, 20 Dec 2022 13:10:12 +0000 Message-ID: <0bdeeb13-acca-668f-09b5-709884267ebd@suse.com> Date: Tue, 20 Dec 2022 14:10:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/5] Fix size of external_reloc for pe-aarch64 Content-Language: en-US To: Mark Harmstone Cc: "binutils@sourceware.org" , "wej22007@outlook.com" , "zac.walker@linaro.org" , Tamar Christina References: <20221216021400.22309-1-mark@harmstone.com> <8415bffa-94a6-9570-f0e4-ddc02906c5f8@harmstone.com> From: Jan Beulich In-Reply-To: <8415bffa-94a6-9570-f0e4-ddc02906c5f8@harmstone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8123:EE_ X-MS-Office365-Filtering-Correlation-Id: 23a50ecb-7bf9-45e5-66eb-08dae28b872e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s9LmRL9dMC9JqYUB84YMZ+ciuR8SDgSwWw62PAiDIXY1odPdut2FvwyFBfN33/yzqyCHdjZ0T7PeXOlnygi0PM1lcPh07gUvq97g0zENTW3WVA2S2a3liPcTG8crohP794QNb93jzNKIuJadsh1QU+sBQlQPiNrU6OgMpFfC8xEvyim+aS8o+kLgwPFip3uZW5QrkpvPyHL7u/YARs8S8B4rdASaq+DJmXk2nEb1APnVOye5EFhRiKTcL75RXnzlU/8ugVXRXQVZk1esNNKFR4YrVuWQiDxP84I6c+wXkvV1mY+O90t129kv4xiRh4+SQd7RLHbAeUtjrqElrthCPEQuhBwL1APXMoKTV39IzsUHvNeGfyukhMKtWxCgtZZ4p0uyJiw250FJTS2hnyZZ6DGURyGkGvm1xnPgHtUT9hDYHO1KvXaetqKgd2z9rbXY3iBFjqCYeM2/yn4g6N9It0wBt54dm7P+TVane0dMggwJYH08QnwKugP0TFbcUjYZWlP2D8r9aEYygjMzT11SuJcOT2lt+60LtfnkD+rVL35GKFRAp8+tjEfW3byFjfVf7aFAJoE36VWXOnA8meEON9KEfMkW9g0ipy/rmGw51YVAjhSck1iJHW2B03ViDSBGBwRlASVpWR7reX9OMSEXyrca+loykESw68dxakc58DSvmPW95dIGPalMg7JNMRBSBRzOSppxb9i8zQEGnTGOH812cNWnXGkMitDR4RNqXPQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199015)(316002)(4326008)(8676002)(5660300002)(31686004)(26005)(4744005)(186003)(6916009)(6512007)(66556008)(86362001)(66476007)(31696002)(2616005)(66946007)(6506007)(6486002)(38100700002)(8936002)(53546011)(36756003)(41300700001)(54906003)(2906002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDFUc2x2QUhMTktEWUN3RE9vNXk5TmRmWGQyN3g3eElmOCt3MHkxZGR6aTdW?= =?utf-8?B?eVRzUjNGb0JiSGZ1NWJ0eTNWQVFPQnhKOS8wVHUzbGR6UDhZTlNXd2J2dWpv?= =?utf-8?B?cUNMVUlZY1BUNStoNUloNmgvVWh6aWt3Tkx4Q2h6OEhmclVYbWNLR0RORXVP?= =?utf-8?B?WVBXUnNmVEx5UUwyWFdSUXArMmViSFlyVEVQYmNEZ2NKMUgxNjk0eXBCdVV6?= =?utf-8?B?VTViT1NrM1NRdURtQTFwMGRMajkxNml2ZndvNytLVHl2SXpPSnh5Zmx1ek9h?= =?utf-8?B?NThHRU1JUFlYSnpTK1BzTFdIS2RSNHhQMU1heStLbjZZTVNmRDRMeUoxTFRZ?= =?utf-8?B?bHFwQk8xT01JQVhnOC81K2Zyb0FNMXJONFlwc3prOUhkYWlQUThuSVp1d2Zo?= =?utf-8?B?R2U2NTlodWw1d3RYSTRFN2NXd1RaaHhqbnBTZ05lcnBzZ1o5cXI4M3dQTDYv?= =?utf-8?B?Qm8wYjlkQTBnYnFGM1BlKy95UVlYL0ZGbU5rZTZrRERIR29WKzNyQ0hHaHBR?= =?utf-8?B?VVNMRk1nM2grekRzL0VxWWk4SjZFVngyQk1vd1lybDRFUnRCeTFLejhyWjND?= =?utf-8?B?VTd2VDB6UUV1T1BkUXp4YzJqTVdsWkNZYXlsMnBvalZBbkFWaStkNTNGemRR?= =?utf-8?B?Lzltc25xbmZWNFVpOEFPajc5REI0ZWFWR2Q4MldqLzR1aFdmVlBUN2E5cWdx?= =?utf-8?B?cXZ0UEJ6T2dSQWFXY2k4enIzRnl6clZKNW5xaUxGRTBPRGhYQWJCdERpd1NH?= =?utf-8?B?VXZjOFduN29xcWpqSEszZnB4RytkY0ZWMmU0L0hLZHgxOXNLcmRUbGJ1WUFu?= =?utf-8?B?bXMzTXJudlpFVUdjZjFuMzZDYUoxTU9vaVFzN1JYMU50MkVjMmZXUE5Lbmpv?= =?utf-8?B?NC9TZVhWb2tuUW53Z08zVzNUMnRESEptM3Z3bnVyd2d3a3FsT3NLYzZ4TWxq?= =?utf-8?B?Uzlydm9vbWxNY3FYQndWT3BlVUVMV2RlYnc3eU5ja2pmMlQrUG12RXhlWUpU?= =?utf-8?B?NkI4WStNL3I5eS81cTFPNnVXOGVLd3ZacVpLWnc5M0I1bCttUVl5a0hlS3p6?= =?utf-8?B?YlAraTQrT1lCbHpJRnlvdDBVdFlLMHlWMzBIUDhObXl0cFdmNjIzT2gwaE01?= =?utf-8?B?d3JrQlVFL3VhblQ2ZENNTURNT1gyY1ArY0xBaXJiYVFVMW0zTFg3MUp6Yzhq?= =?utf-8?B?SHZiYlVMSXk5ZDI3NzVTWldXVzFnTDNuMVNoMzgrWGF5Slp5RWtTSW02NUJF?= =?utf-8?B?d2w5ZnBpb2k0MnJRVll1VlM3b1ZmY21NTEJGenpreFNrMi84TWFudGJBR3lZ?= =?utf-8?B?dk4wUkNhUmMwMTJjbmM2UmQwUzRDTWJwVUNCZ1JvOUYrLzJhMmM4aVluSEs1?= =?utf-8?B?TDRFOTA1aVo0dDZhOXNUL0dEY0xBcHZoS013d3dmMVRwcko3bXVETXRvejlW?= =?utf-8?B?UWZMUTdCRlViR1RSeUtDbUpuMnFTRW1SUW1mT2VHc0pnZWM1Y0JYOG1JL01B?= =?utf-8?B?VEtaa00rL1NZc3krYXJaREFyWGpwclpDMUNwS3lqQkdUZlFla1Q2ZjBsNXQv?= =?utf-8?B?b3BQMDYzMTI0OTl5MFpKaGV3UTFUWXRqQ1UxV0ZvTnVodjRyczluUE1INDh1?= =?utf-8?B?b0RwdEpwNFhpUE5pNEZNdXJvenBjNXlUZjV4VDdUVDdiTWdzaW9GTSsrQjZO?= =?utf-8?B?N2piZ0Nia2FvVk5jTS8rU3FEZ1lpQWx3eFlHaGZsbTFnUWNXeFV4c0kwTXJl?= =?utf-8?B?WHQvNlROS2NkOUt6RXhQMmtSck5mUVErYmZaM0lqaFlGQ0dYVFM5bHN1b3Yx?= =?utf-8?B?cDNpWVdWOTZIUE5tMWlVVU01TXFwN2xNZy9iVUJ0L3FPVisxTE02NFZTQlhi?= =?utf-8?B?bmpOY1lORmUwb1dVLzU4RFV1TkVwVHBDZnR6Qy9XU1lGc21wRTlGcWlHcmhR?= =?utf-8?B?UFl3Nlc1T2lzaUp1YlhZaUNkMUhlMmZjaUhiUjhiTDRucFZ0dVZvaXJiZU9J?= =?utf-8?B?UnZIbmZ2T0V0eUdnaFVPUG5GNFpDQjliMVZIQ0d6UzNSbGVpZ3NRMDd4b3JB?= =?utf-8?B?RkNXaWRsS1MyendTV2JwSjdtUzJ6bCswdzhJTHNyZGx2UTlvTk1pNjJZVlMx?= =?utf-8?Q?6Yki4ZsUGLjT6n3iCfm/zxB1f?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23a50ecb-7bf9-45e5-66eb-08dae28b872e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2022 13:10:12.8111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ejMwtPwS/O4g792Rc7A/5BmjeTIgpUZOGpECGCrjzOTCyLFeeudK54J2A+cfhE9qRdAzUR9m32zjsCEn2q14Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8123 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.12.2022 13:59, Mark Harmstone wrote: > On 16/12/22 10:47, Tamar Christina wrote: >> >> The code was taken from the Arm port which weirdly had a different size >> for this whether it was a WINCE target or not. For WINCE target it has 10, but for >> everything else 14 (See include/coff/arm.h). Since I didn't have relocations >> support anyway (the original intention was only to support objcopy workflow) >> I didn't dig too deeply into why Arm has it as 14 and the extra field. >> >> That said 10 looks to be the correct value. >> >> Thanks, >> Tamar > > Thanks Tamar. Sorry, I should have copied you in in the first place. > > I can't remember the specifics, but I definitely needed this patch to get EXEs working on Windows. But EXEs don't use this kind of relocation; the base relocations (fixups) used there are encoded in an entirely different way. The relocs here should matter for are COFF object files only. Jan