From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id C1F653858D34 for ; Thu, 30 Jan 2025 16:04:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1F653858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1F653858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738253060; cv=none; b=FWf/bkIkInxSg8gKVt1WhHnRIjUrbYSyWlrSBDFgsL0qQ3sS6i9i6peE4Qmn6aeT3wux7MSrpGSNLwafSP/9YZRRkqfI+/brGnj6kCCxyDyzNZs7HoYIw5pQnYASbCafaQvyidvT6WXRdBYdOabdPyWtiYZ0BmsZbSkaanR6lD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738253060; c=relaxed/simple; bh=zZnRb+xdKZkSEqjyCjZUdMNvb36I2AK+U48FFKhkiog=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=EKYURmsbp3Sz6c2UWLWZ6easV69ODOIRPnYljKnXIJHhAndzR7loH+q7VtEbbzLzS0Src3gQIsr0ojiMOj1d4ecfjoX5+r17yE0AB6JmX+B65Qna/Hk8YTMu1diH36xKii0XQx1Wdmz/38BQyVHwETXU0ZmywtQN/UlYG2876K8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1F653858D34 Received: from loongson.cn (unknown [119.182.2.20]) by gateway (Coremail) with SMTP id _____8CxyuAAo5tnCIpqAA--.10420S3; Fri, 31 Jan 2025 00:04:17 +0800 (CST) Received: from [192.168.21.9] (unknown [119.182.2.20]) by front1 (Coremail) with SMTP id qMiowMBxnsf_optnhOwxAA--.24196S2; Fri, 31 Jan 2025 00:04:15 +0800 (CST) Message-ID: <0bf082c3-fd16-4d48-b5ff-d338d020970c@loongson.cn> Date: Fri, 31 Jan 2025 00:04:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] LoongArch: Do not relax against __[start|stop]_SECNAME symbol To: Nick Clifton , binutils@sourceware.org Cc: mengqinggang@loongson.cn References: <20250122090010.3585171-1-cailulu@loongson.cn> <34673142-273b-493c-8efe-54aa3e1957ba@loongson.cn> <7b530829-8a4e-4b49-90ea-99240df283f2@redhat.com> From: Lulu Cai In-Reply-To: <7b530829-8a4e-4b49-90ea-99240df283f2@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:qMiowMBxnsf_optnhOwxAA--.24196S2 X-CM-SenderInfo: xfdlz3tox6z05rqj20fqof0/1tbiAgESB2eatlsHFQABsV X-Coremail-Antispam: 1Uk129KBj93XoW7GryftF45ArWfZr4fuw1xWFX_yoW8JF17pa 92gFs5XrWvyF97Zwn7uw1DXan7t3s7GryDAw15GFy8CF4DWr95XrySvF4rX3ZxAr1Y9w4r X3y29FW8XwsxXFXCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUyGb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Jr0_Gr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCF04k20xvY0x0EwIxGrw CFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE 14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2 IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxK x2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI 0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1QVy3UUUUU== X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/28/2025 9:45 PM, Nick Clifton wrote: > Hi Lulu, > >>    This patch fixes a relaxation bug for LoongArch and needs to be >> applied to 2.44 branch and the mainline source. >> >>    link: >> https://sourceware.org/pipermail/binutils/2025-January/138943.html > > When I test this patch on my local machine (an x86_64 box) I get a > new linker testsuite failure: > >   FAIL: ld-loongarch-elf/start_stop > > The reason, according to ld.log is: > >   Executing on host: sh -c {./ld-new > -L/work/sources/binutils/upstream/2.44/ld/testsuite/ld-loongarch-elf > -z norelro -pie -e0 -o tmpdir/dump tmpdir/start_stop.o 2>&1} /dev/null > dump.tmp (timeout = 300) >   spawn [open ...] >   ./ld-new: -pie not supported >   failed with: <./ld-new: -pie not supported>, no expected output > > I think that this must be a problem with my local setup, so please > go ahead and apply the fix to both the mainline and the 2.44 branch. Hi Nick,   Thanks for the problem report otherwise I would have missed it.   I have sent patch V2 to fix it by checking for loongarch64 target and pie support. Please apply this patch to mainline and 2.44 branch.   Link: https://sourceware.org/pipermail/binutils/2025-January/139161.html Thanks   Lulu