From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 7AA003858428 for ; Thu, 2 Mar 2023 09:23:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AA003858428 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.20.4.171]) by gateway (Coremail) with SMTP id _____8BxONn0agBkrTAHAA--.8144S3; Thu, 02 Mar 2023 17:23:01 +0800 (CST) Received: from [10.20.4.171] (unknown [10.20.4.171]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxPuT0agBkLltGAA--.24316S3; Thu, 02 Mar 2023 17:23:00 +0800 (CST) Subject: Re: [PATCH v4 0/6] LoongArch: colored disassembly and readability tweaks To: WANG Xuerui , binutils@sourceware.org Cc: Chenghua Xu , Zhensong Liu , Xi Ruoyao , WANG Xuerui References: <20230215180303.620184-1-i.swmail@xen0n.name> From: mengqinggang Message-ID: <0c0f7489-340e-e34d-969f-115ad1808113@loongson.cn> Date: Thu, 2 Mar 2023 17:23:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20230215180303.620184-1-i.swmail@xen0n.name> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8CxPuT0agBkLltGAA--.24316S3 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBjvJXoWxZw4xGFWxGw48Kw1DGFyUJrb_yoW5Gw1rpF y3ZFn0yr4kCFs3WF1kW345Xrn7Jw4xKrWaqF1ftw1I9r1Svry2vr18t3s3ZFW5J3y0ga4f Xr4fGr15ZF1UtwUanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bI8YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwA2z4 x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1l e2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4xG64xvF2 IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r1j6r4U McvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487Mx AIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_ Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwI xGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8 JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcV C2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUwmhFDUUUU X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,MIME_CHARSET_FARAWAY,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Whether these patches should consider copyright issues and add a sign-off at the of the commit message? ÔÚ 2023/2/16 ÉÏÎç2:02, WANG Xuerui дµÀ: > From: WANG Xuerui > > Hi, > > This series implements colored output for LoongArch disassembly, and > some minor tweaks to the output so there is less clutter. > > Changes from v3: > > - Fixed ld test cases (make check-gas and make check-ld both pass on > x86_64 and loongarch64) > - Branch target address is now correctly printed in comment style, plus > code simplification as suggested > > Changes from v2: > > - Fixed test cases > - Added the fixed "LoongArch: support disassembling certain pseudo- > instructions" patch into this series > - Fixed ".insn" in the last patch to say ".word" instead (MIPS muscle > memory strikes back hard) > - Fixed some commit messages > - Added mengqinggang to Cc list > > WANG Xuerui (6): > LoongArch: support disassembling certain pseudo-instructions > opcodes/loongarch: remove unused code > opcodes/loongarch: implement style support in the disassembler > opcodes/loongarch: style disassembled address offsets as such > opcodes/loongarch: do not print hex notation for signed immediates > opcodes/loongarch: print unrecognized insn words with the .word > directive > > gas/config/tc-loongarch.c | 3 +- > gas/testsuite/gas/loongarch/imm_ins.d | 84 ++++++------- > gas/testsuite/gas/loongarch/imm_ins_32.d | 54 ++++----- > gas/testsuite/gas/loongarch/imm_op.d | 44 +++---- > gas/testsuite/gas/loongarch/jmp_op.d | 44 +++---- > gas/testsuite/gas/loongarch/li.d | 8 +- > gas/testsuite/gas/loongarch/load_store_op.d | 80 ++++++------ > gas/testsuite/gas/loongarch/macro_op.d | 4 +- > gas/testsuite/gas/loongarch/macro_op_32.d | 4 +- > .../gas/loongarch/macro_op_large_abs.d | 14 +-- > .../gas/loongarch/macro_op_large_pc.d | 14 +-- > gas/testsuite/gas/loongarch/nop.d | 2 +- > gas/testsuite/gas/loongarch/privilege_op.d | 8 +- > gas/testsuite/gas/loongarch/raw-insn.d | 11 ++ > gas/testsuite/gas/loongarch/raw-insn.s | 7 ++ > gas/testsuite/gas/loongarch/reloc.d | 2 +- > include/opcode/loongarch.h | 7 +- > ld/testsuite/ld-loongarch-elf/jmp_op.d | 40 +++--- > ld/testsuite/ld-loongarch-elf/macro_op.d | 24 ++-- > opcodes/disassemble.c | 5 + > opcodes/loongarch-dis.c | 114 ++++++++---------- > opcodes/loongarch-opc.c | 73 ++++++----- > 22 files changed, 333 insertions(+), 313 deletions(-) > create mode 100644 gas/testsuite/gas/loongarch/raw-insn.d > create mode 100644 gas/testsuite/gas/loongarch/raw-insn.s >