From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 94125385803F for ; Fri, 5 Jan 2024 12:03:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94125385803F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 94125385803F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704456236; cv=none; b=qo/21Ocm7LT/+b2HhzmpfDorFUj4OUoimv4Bivl46NoISs0aZJfcKQBGjUa9qbrlheOap0y80Lm3N7oXgSrPhmwVhRusspqkkl2hkCb8GFyz190Cj1JygAt1jyBl7BCkmSQikWf9OOlXWHs5HdtTZrLi13dUA/OBH9kn0M3qc+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704456236; c=relaxed/simple; bh=YX7HNr2oz26v+p4KFRBpS7QFqVn+k3+HeTrwYYUtdg4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Ft2+I4aHRJ/xxBY0LB2rXpWIO8gRokxa5J9qEnaIc1DsZ/Gsyx5crU5Yqn1LNynwu7Dfl817/qGOn9RY1MAER3856A2kKEcd3EstTytatP/DeE4tRBgOJ/ELoZPOt4S/I8ysdUj9QPcZz+H5hOGFW75ro/AcuR95yjBj6LVk/lw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50eabbc3dccso1633880e87.2 for ; Fri, 05 Jan 2024 04:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704456233; x=1705061033; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s50JxFVHR5LTiccwVbE3oYd3k1IKZw7wRe9PKNpjkpA=; b=Mv58bxmyudTL3prQwRLCTWXu8xqgmYOWB/bZLSQrff8aU2nxA9KI7L29srek44HItO JSdV8XvQS5UIbqkXbgQVQ2stfLrzBqnb1D2anvr90w3TZKYB3OugibtMZ99i6avlW+bf +hqzF4Ei+JArlDd8mPzYn7VDQ+oaxxEV2oZ2jYwSuVTmyequbdHEm8OwyonxJpieBRs/ kg6KL7MdeHc8PFwervq1Zfaxkd2FCIQJkCNJwB39fLGP1RXrYqEod5QNUi1Rmqr/HczE 0ZlAIINuRIfKT0Df6hQZ2rtdnkKEjGqtdOQOA+DtBeks9fhZmUpiiek8HzHG1ZSMmjPK VdMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704456233; x=1705061033; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s50JxFVHR5LTiccwVbE3oYd3k1IKZw7wRe9PKNpjkpA=; b=FQmdDKTRZSs6yJiLO9RUIkYia8vgUiLyBpMlQm1ApAPGFvb4l1qGzTIymD9t+mcZsO 0EKbW6D6/Ylt0A+4Qvs5H4wi5h0+9ho3ASGzH1XY2lxqEgpJxVf15r06KLzIBumL6ZFD toG5DYGyfrj7wZGALOZYNugVcSVp0CDpYEnMz8cwvSK6qS6Lb+kbTfAbmGSiXYjGNfCT 98ZIOQMpcxPjcYWaEsFTefE+h9gtGNbiIcL8onYAk8FYHYkeY4nAThL6/k+/ZVTyMalR eufcZK64mxAhIMio2oHMuvc3kFDcyzYUYH/P8jr9bM+zoPhiLbxvjOjBd42jBW0Mhf9i epIA== X-Gm-Message-State: AOJu0YziFS3RrwyilSkVkI77D0BVhWfAtNz16k1zn7PXzn8zK4Ez6Y8Y +uQWLn/xAt1uev96zqEirZiCjUHYOhZ0 X-Google-Smtp-Source: AGHT+IFdsjYVxTQDVAhXp8l2ucahGUHHp3zg2U7haybBKUEXbmAse4oJhqlgZUouGh7AdfuV0eJ6Pg== X-Received: by 2002:a05:6512:98a:b0:50e:7be8:4705 with SMTP id w10-20020a056512098a00b0050e7be84705mr474867lft.260.1704456233020; Fri, 05 Jan 2024 04:03:53 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id fx21-20020a0566381e1500b0046d177c2504sm375245jab.140.2024.01.05.04.03.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 04:03:52 -0800 (PST) Message-ID: <0c54069e-d907-4f03-8d7f-15374d4bfd6a@suse.com> Date: Fri, 5 Jan 2024 13:03:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bfd: make _bfd_section_size_insane part of the public API Content-Language: en-US To: Andrew Burgess References: Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.12.2023 17:15, Andrew Burgess wrote: > If a BFD user is making use of a function like > bfd_get_section_contents to read a section into a pre-allocated > buffer, then that BFD user might also want to make use of > _bfd_section_size_insane prior to allocating the buffer they intend to > use in order to validate that the buffer size that plan to allocate is > sane. > > This commit makes _bfd_section_size_insane public, by renaming it to > bfd_section_size_insane. > > I've updated the existing uses within bfd/, I don't believe this > function is used outside of bfd/ currently. > > One place that I plan to make use of this function is in > gdb/gdb_bfd.c, in the function gdb_bfd_get_full_section_contents. > This change isn't included in this commit, but will come later if/when > this has been merged into bfd. Having seen your ping (and no other response), let me share my view: This function implements a certain policy, internal to the library. By exposing it, you would make external users dependent upon this specific policy. What if later we change our view on what's "insane"? IOW external consumers want to implement their own, independent policy (if so desired). Taking your intended usage example, things would be different if e.g. bfd_get_full_section_contents() itself used this check unconditionally. Then I could see a desire to have a way of checking up front whether allocating a buffer makes sense at all. And really I consider it questionable for bfd_get_full_section_contents(), when asked to allocate a buffer, to actually enforce such a library-internal policy. Like with exposing bfd_section_size_insane(), any change to the policy may affect external users in unexpected ways. Jan