From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5CFC5385770E for ; Tue, 16 May 2023 13:28:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CFC5385770E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684243685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4IALsPDGBVPaxmbg5mZDafkghrEzwUi8fjsISQVAvvk=; b=Yl86UbVhG4p3vMAj+TpIxbYlgUu/Fq3TYs8uQOWNPWjtzjCGPNcQ1ze7aflWA1Mk02UE6+ lQcZulKeZFGR/+G/V0PoNRvua5bde64EJfIHUJP6GrGezZnkV2D7w6iK/Tp3TYy0AYSgSU AsLDoDNGYc61UCAz+7UYqLZ9/qDbr8U= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-WvyehzUGNEyG0-vbEWF-kg-1; Tue, 16 May 2023 09:28:03 -0400 X-MC-Unique: WvyehzUGNEyG0-vbEWF-kg-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-61af548a8feso85590296d6.0 for ; Tue, 16 May 2023 06:28:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684243682; x=1686835682; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4IALsPDGBVPaxmbg5mZDafkghrEzwUi8fjsISQVAvvk=; b=Hjdw3VfuO11AwgMriY1jlDOKy/BfYQTdDWl1X2ZS6J5k+zHRFXuK34U05ziQGSkENN GHzrau8Y0qdtI0OzCwwVnfgJK3x72aDEtwJPyGKWCmvnwSE2Wj1NogDutAw8D+HhNST4 VnpGACUTQvuH9Af8fUrep7vt0t9v6Ns/dsN/x/p9SXKPltiD1GV/YT5halIFDev0vAHt U9YFScE38GXHq/XNfZyQTayw6X+x7Mv2nL4NIXvzMvBkCSgvf85nY0qhoEi7IcxzI3KM VkjtLp1WY6Xnhnzqls8qsIhjtStL4icFb8wWEcFENGwaLxm23vcKLlKtkez2yi4t8Zrm irtA== X-Gm-Message-State: AC+VfDyOAWrhOieYozRq2bV8d25CvHqvGezZ1bIynOTXin+SRXUDjE28 PVA7SR+4663LNuLcN4rKnQIeVnMBph4kLYFYJvLnLmpJtXfdBq0Zy6NB1s1eaHJuxE0L0yPs3+6 ZjSs87s+reusBWvwzxONZBQBhYQ== X-Received: by 2002:a05:622a:301:b0:3f5:456b:d565 with SMTP id q1-20020a05622a030100b003f5456bd565mr1895400qtw.24.1684243682751; Tue, 16 May 2023 06:28:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7GeZXU7JWL2RUlkDaHaUtMq8RQugZQjwm8Rq/Nsg0xEz9DBhHaG1wf9nJx3P/sBygCFZmb/w== X-Received: by 2002:a05:622a:301:b0:3f5:456b:d565 with SMTP id q1-20020a05622a030100b003f5456bd565mr1895376qtw.24.1684243682511; Tue, 16 May 2023 06:28:02 -0700 (PDT) Received: from [192.168.1.7] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id cp8-20020a05622a420800b003ef13aa5b0bsm6171572qtb.82.2023.05.16.06.28.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 06:28:01 -0700 (PDT) Message-ID: <0c55df39-8977-a7c8-263b-c451cc2ade03@redhat.com> Date: Tue, 16 May 2023 14:27:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] add section caches to coff_data_type To: Oleg Tolmatcev Cc: binutils@sourceware.org References: <9cccec92-8a1d-445d-2d1d-16abcf870295@redhat.com> From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Oleg, > Thanks for the review. I have attached the certificate and signed the > patch. I don't know where to free the hash tables, that's why I didn't > do it. The new patch is below. I have gone ahead and applied your patch, with the addition of some extra code to bfd/coffgen.c:_bfd_coff_close_and_cleanup() to free the hash tables. Cheers Nick