public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* PR32599, objcopy -I ihex: invalid operation
@ 2025-01-26  4:36 Alan Modra
  2025-01-27 13:13 ` Matthias Klose
  0 siblings, 1 reply; 2+ messages in thread
From: Alan Modra @ 2025-01-26  4:36 UTC (permalink / raw)
  To: binutils

Restores ihex get_symtab_upper_bound to what it was prior to commit
394a3f4f8d.  This will enable objcopy of other no-sym formats too.

	PR 32599
	* libbfd-in.h (_bfd_nosymbols_get_symtab_upper_bound): Define
	as _bfd_long_bfd_0.
	* libbfd.h: Regenerate.

diff --git a/bfd/libbfd-in.h b/bfd/libbfd-in.h
index 2c0d33142c6..b2f70fbfdac 100644
--- a/bfd/libbfd-in.h
+++ b/bfd/libbfd-in.h
@@ -415,7 +415,7 @@ extern bool _bfd_vms_lib_ia64_mkarchive
 /* Routines to use for BFD_JUMP_TABLE_SYMBOLS where there is no symbol
    support.  Use BFD_JUMP_TABLE_SYMBOLS (_bfd_nosymbols).  */
 
-#define _bfd_nosymbols_get_symtab_upper_bound _bfd_long_bfd_n1_error
+#define _bfd_nosymbols_get_symtab_upper_bound _bfd_long_bfd_0
 extern long _bfd_nosymbols_canonicalize_symtab
   (bfd *, asymbol **) ATTRIBUTE_HIDDEN;
 #define _bfd_nosymbols_make_empty_symbol _bfd_generic_make_empty_symbol
diff --git a/bfd/libbfd.h b/bfd/libbfd.h
index 41da1e9a312..86f220380a8 100644
--- a/bfd/libbfd.h
+++ b/bfd/libbfd.h
@@ -421,7 +421,7 @@ extern bool _bfd_vms_lib_ia64_mkarchive
 /* Routines to use for BFD_JUMP_TABLE_SYMBOLS where there is no symbol
    support.  Use BFD_JUMP_TABLE_SYMBOLS (_bfd_nosymbols).  */
 
-#define _bfd_nosymbols_get_symtab_upper_bound _bfd_long_bfd_n1_error
+#define _bfd_nosymbols_get_symtab_upper_bound _bfd_long_bfd_0
 extern long _bfd_nosymbols_canonicalize_symtab
   (bfd *, asymbol **) ATTRIBUTE_HIDDEN;
 #define _bfd_nosymbols_make_empty_symbol _bfd_generic_make_empty_symbol

-- 
Alan Modra

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PR32599, objcopy -I ihex: invalid operation
  2025-01-26  4:36 PR32599, objcopy -I ihex: invalid operation Alan Modra
@ 2025-01-27 13:13 ` Matthias Klose
  0 siblings, 0 replies; 2+ messages in thread
From: Matthias Klose @ 2025-01-27 13:13 UTC (permalink / raw)
  To: Alan Modra, binutils

On 26.01.25 05:36, Alan Modra wrote:
> Restores ihex get_symtab_upper_bound to what it was prior to commit
> 394a3f4f8d.  This will enable objcopy of other no-sym formats too.
> 
> 	PR 32599
> 	* libbfd-in.h (_bfd_nosymbols_get_symtab_upper_bound): Define
> 	as _bfd_long_bfd_0.
> 	* libbfd.h: Regenerate.

that's a regression, please could you apply this to the 2.44 branch as well?

thanks, Matthias


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-27 13:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-26  4:36 PR32599, objcopy -I ihex: invalid operation Alan Modra
2025-01-27 13:13 ` Matthias Klose

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).